fortrangoingonforty/facsimile / b251bb4

Browse files

refactor: Eliminate 108 compiler warnings (118 -> 10)

Removed 19 unused local variables across modules:
- syntax_highlighter, diagnostics_panel, input_handler
- lsp_server_manager, lsp_client, completion_popup
- hover_tooltip, signature_tooltip, renderer, command_handler

91% reduction in compiler noise - remaining 10 are intentional
(stub function parameters documenting incomplete implementations)
Authored by espadonne
SHA
b251bb453c018efddc51e9d196ac229606c6faa5
Parents
f0cdbb9
Tree
9c2be45

10 changed files

StatusFile+-
M src/commands/command_handler_module.f90 3 4
M src/lsp/lsp_client_module.f90 0 1
M src/lsp/lsp_server_manager_module.f90 0 1
M src/syntax/syntax_highlighter_module.f90 1 4
M src/terminal/input_handler_module.f90 1 1
M src/terminal/renderer_module.f90 1 1
M src/ui/completion_popup_module.f90 2 2
M src/ui/diagnostics_panel_module.f90 2 3
M src/ui/hover_tooltip_module.f90 1 1
M src/ui/signature_tooltip_module.f90 1 1
src/commands/command_handler_module.f90modified
@@ -5927,11 +5927,10 @@ contains
59275927
         use code_actions_panel_module, only: code_action_t
59285928
         type(editor_state_t), intent(inout) :: editor
59295929
         type(lsp_message_t), intent(in) :: response
5930
-        type(json_value_t) :: result_array, action_obj, edit_obj
5930
+        type(json_value_t) :: result_array, action_obj
59315931
         type(code_action_t), allocatable :: actions(:)
59325932
         integer :: num_actions, i
59335933
         character(len=:), allocatable :: title, kind, action_json
5934
-        logical :: is_preferred
59355934
59365935
         ! The result is directly in response%result for LSP responses
59375936
         result_array = response%result
@@ -6679,10 +6678,10 @@ contains
66796678
         use workspace_symbols_panel_module, only: workspace_symbol_t, set_workspace_symbols
66806679
         integer, intent(in) :: request_id
66816680
         type(lsp_message_t), intent(in) :: response
6682
-        type(json_value_t) :: result_array, symbol_obj, location_obj, range_obj, start_obj
6681
+        type(json_value_t) :: symbol_obj, location_obj, range_obj, start_obj
66836682
         integer :: num_symbols, i
66846683
         type(workspace_symbol_t), allocatable :: symbols(:)
6685
-        character(len=:), allocatable :: name, kind_str, container, uri
6684
+        character(len=:), allocatable :: name, container, uri
66866685
         real(8) :: line_num, char_num, kind_num
66876686
66886687
         num_symbols = json_array_size(response%result)
src/lsp/lsp_client_module.f90modified
@@ -96,7 +96,6 @@ contains
9696
         character(len=*), intent(in) :: file_path, content
9797
         character(len=*), intent(in), optional :: language_id
9898
         type(document_info_t), allocatable :: new_documents(:)
99
-        type(lsp_server_t), pointer :: server
10099
         type(lsp_message_t) :: msg
101100
         character(len=:), allocatable :: lang_id, uri
102101
         integer :: i, server_index
src/lsp/lsp_server_manager_module.f90modified
@@ -538,7 +538,6 @@ contains
538538
         type(lsp_server_t), intent(inout) :: server
539539
         character(len=65536) :: buffer
540540
         integer :: bytes_read
541
-        type(lsp_message_t) :: msg
542541
543542
         ! Read from server
544543
         bytes_read = lsp_read_message_f(server%handle, buffer, len(buffer))
src/syntax/syntax_highlighter_module.f90modified
@@ -136,10 +136,7 @@ contains
136136
         type(syntax_highlighter_t), intent(inout) :: highlighter
137137
         character(len=*), intent(in) :: line
138138
         type(token_t), allocatable, intent(out) :: tokens(:)
139
-        integer :: i, j, line_len, token_count
140
-        logical :: in_string, in_comment
141
-        character(len=1) :: ch
142
-        character(len=:), allocatable :: word
139
+        integer :: i, line_len, token_count
143140
144141
         if (.not. highlighter%enabled) then
145142
             allocate(tokens(1))
src/terminal/input_handler_module.f90modified
@@ -690,7 +690,7 @@ contains
690690
         character(len=*), intent(out) :: key_str
691691
         character, intent(in) :: series      ! '1' for ESC[1X~, '2' for ESC[2X~
692692
         character, intent(in) :: fkey_code   ! The X in ESC[1X~ or ESC[2X~
693
-        character :: ch, modifier_ch
693
+        character :: modifier_ch
694694
         integer :: char_code, modifier
695695
         character(len=10) :: base_key
696696
src/terminal/renderer_module.f90modified
@@ -1982,7 +1982,7 @@ contains
19821982
         use editor_state_module, only: pane_t
19831983
         type(editor_state_t), intent(inout) :: editor
19841984
         integer, intent(in) :: start_col, width
1985
-        integer :: tab_idx, active_pane, i
1985
+        integer :: tab_idx, active_pane
19861986
         type(pane_t) :: pane
19871987
         integer :: screen_row, screen_col
19881988
src/ui/completion_popup_module.f90modified
@@ -78,9 +78,9 @@ contains
7878
     subroutine handle_completion_response(popup, response)
7979
         type(completion_popup_t), intent(inout) :: popup
8080
         type(json_value_t), intent(in) :: response
81
-        type(json_value_t) :: items_array, item, text_edit
81
+        type(json_value_t) :: items_array, item
8282
         integer :: i, n_items, kind_num
83
-        character(len=:), allocatable :: label, kind_str, detail, insert_text
83
+        character(len=:), allocatable :: label, detail, insert_text
8484
8585
         call cleanup_completion_popup(popup)
8686
src/ui/diagnostics_panel_module.f90modified
@@ -84,7 +84,7 @@ contains
8484
         type(diagnostics_store_t), intent(in) :: diagnostics_store
8585
         character(len=*), intent(in) :: file_uri
8686
         integer, intent(in) :: screen_rows, screen_cols
87
-        integer :: start_col, row, i, visible_items, item_idx
87
+        integer :: start_col, row, i, visible_items
8888
         character(len=256) :: line_buffer
8989
         character(len=5) :: severity_marker
9090
         character(len=10) :: severity_color
@@ -131,7 +131,7 @@ contains
131131
132132
         ! Render diagnostics with wrapping for selected item
133133
         block
134
-            integer :: screen_line, diag_idx, wrap_line, num_wrap_lines
134
+            integer :: screen_line, diag_idx, wrap_line
135135
             integer :: max_content_lines
136136
             logical :: is_selected
137137
@@ -392,7 +392,6 @@ contains
392392
         type(diagnostics_panel_t), intent(inout) :: panel
393393
         character(len=*), intent(in) :: key
394394
         logical :: handled
395
-        integer :: max_visible
396395
397396
         handled = .false.
398397
         if (.not. panel%visible) return
src/ui/hover_tooltip_module.f90modified
@@ -51,7 +51,7 @@ contains
5151
     subroutine handle_hover_response(tooltip, response)
5252
         type(hover_tooltip_t), intent(inout) :: tooltip
5353
         type(json_value_t), intent(in) :: response
54
-        type(json_value_t) :: contents, markup_content
54
+        type(json_value_t) :: contents
5555
         character(len=:), allocatable :: hover_text, language, value
5656
5757
         call cleanup_hover_tooltip(tooltip)
src/ui/signature_tooltip_module.f90modified
@@ -211,7 +211,7 @@ contains
211211
         type(signature_tooltip_t), intent(inout) :: tooltip
212212
         type(lsp_message_t), intent(in) :: response
213213
         type(json_value_t) :: result_obj, signatures_array, sig_obj
214
-        type(json_value_t) :: params_array, param_obj, param_label_obj
214
+        type(json_value_t) :: params_array, param_obj
215215
         integer :: num_signatures, num_params, i, j
216216
         character(len=:), allocatable :: label, doc
217217
         real(8) :: active_sig_real, active_param_real