`bdd4698`

fix compiler warnings remainder except buffer

Authored by

espadonne 6 months ago

SHA: bdd4698d8ad1baf969682e274909dddc5153f833
Parents: 8070cd7
Tree: d6ce330

5 changed files

Status	File	+	-
M	`src/commands/command_handler_module.f90`	15	173
M	`src/terminal/input_handler_module.f90`	2	3
M	`src/terminal/renderer_module.f90`	3	50
M	`src/ui/help_display_module.f90`	0	25
M	`src/workspace/file_tree_module.f90`	2	2

src/commands/command_handler_module.f90modified

          ! Selection with shift+motion
          case('shift-up')
 -            call extend_selection_up(editor%cursors(editor%active_cursor), buffer, line_count)
 +            call extend_selection_up(editor%cursors(editor%active_cursor), buffer)
              call sync_editor_to_pane(editor)
              call update_viewport(editor)
              if (size(editor%cursors) > 1) then
                  ! Move all cursors
                  do i = 1, size(editor%cursors)
 -                    call move_cursor_page_up(editor%cursors(i), editor, line_count)
 +                    call move_cursor_page_up(editor%cursors(i), editor)
                  end do
              else
 -                call move_cursor_page_up(editor%cursors(editor%active_cursor), editor, line_count)
 +                call move_cursor_page_up(editor%cursors(editor%active_cursor), editor)
              end if
              call sync_editor_to_pane(editor)
              call update_viewport(editor)
              call update_viewport(editor)
          case('shift-pageup')
 -            call extend_selection_page_up(editor%cursors(editor%active_cursor), editor, line_count)
 +            call extend_selection_page_up(editor%cursors(editor%active_cursor), editor)
              call sync_editor_to_pane(editor)
              call update_viewport(editor)
              ! Add cursor on line above
              ! opt-meta-up: Doesn't work (terminals don't send Cmd)
              ! ctrl-alt-up: Alternative binding that works
 -            call add_cursor_above(editor, buffer)
 +            call add_cursor_above(editor)
              call sync_editor_to_pane(editor)
              call update_viewport(editor)
          if (allocated(line)) deallocate(line)
      end subroutine move_cursor_end
 -    subroutine move_cursor_page_up(cursor, editor, line_count)
 +    subroutine move_cursor_page_up(cursor, editor)
          type(cursor_t), intent(inout) :: cursor
          type(editor_state_t), intent(in) :: editor
 -        integer, intent(in) :: line_count
          integer :: page_size
          cursor%has_selection = .false.  ! Clear selection
          type(buffer_t), intent(in) :: buffer
          character(len=:), allocatable :: line
          integer :: pos, line_len
 -        logical :: in_word
          cursor%has_selection = .false.  ! Clear selection
          line = buffer_get_line(buffer, cursor%line)
          type(buffer_t), intent(in) :: buffer
          character(len=:), allocatable :: line
          integer :: pos, line_count, line_len
 -        logical :: in_word
          cursor%has_selection = .false.  ! Clear selection
          line = buffer_get_line(buffer, cursor%line)
          character, intent(in) :: ch
          integer :: i
          integer :: offset_adjust
 -        integer :: cursors_before
          ! Sort cursors by position to handle offset adjustments
          call sort_cursors_by_position(editor)
          end do
      end subroutine insert_line_text
 -    subroutine get_line_positions(buffer, line_num, start_pos, end_pos)
 -        type(buffer_t), intent(in) :: buffer
 -        integer, intent(in) :: line_num
 -        integer, intent(out) :: start_pos, end_pos
 -        integer :: current_line, i
+-
 -        current_line = 1
 -        start_pos = 1
+-
 -        ! Find start of requested line
 -        do i = 1, buffer%size
 -            if (current_line == line_num) then
 -                start_pos = i
 -                exit
 -            end if
 -            if (i < buffer%gap_start .or. i >= buffer%gap_end) then
 -                if (buffer_get_char_at(buffer, i) == char(10)) then
 -                    current_line = current_line + 1
 -                end if
 -            end if
 -        end do
+-
 -        ! Find end of line
 -        end_pos = start_pos
 -        do i = start_pos, buffer%size
 -            if (buffer_get_char_at(buffer, i) == char(10)) then
 -                end_pos = i
 -                exit
 -            end if
 -            end_pos = i
 -        end do
 -    end subroutine get_line_positions
+-
      function buffer_get_char_at(buffer, pos) result(ch)
          type(buffer_t), intent(in) :: buffer
          integer, intent(in) :: pos
      subroutine save_file(editor, buffer)
          type(editor_state_t), intent(in) :: editor
          type(buffer_t), intent(inout) :: buffer
 -        integer :: ios, temp_unit
 +        integer :: ios
          character(len=256) :: temp_filename, command
 -        character(len=1024) :: error_msg
 -        logical :: file_exists, has_write_permission
 +        logical :: file_exists
          if (.not. allocated(editor%filename)) return
          inquire(file=editor%filename, exist=file_exists)
          ! If save failed, try sudo save
 -        write(temp_filename, '(a,i0)') '/tmp/facsimile_sudo_', getpid()
 +        write(temp_filename, '(a,i0)') '/tmp/facsimile_sudo_', get_process_id()
          ! Save to temporary file
          call buffer_save_file(buffer, temp_filename, ios)
          end if
      end subroutine save_file
 -    function getpid() result(pid)
 +    function get_process_id() result(pid)
          integer :: pid
          interface
              function c_getpid() bind(C, name="getpid")
              end function
          end interface
          pid = c_getpid()
 -    end function getpid
 +    end function get_process_id
      subroutine cycle_quotes(cursor, buffer)
          type(cursor_t), intent(inout) :: cursor
          integer :: colon1, colon2, colon3
          character(len=100) :: event_type
          integer :: ios, line_count
 -        logical :: is_alt_click
          type(cursor_t), allocatable :: new_cursors(:)
          integer :: i, cursor_exists
          ! Variables for mouse drag handling
          at_pos = (cursor_screen_row == screen_row .and. cursor_screen_col == screen_col)
      end function is_cursor_at_screen_pos
 -    subroutine toggle_cursor_at_position(editor, buffer, row, col)
 -        type(editor_state_t), intent(inout) :: editor
 -        type(buffer_t), intent(in) :: buffer
 -        integer, intent(in) :: row, col
 -        integer :: i, cursor_exists
 -        type(cursor_t), allocatable :: new_cursors(:)
+-
 -        ! Check if cursor already exists at this position
 -        cursor_exists = 0
 -        do i = 1, size(editor%cursors)
 -            if (is_cursor_at_screen_pos(editor%cursors(i), editor, row, col)) then
 -                cursor_exists = i
 -                exit
 -            end if
 -        end do
+-
 -        if (cursor_exists > 0) then
 -            ! Remove the cursor
 -            if (size(editor%cursors) > 1) then
 -                allocate(new_cursors(size(editor%cursors) - 1))
 -                do i = 1, cursor_exists - 1
 -                    new_cursors(i) = editor%cursors(i)
 -                end do
 -                do i = cursor_exists + 1, size(editor%cursors)
 -                    new_cursors(i-1) = editor%cursors(i)
 -                end do
 -                deallocate(editor%cursors)
 -                editor%cursors = new_cursors
 -                if (editor%active_cursor >= cursor_exists) then
 -                    editor%active_cursor = max(1, editor%active_cursor - 1)
 -                end if
 -            end if
 -        else
 -            ! Add a new cursor
 -            allocate(new_cursors(size(editor%cursors) + 1))
 -            do i = 1, size(editor%cursors)
 -                new_cursors(i) = editor%cursors(i)
 -            end do
 -            call init_cursor(new_cursors(size(new_cursors)))
 -            ! First move the new cursors to editor
 -            deallocate(editor%cursors)
 -            editor%cursors = new_cursors
 -            editor%active_cursor = size(editor%cursors)
 -            ! Then position the new cursor using its index
 -            call position_cursor_at_screen(editor%active_cursor, &
 -                                          editor, buffer, row, col)
 -        end if
 -    end subroutine toggle_cursor_at_position
+-
 -    subroutine handle_mouse_click(editor, buffer, row, col)
 -        type(editor_state_t), intent(inout) :: editor
 -        type(buffer_t), intent(in) :: buffer
 -        integer, intent(in) :: row, col
 -        integer :: cursor_idx
+-
 -        ! Clear multiple cursors
 -        if (allocated(editor%cursors)) then
 -            if (size(editor%cursors) > 1) then
 -                deallocate(editor%cursors)
 -                allocate(editor%cursors(1))
 -                call init_cursor(editor%cursors(1))
 -                editor%active_cursor = 1
 -            end if
 -        end if
+-
 -        ! Move cursor to click position
 -        cursor_idx = 1
 -        call position_cursor_at_screen(cursor_idx, editor, buffer, row, col)
 -        call update_viewport(editor)
 -    end subroutine handle_mouse_click
+-
      subroutine select_next_match(editor, buffer)
          type(editor_state_t), intent(inout) :: editor
          type(buffer_t), intent(inout) :: buffer
      ! Multiple Cursor Addition Above/Below
      ! ========================================================================
 -    subroutine add_cursor_above(editor, buffer)
 +    subroutine add_cursor_above(editor)
          type(editor_state_t), intent(inout) :: editor
 -        type(buffer_t), intent(in) :: buffer
          type(cursor_t), allocatable :: new_cursors(:)
          type(cursor_t) :: active_cursor
          integer :: i, new_line
      ! Selection Extension Subroutines
      ! ========================================================================
 -    subroutine extend_selection_up(cursor, buffer, line_count)
 +    subroutine extend_selection_up(cursor, buffer)
          type(cursor_t), intent(inout) :: cursor
          type(buffer_t), intent(in) :: buffer
 -        integer, intent(in) :: line_count
          character(len=:), allocatable :: current_line, target_line
          ! Initialize selection if not already started
          if (allocated(line)) deallocate(line)
      end subroutine extend_selection_end
 -    subroutine extend_selection_page_up(cursor, editor, line_count)
 +    subroutine extend_selection_page_up(cursor, editor)
          type(cursor_t), intent(inout) :: cursor
          type(editor_state_t), intent(in) :: editor
 -        integer, intent(in) :: line_count
          integer :: page_size
          ! Initialize selection if not already started
          type(buffer_t), intent(in) :: buffer
          character(len=:), allocatable :: line
          integer :: pos, line_len
 -        logical :: in_word
          ! Initialize selection if not already started
          if (.not. cursor%has_selection) then
          type(buffer_t), intent(in) :: buffer
          character(len=:), allocatable :: line
          integer :: pos, line_count, line_len
 -        logical :: in_word
          ! Initialize selection if not already started
          if (.not. cursor%has_selection) then
      ! Character Transpose Subroutine
      ! ========================================================================
 -    subroutine transpose_characters(cursor, buffer)
 -        type(cursor_t), intent(inout) :: cursor
 -        type(buffer_t), intent(inout) :: buffer
 -        character(len=:), allocatable :: line
 -        character :: temp_char
 -        integer :: pos1, pos2
+-
 -        line = buffer_get_line(buffer, cursor%line)
+-
 -        if (cursor%column > 1 .and. cursor%column <= len(line) + 1) then
 -            if (cursor%column == len(line) + 1) then
 -                ! At end of line, swap last two characters
 -                pos1 = cursor%column - 2
 -                pos2 = cursor%column - 1
 -            else
 -                ! In middle of line, swap character before cursor with character at cursor
 -                pos1 = cursor%column - 1
 -                pos2 = cursor%column
 -            end if
+-
 -            if (pos1 >= 1 .and. pos2 <= len(line)) then
 -                ! Get the two characters
 -                temp_char = line(pos1:pos1)
+-
 -                ! Delete the first character
 -                call delete_range(buffer, cursor%line, pos1, cursor%line, pos1)
+-
 -                ! Insert it after the second position
 -                call insert_char_at(buffer, cursor%line, pos2, temp_char)
+-
 -                ! Move cursor forward if not at end of line
 -                if (cursor%column < len(line) + 1) then
 -                    cursor%column = cursor%column + 1
 -                    cursor%desired_column = cursor%column
 -                end if
+-
 -                buffer%modified = .true.
 -            end if
 -        end if
+-
 -        if (allocated(line)) deallocate(line)
 -    end subroutine transpose_characters
+-
      subroutine join_lines(cursor, buffer)
          type(cursor_t), intent(inout) :: cursor
          type(buffer_t), intent(inout) :: buffer
          type(editor_state_t), intent(inout) :: editor
          type(buffer_t), intent(inout) :: buffer
          character(len=:), allocatable :: selected_path
 -        integer :: status, i
 +        integer :: i
          select case(trim(key_str))
          case('j', 'down')

src/terminal/input_handler_module.f90modified

                              end if
                          case('1', '2', '4', '7', '8')
                              ! ESC ESC [ 1 ; modifier format (Alt+Shift+arrow, etc)
 -                            call handle_alt_modified_key(key_str, ch3)
 +                            call handle_alt_modified_key(key_str)
                          end select
                      end if
                  end if
          end select
      end subroutine handle_alternate_modified_key
 -    subroutine handle_alt_modified_key(key_str, first_char)
 +    subroutine handle_alt_modified_key(key_str)
          character(len=*), intent(out) :: key_str
 -        character, intent(in) :: first_char
          character :: ch, terminator
          character(len=10) :: modifier_seq
          integer :: ios, modifier, char_code, read_count

src/terminal/renderer_module.f90modified

          end if
      end subroutine render_screen
 -    subroutine render_line(buffer, line_num, start_col, width)
 -        type(buffer_t), intent(in) :: buffer
 -        integer, intent(in) :: line_num, start_col, width
 -        character(len=:), allocatable :: line
 -        character(len=:), allocatable :: visible_part
 -        integer :: char_count, end_col
 -        integer :: start_byte, end_byte, display_width
+-
 -        ! Get the line content
 -        line = buffer_get_line(buffer, line_num)
 -        char_count = utf8_char_count(line)
+-
 -        ! Calculate visible portion (start_col is character position)
 -        if (start_col > char_count) then
 -            ! Line is scrolled past its end
 -            visible_part = repeat(' ', width)
 -        else
 -            end_col = min(start_col + width - 1, char_count)
 -            if (end_col >= start_col) then
 -                ! Convert character positions to byte positions
 -                start_byte = utf8_char_to_byte_index(line, start_col)
 -                end_byte = utf8_char_to_byte_index(line, end_col + 1) - 1
+-
 -                if (start_byte > 0 .and. end_byte >= start_byte .and. end_byte <= len(line)) then
 -                    visible_part = line(start_byte:end_byte)
 -                    display_width = utf8_display_width(visible_part)
+-
 -                    ! Pad with spaces if needed
 -                    if (display_width < width) then
 -                        visible_part = visible_part // repeat(' ', width - display_width)
 -                    end if
 -                else
 -                    visible_part = repeat(' ', width)
 -                end if
 -            else
 -                visible_part = repeat(' ', width)
 -            end if
 -        end if
+-
 -        ! Write the visible part
 -        call terminal_write(visible_part)
+-
 -        if (allocated(line)) deallocate(line)
 -        if (allocated(visible_part)) deallocate(visible_part)
 -    end subroutine render_line
+-
      subroutine render_line_with_selections(buffer, editor, line_num, start_col, width)
          type(buffer_t), intent(in) :: buffer
          type(editor_state_t), intent(in) :: editor
              editor%tabs(tab_idx)%panes(i)%screen_height = pane_height
              ! Render the pane content
 -            call render_single_pane(buffer, editor, i, pane_col, pane_row, pane_width, pane_height)
 +            call render_single_pane(editor, i, pane_col, pane_row, pane_width, pane_height)
              ! Draw vertical separator between panes
              if (i < n_panes) then
              editor%tabs(tab_idx)%panes(i)%screen_height = pane_height
              ! Render the pane content
 -            call render_single_pane(buffer, editor, i, pane_col, pane_row, pane_width, pane_height)
 +            call render_single_pane(editor, i, pane_col, pane_row, pane_width, pane_height)
              ! Draw vertical separator between panes
              if (i < n_panes) then
          end do
      end subroutine render_all_panes
 -    subroutine render_single_pane(buffer, editor, pane_idx, col, row, width, height)
 +    subroutine render_single_pane(editor, pane_idx, col, row, width, height)
          use editor_state_module, only: pane_t
 -        type(buffer_t), intent(in) :: buffer
          type(editor_state_t), intent(in) :: editor
          integer, intent(in) :: pane_idx, col, row, width, height
          type(pane_t) :: pane

src/ui/help_display_module.f90modified

          end do
      end subroutine display_help_viewport
 -    subroutine display_section(row, max_rows, title, items)
 -        integer, intent(inout) :: row
 -        integer, intent(in) :: max_rows
 -        character(len=*), intent(in) :: title
 -        character(len=*), dimension(:), intent(in) :: items
 -        integer :: i
+-
 -        if (row >= max_rows - 2) return
+-
 -        ! Section title
 -        call terminal_move_cursor(row, 1)
 -        call terminal_write(title)
 -        row = row + 1
+-
 -        ! Section items
 -        do i = 1, size(items)
 -            if (row >= max_rows - 2) return
 -            call terminal_move_cursor(row, 3)
 -            call terminal_write(items(i))
 -            row = row + 1
 -        end do
+-
 -        row = row + 1  ! Extra space between sections
 -    end subroutine display_section
+-
      subroutine show_tags_modal(editor, tags, n_tags)
          type(editor_state_t), intent(in) :: editor
          character(len=256), intent(in) :: tags(:)

src/workspace/file_tree_module.f90modified

          integer, intent(out) :: n_files
          integer :: iostat, unit_num, status_code
          character(len=1024) :: line, cmd
 -        character(len=512) :: file_path
 +        character(len=1024) :: file_path
          integer :: max_files
          type(file_entry_t), allocatable :: temp_files(:)
          if (.not. associated(node)) return
 -        write(unit, '(A,A,A,L,A,L)') trim(prefix), trim(node%name), &
 +        write(unit, '(A,A,A,L1,A,L1)') trim(prefix), trim(node%name), &
              ' is_file=', node%is_file, ' has_next_sib=', associated(node%next_sibling)
          child => node%first_child