`24073c1`

Revert SLSTransactionSetWindowBoundsPath donut: segfaults on Tahoe

The guessed FFI signature for SLSTransactionSetWindowBoundsPath does
not match Tahoe's actual ABI — calling it crashes ers with SIGSEGV
during overlay creation, which leaves tarmac with no border renderer.
Removing the donut path; capture-exclusion now relies solely on the
SharingState/ClientPerceivedType advisories. Screenshots will once
again include the overlay border, but borders themselves come back.

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 2 weeks ago

SHA: 24073c1c3a779d6a419a8800f9bb8d6b55cd7f42
Parents: 0597a14
Tree: a1dddd4

2 changed files

Status	File	+	-
M	`src/main.rs`	0	24
M	`src/skylight.rs`	0	12

src/main.rsmodified

          SLSSetWindowSharingState(cid, wid, 0);
          SLSSetWindowClientPerceivedType(cid, wid, 2);
 -        // Replace the window's bounds region with a donut path: outer
 -        // rect plus an inner subpath for the interior. SLS interprets
 -        // the path with even-odd winding so the interior is *not* part
 -        // of the window — the screenshot picker hit-tests through to
 -        // the underlying app window. Done via SLSTransaction because
 -        // SLSTransactionSetWindowBoundsPath is the only path-based bounds
 -        // API exported on Tahoe; CGS region union APIs aren't linkable.
 -        let interior = CGRect::new(bw, bw, (ow - 2.0 * bw).max(0.0), (oh - 2.0 * bw).max(0.0));
 -        if interior.size.width > 0.0 && interior.size.height > 0.0 {
 -            let path = CGPathCreateMutable();
 -            if !path.is_null() {
 -                let outer = CGRect::new(0.0, 0.0, ow, oh);
 -                CGPathAddRect(path, ptr::null(), outer);
 -                CGPathAddRect(path, ptr::null(), interior);
 -                let txn = SLSTransactionCreate(cid);
 -                if !txn.is_null() {
 -                    SLSTransactionSetWindowBoundsPath(txn, cid, wid, path as CGPathRef);
 -                    SLSTransactionCommit(txn, 1);
 -                    CFRelease(txn);
 -                }
 -                CGPathRelease(path as CGPathRef);
 -            }
 -        }
+-
          Some((cid, wid, bounds, scale))
+     }
+ }

src/skylight.rsmodified

          y_offset: f32,
          shape: CFTypeRef,
      ) -> CGError;
 -    /// Sets a window's actual bounds region (what the window-server
 -    /// considers part of the window for hit-testing, capture, and
 -    /// rendering) using a CGPath instead of a CGS region. Lets us
 -    /// install a donut-shaped region without needing a multi-rect
 -    /// region constructor — none of which exist in linkable form on
 -    /// Tahoe except `CGSNewRegionWithRect` (single rect).
 -    pub fn SLSTransactionSetWindowBoundsPath(
 -        transaction: CFTypeRef,
 -        cid: CGSConnectionID,
 -        wid: u32,
 -        path: CGPathRef,
 -    ) -> CGError;
      // Flicker suppression
      pub fn SLSDisableUpdate(cid: CGSConnectionID) -> CGError;