`7c6e94f`

Revert tag-based exclusion; restore EventShape click-through

Setting any SLS window tags (bit 1 or bits 1|9) post-creation breaks
border visibility on Tahoe in our recreate-overlay-on-move lifecycle:
borders flicker on and disappear during the rapid sync_overlay churn
that tiling produces. JankyBorders works with tags 1|9 because it
creates each border window once and moves it via
SLSTransactionMoveWindowWithGroup; ers releases and recreates the SLS
window on every geometry change, and Tahoe's compositor handles the
tagged-then-released window very differently.

Restoring SLSSetWindowEventShape(empty) + SLSSetWindowEventMask(0) for
click-through; screenshots will again include the overlay until the
lifecycle is refactored to match JankyBorders'.

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 2 weeks ago

SHA: 7c6e94f50639cc5a3964ef8596fc4e7f044cbfc1
Parents: cd9587f
Tree: 64c56c2

2 changed files

Status	File	+	-
M	`src/main.rs`	18	13
M	`src/skylight.rs`	7	0

src/main.rsmodified

          );
          SLSSetWindowResolution(cid, wid, scale);
+-
 -        // Tag bit 1 (kCGSIgnoreForEvents) makes the overlay click/scroll
 -        // through; tag bit 9 hides it from ScreenCaptureKit (cmd+shift+4
 -        // + space, screen recordings, the picker). Mirrors JankyBorders'
 -        // ordering: tags MUST be set before SLWindowContextCreate /
 -        // drawing — setting them post-draw poisons subsequent SLSNewWindow
 -        // calls on the shared connection during stack-cycle recreates.
 -        // tag_size 64 (0x40) is the SLS-documented length.
 -        let set_tags: u64 = (1u64 << 1) | (1u64 << 9);
 -        let clear_tags: u64 = 0;
 -        SLSSetWindowTags(cid, wid, &set_tags, 64);
 -        SLSClearWindowTags(cid, wid, &clear_tags, 64);
+-
          SLSSetWindowOpacity(cid, wid, false);
          SLSSetWindowLevel(cid, wid, 0);
          SLSOrderWindow(cid, wid, 1, target_wid);
          SLSFlushWindowContentRegion(cid, wid, ptr::null());
          CGContextRelease(ctx);
 +        // Click-through. Setting an empty event/hit-test shape passes
 +        // mouse events through to the window beneath. We deliberately
 +        // avoid SLSSetWindowTags(kCGSIgnoreForEvents): even when set
 +        // before drawing on Tahoe, the tag-bit-1 flag breaks overlay
 +        // visibility during the rapid sync_overlay/recreate churn that
 +        // tiling produces. Empty event shape + zero event mask is the
 +        // only combination that gives both click-through AND persistent
 +        // borders on Tahoe.
 +        let empty = CGRect::new(0.0, 0.0, 0.0, 0.0);
 +        let mut empty_region: CFTypeRef = ptr::null();
 +        if CGSNewRegionWithRect(&empty, &mut empty_region) == kCGErrorSuccess
 +            && !empty_region.is_null()
 +        {
 +            SLSSetWindowEventShape(cid, wid, empty_region);
 +            CFRelease(empty_region);
 +        }
 +        SLSSetWindowEventMask(cid, wid, 0);
++
          Some((cid, wid, bounds, scale))
+     }
+ }

src/skylight.rsmodified

      ) -> CGError;
      pub fn SLSSetWindowResolution(cid: CGSConnectionID, wid: u32, res: f64) -> CGError;
      pub fn SLSSetWindowOpacity(cid: CGSConnectionID, wid: u32, is_opaque: bool) -> CGError;
 +    /// Mask of events the SLS window captures. Set to 0 to make the window
 +    /// click-through (mouse events pass to the window beneath).
 +    pub fn SLSSetWindowEventMask(cid: CGSConnectionID, wid: u32, mask: u32) -> CGError;
 +    /// Hit-test/input shape. An empty region passes all mouse events
 +    /// through to the window beneath. Equivalent to NSWindow's
 +    /// `setIgnoresMouseEvents(true)` at the SLS layer.
 +    pub fn SLSSetWindowEventShape(cid: CGSConnectionID, wid: u32, shape: CFTypeRef) -> CGError;
      pub fn SLSSetWindowAlpha(cid: CGSConnectionID, wid: u32, alpha: f32) -> CGError;
      pub fn SLSSetWindowBackgroundBlurRadius(cid: CGSConnectionID, wid: u32, radius: u32)
      -> CGError;