`f34604f`

Switch overlay click-through from SLSSetWindowTags to SLSSetWindowEventShape

The kCGSIgnoreForEvents tag bit poisons the shared SLS connection's
SLSNewWindow path during stack-cycle recreates, dropping border
overlays on the inactive stack windows. An empty event shape achieves
the same click-through without mutating tags.

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 2 weeks ago

SHA: f34604f322977aa876452baff62f3d22dfad9afd
Parents: 0003875
Tree: 47afeef

2 changed files

Status	File	+	-
M	`src/main.rs`	15	6
M	`src/skylight.rs`	9	0

src/main.rsmodified

          SLSFlushWindowContentRegion(cid, wid, ptr::null());
          CGContextRelease(ctx);
 -        // Click-through. Without this the overlay window swallows mouse
 -        // clicks and scroll-wheel/trackpad gestures inside the target
 -        // window's bounds. Bit 1 of the SLS tag word is kCGSIgnoreForEvents.
 -        // Must run AFTER drawing — see CLAUDE.md "Draw before setting tags".
 -        let tags: u64 = 1 << 1;
 -        SLSSetWindowTags(cid, wid, &tags, 64);
 +        // Click-through. Setting an empty event/hit-test shape makes mouse
 +        // events pass through the overlay to the window beneath. We use
 +        // SLSSetWindowEventShape rather than SLSSetWindowTags(kCGSIgnoreForEvents)
 +        // because tag mutation in the event-driven recreate path poisons
 +        // subsequent SLSNewWindow calls on the shared connection.
 +        // SLSSetWindowEventMask alone was insufficient on Tahoe.
 +        let empty = CGRect::new(0.0, 0.0, 0.0, 0.0);
 +        let mut empty_region: CFTypeRef = ptr::null();
 +        if CGSNewRegionWithRect(&empty, &mut empty_region) == kCGErrorSuccess
 +            && !empty_region.is_null()
 +        {
 +            SLSSetWindowEventShape(cid, wid, empty_region);
 +            CFRelease(empty_region);
 +        }
 +        SLSSetWindowEventMask(cid, wid, 0);
          Some((cid, wid, bounds, scale))
+     }

src/skylight.rsmodified

      ) -> CGError;
      pub fn SLSSetWindowResolution(cid: CGSConnectionID, wid: u32, res: f64) -> CGError;
      pub fn SLSSetWindowOpacity(cid: CGSConnectionID, wid: u32, is_opaque: bool) -> CGError;
 +    /// Mask of events the SLS window captures. Set to 0 to make the window
 +    /// click-through (mouse events pass to the window beneath). Used by
 +    /// border overlays so the user can still click/scroll the underlying
 +    /// app window.
 +    pub fn SLSSetWindowEventMask(cid: CGSConnectionID, wid: u32, mask: u32) -> CGError;
 +    /// Hit-test/input shape. An empty region passes all mouse events
 +    /// through to the window beneath. Equivalent to NSWindow's
 +    /// `setIgnoresMouseEvents(true)` at the SLS layer.
 +    pub fn SLSSetWindowEventShape(cid: CGSConnectionID, wid: u32, shape: CFTypeRef) -> CGError;
      pub fn SLSSetWindowAlpha(cid: CGSConnectionID, wid: u32, alpha: f32) -> CGError;
      pub fn SLSSetWindowBackgroundBlurRadius(cid: CGSConnectionID, wid: u32, radius: u32)
      -> CGError;