`d920c3b`

Fix mouse click behavior: pass-through and no spurious warp

- Move button grab/ungrab into set_focus() to ensure clicks reach apps
- Don't warp pointer on _NET_ACTIVE_WINDOW (user is already interacting)

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 4 months ago

SHA: d920c3baffc16bdb2a2796e1a062519f259e221e
Parents: 90232b7
Tree: 1e2cc7b

2 changed files

Status	File	+	-
M	`gar/src/core/mod.rs`	10	0
M	`gar/src/x11/events.rs`	2	6

gar/src/core/mod.rsmodified

      /// If `warp_pointer` is true, the mouse pointer will be moved to the window center.
      /// Use true for keyboard navigation, false for mouse-initiated focus changes.
      pub fn set_focus(&mut self, window: XWindow, warp_pointer: bool) -> Result<()> {
 +        // Re-grab buttons on old focused window (for click-to-focus)
 +        if let Some(old) = self.focused_window {
 +            if old != window {
 +                let _ = self.conn.grab_button(old);
 +            }
 +        }
++
          self.focused_window = Some(window);
          self.current_workspace_mut().focused = Some(window);
 +        // Ungrab buttons on new focused window (allow clicks through)
 +        let _ = self.conn.ungrab_button(window);
++
          // Update focus history - move window to front
          self.focus_history.retain(|&w| w != window);
          self.focus_history.insert(0, window);

gar/src/x11/events.rsmodified


                         self.switch_workspace(ws_idx)?;
                     }
                 }
-                // Focus the window (external activation, warp pointer)
-                if let Some(old) = self.focused_window {
-                    self.conn.grab_button(old)?;
-                }
-                self.set_focus(window, true)?;
-                self.conn.ungrab_button(window)?;
+                // Focus the window (external activation, no warp - user is already interacting)
+                self.set_focus(window, false)?;
                 if self.is_floating(window) {
                     self.raise_window(window)?;
                 }

`@@ -579,12 +579,8 @@` impl WindowManager {
579	579	self.switch_workspace(ws_idx)?;
580	580	}
581	581	}
582		- // Focus the window (external activation, warp pointer)
583		- if let Some(old) = self.focused_window {
584		- self.conn.grab_button(old)?;
585		- }
586		- self.set_focus(window, true)?;
587		- self.conn.ungrab_button(window)?;
	582	+ // Focus the window (external activation, no warp - user is already interacting)
	583	+ self.set_focus(window, false)?;
588	584	if self.is_floating(window) {
589	585	self.raise_window(window)?;
590	586	}