`d93df2d`

fix: skip pointer warp for unmanaged window destroy events

Popup windows (menus, tooltips) from apps like JetBrains IDEs trigger
DestroyNotify without being managed. Previously this caused pointer
warp to focused window center on every popup close, making edge
buttons nearly unusable.

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 3 months ago

SHA: d93df2d5cc6a770a3d9b9785d64aa70e72b959fa
Parents: faa0eff
Tree: 347a68e

1 changed file

Status	File	+	-
M	`gar/src/x11/events.rs`	20	12

gar/src/x11/events.rsmodified

              tracing::info!("Dock window {} destroyed, removing strut", event.window);
+         }
 +        // Check if this window was actually managed before doing layout/focus work
 +        let was_managed = self.windows.contains_key(&event.window);
++
          // Remove from management
          self.unmanage_window(event.window);
 -        // Clear the entire root window to remove any leftover pixels
 -        // This is needed because X11 without a compositor doesn't automatically repaint
 -        self.conn.clear_root_area(0, 0, self.conn.screen_width, self.conn.screen_height)?;
 +        // Only do layout/focus work if the window was actually managed
 +        // Unmanaged windows (like popup menus, tooltips) shouldn't trigger pointer warps
 +        if was_managed {
 +            // Clear the entire root window to remove any leftover pixels
 +            // This is needed because X11 without a compositor doesn't automatically repaint
 +            self.conn.clear_root_area(0, 0, self.conn.screen_width, self.conn.screen_height)?;
 -        // Re-apply layout
 -        self.apply_layout()?;
 +            // Re-apply layout
 +            self.apply_layout()?;
 -        // Focus next window or warp to monitor if none left
 -        if let Some(window) = self.focused_window {
 -            self.set_focus(window, true)?;
 -        } else {
 -            // No windows left, warp to current monitor center
 -            self.warp_to_monitor(self.focused_monitor)?;
 +            // Focus next window or warp to monitor if none left
 +            if let Some(window) = self.focused_window {
 +                self.set_focus(window, true)?;
 +            } else {
 +                // No windows left, warp to current monitor center
 +                self.warp_to_monitor(self.focused_monitor)?;
 +            }
++
 +            self.conn.flush()?;
+         }
 -        self.conn.flush()?;
          Ok(())
+     }