`1881604`

validate request store fields

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 2 months ago

Status	File	+	-
M	`garwarp/src/request_store.rs`	33	1

garwarp/src/request_store.rsmodified

          let (key, value) = token
              .split_once('=')
              .ok_or_else(|| format!("invalid token: {token}"))?;
 -        fields.insert(key, value);
 +        if !matches!(key, "id" | "sender" | "app_id" | "parent" | "state") {
 +            return Err(format!("unknown field: {key}"));
 +        }
 +        if fields.insert(key, value).is_some() {
 +            return Err(format!("duplicate field: {key}"));
 +        }
+     }
      Ok(fields)
+ }
          let _ = fs::remove_file(path);
+     }
 +    #[test]
 +    fn duplicate_fields_fail_to_load() {
 +        let path = unique_temp_file();
 +        fs::write(&path, "id=req-1\tid=req-2\tsender=:1.2\tstate=pending\n")
 +            .expect("test file should be written");
++
 +        let loaded = load_registry(&path, Duration::from_secs(5));
 +        assert!(loaded.is_err());
++
 +        let _ = fs::remove_file(path);
 +    }
++
 +    #[test]
 +    fn unknown_fields_fail_to_load() {
 +        let path = unique_temp_file();
 +        fs::write(
 +            &path,
 +            "id=req-1\tsender=:1.2\tstate=pending\tunexpected=1\n",
 +        )
 +        .expect("test file should be written");
++
 +        let loaded = load_registry(&path, Duration::from_secs(5));
 +        assert!(loaded.is_err());
++
 +        let _ = fs::remove_file(path);
 +    }
++
      #[test]
      fn persist_overwrites_previous_contents() {
          let path = unique_temp_file();