`882a288`

Auto-float windows with AXModal=true regardless of subrole

Lots of app-defined modals (save dialogs, confirmation prompts,
inline preference panels) ship with subrole=AXStandardWindow and
relied on the human reading 'looks modal' to know not to tile them.
Tarmac was tiling them alongside the parent window. Detect AXModal
explicitly, and add AXSystemDialog to the subrole allowlist for the
ones that do declare it correctly.

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 1 week ago

SHA: 882a2889caf01eaa31646b0401b7b6cb3848017d
Parents: e9eabd1
Tree: 8327d80

1 changed file

Status	File	+	-
M	`tarmac/src/core/state.rs`	24	5

tarmac/src/core/state.rsmodified

+             }
+         }
 -        let should_float = rule_float.unwrap_or_else(|| should_auto_float(subrole, width, height));
 +        let should_float = rule_float.unwrap_or_else(|| should_auto_float(subrole, &ax_ref));
          self.registry.add(WindowState {
              id: *id,
+ }
  /// Check if a window should automatically float based on its subrole and size.
 -fn should_auto_float(subrole: &str, _width: f64, _height: f64) -> bool {
 -    matches!(
 +fn should_auto_float(subrole: &str, ax_ref: &AXUIElement) -> bool {
 +    use crate::platform::accessibility::ax_get_bool;
 +    use objc2_core_foundation::CFString;
++
 +    if matches!(
          subrole,
 -        "AXDialog" | "AXSheet" | "AXFloatingWindow" | "AXSystemFloatingWindow"
 -    )
 +        "AXDialog"
 +            | "AXSystemDialog"
 +            | "AXSheet"
 +            | "AXFloatingWindow"
 +            | "AXSystemFloatingWindow"
 +    ) {
 +        return true;
 +    }
++
 +    // Many "modal-feeling" NSWindows ship with subrole=AXStandardWindow but
 +    // mark AXModal=true. Treat those as floats so save/confirm dialogs and
 +    // app-defined modals don't get tiled alongside their parent window.
 +    let modal_attr = CFString::from_static_str("AXModal");
 +    if ax_get_bool(ax_ref, &modal_attr).unwrap_or(false) {
 +        return true;
 +    }
++
 +    false
+ }
  /// Warp the mouse cursor to the center of a rect.