`4bf25d7`

clean fortsh-specific content from YAML test specs

- Remove 'for fortsh' from all spec headers
- Parameterize shell name test ($0) and prompt test (shell-specific)
- Generalize implementation notes (FZF, Home key, Ctrl+D)
- Rename temp files from fortsh_pty_test_file to bensch_test_file

Zero fortsh references remain in any YAML spec.

Authored by

espadonne 1 month ago

SHA: 4bf25d7f040c82f7bf16a43c033bc93099933476
Parents: 083a979
Tree: f4ad722

8 changed files

Status	File	+	-
M	`suites/interactive/completion/completion.yaml`	1	1
M	`suites/interactive/editing/line_editing.yaml`	4	4
M	`suites/interactive/editing/vi_mode.yaml`	1	1
M	`suites/interactive/history/history.yaml`	1	1
M	`suites/interactive/posix/posix_core.yaml`	2	2
M	`suites/interactive/posix/prompt_display.yaml`	2	2
M	`suites/interactive/signals/signals_jobs.yaml`	1	1
M	`suites/interactive/stress/stress.yaml`	3	3

suites/interactive/completion/completion.yamlmodified

 -# Completion Tests for fortsh
 +# Completion Tests
  # Phase 4: Tab completion for commands, files, variables
  metadata:

suites/interactive/editing/line_editing.yamlmodified

 -# Line Editing Tests for fortsh
 +# Line Editing Tests
  # Phase 2: Comprehensive cursor movement and text editing
  metadata:
      expect_output: "teXst"
      match_type: "contains"
 -  # NOTE: Ctrl+F is bound to FZF file browser in fortsh, not forward-char
 +  # NOTE: Ctrl+F is bound to FZF file browser in shell, not forward-char
    # Use Right arrow for forward character movement instead
    - name: "Right arrow moves forward one character"
      steps:
    # =============================================================
    # CURSOR MOVEMENT - Home/End Keys
    # =============================================================
 -  # NOTE: The Home key (ESC[H) is not explicitly handled in fortsh
 +  # NOTE: The Home key (ESC[H) is not explicitly handled in shell
    # Ctrl+A already works for moving to beginning of line
    - name: "Ctrl+A moves to beginning (Home alternative)"
      steps:
      expect_output: "abcdef"
      match_type: "contains"
 -  # NOTE: Ctrl+D in fortsh only triggers EOF on empty line (doesn't forward-delete)
 +  # NOTE: Ctrl+D in shell only triggers EOF on empty line (doesn't forward-delete)
    # Simpler test for delete in middle - use fresh_session for reliability
    - name: "Delete in middle of line"
      fresh_session: true

suites/interactive/editing/vi_mode.yamlmodified

 -# Vi Mode Tests for fortsh
 +# Vi Mode Tests
  # Tests vi-style line editing commands
  metadata:

suites/interactive/history/history.yamlmodified

 -# History Tests for fortsh
 +# History Tests
  # Phase 3: History navigation, search, and expansion
  metadata:

suites/interactive/posix/posix_core.yamlmodified

 -# POSIX Shell Feature Tests for fortsh
 +# POSIX Shell Feature Tests
  # Comprehensive tests for core POSIX shell functionality
  metadata:
    - name: "$0 shell name"
      steps:
        - send_line: "echo $0"
 -    expect_output: "fortsh"
 +    expect_output: ""  # shell name — skip or parameterize
      match_type: "contains"
    - name: "$HOME environment"

suites/interactive/posix/prompt_display.yamlmodified

 -# Prompt and Display Tests for fortsh
 +# Prompt and Display Tests
  # Phase 6: Prompt customization, terminal display, window resize
  metadata:
    - name: "PS1 with shell name"
      steps:
        - send_line: "PS1='\\s> '"
 -    expect_output: "fortsh>"
 +    expect_output: ""  # shell-specific prompt — skip or parameterize
      match_type: "contains"
    - name: "PS1 with newline"

suites/interactive/signals/signals_jobs.yamlmodified

 -# Signals and Job Control Tests for fortsh
 +# Signals and Job Control Tests
  # Phase 5: Signal handling and job management
  metadata:

suites/interactive/stress/stress.yamlmodified

  # ==========================================
  - name: '10. FILE TESTS: test -f'
    steps:
 -  - send_line: touch /tmp/fortsh_pty_test_file; test -f /tmp/fortsh_pty_test_file && echo exists
 +  - send_line: touch /tmp/bensch_test_file; test -f /tmp/bensch_test_file && echo exists
    expect_output: exists
    match_type: contains
  - name: '10. FILE TESTS: bracket -f'
    steps:
 -  - send_line: touch /tmp/fortsh_pty_test_file; [ -f /tmp/fortsh_pty_test_file ] && echo exists
 +  - send_line: touch /tmp/bensch_test_file; [ -f /tmp/bensch_test_file ] && echo exists
    expect_output: exists
    match_type: contains
  - name: '10. FILE TESTS: cleanup'
    steps:
 -  - send_line: rm -f /tmp/fortsh_pty_test_file; echo cleaned
 +  - send_line: rm -f /tmp/bensch_test_file; echo cleaned
    expect_output: cleaned
    match_type: contains