`423b1fa`

Fix compiler warnings and clean up unused code

- Remove unused imports and variables
- Add #[allow(dead_code)] for modules with planned features
- Rename key state constants to UPPER_CASE

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 4 months ago

SHA: 423b1fa7138976047d60a337848ae86f7cdaf44a
Parents: 3a3059d
Tree: f2bf382

16 changed files

Status	File	+	-
M	`hyprkvm-daemon/src/config/mod.rs`	2	1
M	`hyprkvm-daemon/src/hyprland/events.rs`	2	0
M	`hyprkvm-daemon/src/hyprland/ipc.rs`	2	0
M	`hyprkvm-daemon/src/hyprland/layout.rs`	4	4
M	`hyprkvm-daemon/src/hyprland/mod.rs`	2	3
M	`hyprkvm-daemon/src/input/capture.rs`	1	1
M	`hyprkvm-daemon/src/input/emulation.rs`	4	4
M	`hyprkvm-daemon/src/input/mod.rs`	5	3
M	`hyprkvm-daemon/src/main.rs`	1	6
M	`hyprkvm-daemon/src/network/mod.rs`	2	2
M	`hyprkvm-daemon/src/network/peer.rs`	2	2
M	`hyprkvm-daemon/src/network/transport.rs`	3	1
M	`hyprkvm-daemon/src/state/manager.rs`	0	1
M	`hyprkvm-daemon/src/state/mod.rs`	1	2
M	`hyprkvm-daemon/src/transfer/manager.rs`	3	4
M	`hyprkvm-daemon/src/transfer/mod.rs`	1	1

hyprkvm-daemon/src/config/mod.rsmodified

  //! Configuration management for HyprKVM
 -use std::collections::HashMap;
 +#![allow(dead_code)]
++
  use std::net::SocketAddr;
  use std::path::Path;

hyprkvm-daemon/src/hyprland/events.rsmodified

  //!
  //! Listens to Hyprland's event socket for real-time updates.
 +#![allow(dead_code)]
++
  use std::path::PathBuf;
  use tokio::io::{AsyncBufReadExt, BufReader};

hyprkvm-daemon/src/hyprland/ipc.rsmodified

  //!
  //! Communicates with Hyprland via its Unix socket.
 +#![allow(dead_code)]
++
  use std::path::PathBuf;
  use serde::de::DeserializeOwned;

hyprkvm-daemon/src/hyprland/layout.rsmodified

+     }
      // Helper functions to find closest neighbor
 -    fn is_closer_left(&self, current: &MonitorInfo, other: &MonitorInfo, existing: &Option<String>) -> bool {
 +    fn is_closer_left(&self, _current: &MonitorInfo, other: &MonitorInfo, existing: &Option<String>) -> bool {
          let Some(existing_name) = existing else { return true };
          let Some(existing_mon) = self.monitors.get(existing_name) else { return true };
          other.x + other.width as i32 > existing_mon.x + existing_mon.width as i32
+     }
 -    fn is_closer_right(&self, current: &MonitorInfo, other: &MonitorInfo, existing: &Option<String>) -> bool {
 +    fn is_closer_right(&self, _current: &MonitorInfo, other: &MonitorInfo, existing: &Option<String>) -> bool {
          let Some(existing_name) = existing else { return true };
          let Some(existing_mon) = self.monitors.get(existing_name) else { return true };
          other.x < existing_mon.x
+     }
 -    fn is_closer_up(&self, current: &MonitorInfo, other: &MonitorInfo, existing: &Option<String>) -> bool {
 +    fn is_closer_up(&self, _current: &MonitorInfo, other: &MonitorInfo, existing: &Option<String>) -> bool {
          let Some(existing_name) = existing else { return true };
          let Some(existing_mon) = self.monitors.get(existing_name) else { return true };
          other.y + other.height as i32 > existing_mon.y + existing_mon.height as i32
+     }
 -    fn is_closer_down(&self, current: &MonitorInfo, other: &MonitorInfo, existing: &Option<String>) -> bool {
 +    fn is_closer_down(&self, _current: &MonitorInfo, other: &MonitorInfo, existing: &Option<String>) -> bool {
          let Some(existing_name) = existing else { return true };
          let Some(existing_mon) = self.monitors.get(existing_name) else { return true };
          other.y < existing_mon.y

hyprkvm-daemon/src/hyprland/mod.rsmodified

  pub mod ipc;
  pub mod events;
 +#[allow(dead_code)]
  pub mod layout;
 +#[allow(dead_code)]
  pub mod edge;
+-
 -pub use ipc::HyprlandClient;
 -pub use events::HyprlandEventStream;

hyprkvm-daemon/src/input/capture.rsmodified

          (min_x, min_y, max_x, max_y)
+     }
 -    fn draw_barrier(&mut self, barrier_idx: usize, qh: &QueueHandle<Self>) {
 +    fn draw_barrier(&mut self, barrier_idx: usize, _qh: &QueueHandle<Self>) {
          let barrier = &self.barriers[barrier_idx];
          if !barrier.configured {
              return;

hyprkvm-daemon/src/input/emulation.rsmodified

              .as_millis() as u32;
          let wl_state = match state {
 -            KeyState::Pressed => wl_keyboard_key_state::Pressed,
 -            KeyState::Released => wl_keyboard_key_state::Released,
 +            KeyState::Pressed => wl_keyboard_key_state::PRESSED,
 +            KeyState::Released => wl_keyboard_key_state::RELEASED,
          };
          // Note: keycode needs to be offset by 8 for evdev->xkb conversion
  // Key state constants
  mod wl_keyboard_key_state {
 -    pub const Released: u32 = 0;
 -    pub const Pressed: u32 = 1;
 +    pub const RELEASED: u32 = 0;
 +    pub const PRESSED: u32 = 1;
+ }
  /// State for input emulation setup

hyprkvm-daemon/src/input/mod.rsmodified

  //!
  //! Handles input capture (when sending to remote) and injection (when receiving).
 +#![allow(dead_code)]
++
  pub mod capture;
  pub mod emulation;
  pub mod grabber;
 -pub use capture::{EdgeCapture, EdgeCaptureConfig, EdgeCaptureError, EdgeEvent};
 -pub use emulation::{InputEmulator, VirtualKeyboard, VirtualPointer, EmulationError, button_codes};
 -pub use grabber::{InputGrabber, InputGrabberConfig, GrabEvent, GrabberError};
 +pub use capture::{EdgeCapture, EdgeCaptureConfig, EdgeEvent};
 +pub use emulation::InputEmulator;
 +pub use grabber::{InputGrabber, InputGrabberConfig};

hyprkvm-daemon/src/main.rsmodified

          _ => Level::TRACE,
      };
 -    let subscriber = FmtSubscriber::builder()
 +    FmtSubscriber::builder()
          .with_max_level(log_level)
          .with_target(false)
          .init();
      info!("Listening for connections on {}", server.local_addr());
      // Spawn task to accept incoming connections
 -    let peers_clone = peers.clone();
      let machine_name = config.machines.self_name.clone();
      let accept_handle = tokio::spawn(async move {
          loop {
+         }
      });
 -    // Channel for incoming messages from peers
 -    let (peer_msg_tx, mut peer_msg_rx) = tokio::sync::mpsc::channel::<(Direction, Message)>(64);
+-
      // Connect to configured peers
      for neighbor in &config.machines.neighbors {
          let addr = neighbor.address;
          let direction = neighbor.direction;
          let peers_clone = peers.clone();
          let machine_name = config.machines.self_name.clone();
 -        let msg_tx = peer_msg_tx.clone();
          tokio::spawn(async move {
              info!("Connecting to {} at {}...", direction, addr);

hyprkvm-daemon/src/network/mod.rsmodified

  //!
  //! Handles peer-to-peer connections between HyprKVM instances.
 +#[allow(dead_code)]
  pub mod peer;
  pub mod transport;
 -pub use peer::{Peer, PeerError, PeerManager};
 -pub use transport::{connect, FramedConnection, Server, TransportError};
 +pub use transport::{connect, FramedConnection, Server};

hyprkvm-daemon/src/network/peer.rsmodified

  use std::sync::Arc;
  use std::time::Duration;
 -use tokio::sync::{mpsc, RwLock};
 +use tokio::sync::RwLock;
  use tokio::time::timeout;
  use hyprkvm_common::protocol::{
      pub async fn handshake_server(
          mut conn: FramedConnection,
          our_name: &str,
 -        our_capabilities: &[String],
 +        _our_capabilities: &[String],
      ) -> Result<Self, PeerError> {
          // Wait for Hello
          let request = timeout(HANDSHAKE_TIMEOUT, conn.recv())

hyprkvm-daemon/src/network/transport.rsmodified

  //!
  //! Provides basic message framing and transport over TCP.
 +#![allow(dead_code)]
++
  use std::io;
  use std::net::SocketAddr;
  use bytes::{Buf, BufMut, BytesMut};
 -use tokio::io::{AsyncReadExt, AsyncWriteExt, BufReader, BufWriter};
 +use tokio::io::{AsyncReadExt, AsyncWriteExt};
  use tokio::net::{TcpListener, TcpStream};
  use hyprkvm_common::protocol::Message;

hyprkvm-daemon/src/state/manager.rsmodified

  use std::net::SocketAddr;
  use std::sync::atomic::{AtomicBool, Ordering};
 -use std::sync::Arc;
  use tokio::sync::RwLock;

hyprkvm-daemon/src/state/mod.rsmodified

  //!
  //! Maintains the unified state of the daemon.
 +#[allow(dead_code)]
  pub mod manager;
+-
 -pub use manager::{ControlState, EdgeTrigger, NeighborInfo, StateError, StateManager};

hyprkvm-daemon/src/transfer/manager.rsmodified

  //! Transfer manager - orchestrates control handoff between machines
 +#![allow(dead_code)]
++
  use std::sync::atomic::{AtomicU64, Ordering};
 -use std::sync::Arc;
 -use std::time::{Duration, Instant};
 +use std::time::Instant;
  use tokio::sync::{mpsc, RwLock};
      #[error("Channel closed")]
      ChannelClosed,
 -    #[error("Timeout")]
 -    Timeout,
+ }

hyprkvm-daemon/src/transfer/mod.rsmodified

  pub mod manager;
 -pub use manager::{TransferError, TransferEvent, TransferManager, TransferState};
 +pub use manager::{TransferEvent, TransferManager};