`28de433`

Steer blocked HTML link drift

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 2 weeks ago

SHA: 28de433e6abc247ac57d05f93c0291212a5989c1
Parents: c6e1cc1
Tree: ba57c22

2 changed files

Status	File	+	-
M	`src/loader/runtime/tool_batches.py`	64	0
M	`tests/test_tool_batches.py`	50	0

src/loader/runtime/tool_batches.pymodified

                      outcome.event_content,
                      dod=dod,
+                 )
 +                self._queue_blocked_html_declared_target_nudge(
 +                    tool_call,
 +                    outcome.event_content,
 +                )
                  self._queue_blocked_active_repair_nudge(outcome.event_content)
                  self._queue_blocked_active_repair_mutation_nudge(outcome.event_content)
                  self._queue_blocked_completed_artifact_scope_nudge(
              "Do not reopen unrelated reference materials while this concrete repair target is unresolved."
+         )
 +    def _queue_blocked_html_declared_target_nudge(
 +        self,
 +        tool_call: ToolCall,
 +        event_content: str,
 +    ) -> None:
 +        """Steer blocked HTML graph edits back to the root-declared local targets."""
++
 +        if tool_call.name not in {"write", "edit", "patch"}:
 +            return
 +        if "HTML page introduces new local targets outside the current declared artifact set" not in event_content:
 +            return
++
 +        target = str(
 +            tool_call.arguments.get("file_path")
 +            or tool_call.arguments.get("path")
 +            or ""
 +        ).strip()
 +        if not target:
 +            return
++
 +        closest_targets = _extract_blocked_html_target_list(
 +            event_content,
 +            "Closest declared local targets include:",
 +        )
 +        declared_targets = _extract_blocked_html_target_list(
 +            event_content,
 +            "Already-declared local targets include:",
 +        )
++
 +        guidance = (
 +            "That HTML mutation introduced sibling targets outside the current declared local-link set. "
 +            f"Stay on `{target}`."
 +        )
 +        if closest_targets:
 +            guidance += (
 +                " Replace the invented hrefs with the closest declared target(s): "
 +                + ", ".join(f"`{candidate}`" for candidate in closest_targets[:3])
 +                + "."
 +            )
 +        elif declared_targets:
 +            guidance += (
 +                " Keep local links within the declared target set, for example: "
 +                + ", ".join(f"`{candidate}`" for candidate in declared_targets[:3])
 +                + "."
 +            )
 +        guidance += (
 +            " Resend one concrete mutation for that same file now instead of rereading the reference guide."
 +        )
 +        self.context.queue_steering_message(guidance)
++
      def _queue_blocked_invalid_mutation_nudge(
          self,
          tool_call: ToolCall,
      return f"`{tool_name}(...)`"
 +def _extract_blocked_html_target_list(event_content: str, marker: str) -> list[str]:
 +    if marker not in event_content:
 +        return []
 +    tail = event_content.split(marker, 1)[1].strip()
 +    target_text = tail.split(". ", 1)[0].strip()
 +    if not target_text:
 +        return []
 +    return [item.strip() for item in target_text.split(",") if item.strip()]
++
++
  def _resume_suffix_for_target(
      target: Path,
      *,

tests/test_tool_batches.pymodified

      assert "Do not reopen earlier reference materials." in queued[0]
 +def test_tool_batch_runner_blocked_html_declared_target_nudge_uses_closest_declared_target(
 +    temp_dir: Path,
 +) -> None:
 +    async def assess_confidence(
 +        tool_name: str,
 +        tool_args: dict,
 +        context: str,
 +    ) -> ConfidenceAssessment:
 +        raise AssertionError("Confidence scoring should be disabled in this scenario")
++
 +    async def verify_action(
 +        tool_name: str,
 +        tool_args: dict,
 +        result: str,
 +        expected: str = "",
 +    ) -> ActionVerification:
 +        raise AssertionError("Verification should not run in this scenario")
++
 +    context = build_context(
 +        temp_dir=temp_dir,
 +        messages=[],
 +        safeguards=FakeSafeguards(),
 +        assess_confidence=assess_confidence,
 +        verify_action=verify_action,
 +    )
 +    queued: list[str] = []
 +    context.queue_steering_message_callback = queued.append
 +    runner = ToolBatchRunner(context, DefinitionOfDoneStore(temp_dir))
++
 +    runner._queue_blocked_html_declared_target_nudge(
 +        ToolCall(
 +            id="write-ch1",
 +            name="write",
 +            arguments={"file_path": str(temp_dir / "guide" / "chapters" / "01-introduction.html")},
 +        ),
 +        (
 +            "[Blocked - HTML page introduces new local targets outside the current declared artifact set] "
 +            "Suggestion: Keep non-root HTML pages within the root-declared local-link set and avoid "
 +            "introducing new sibling targets that the guide root does not declare, for example fix: 02-setup.html. "
 +            "Already-declared local targets include: chapters/01-introduction.html, chapters/02-installation.html, "
 +            "chapters/03-configuration.html. Closest declared local targets include: chapters/02-installation.html"
 +        ),
 +    )
++
 +    assert queued
 +    assert str(temp_dir / "guide" / "chapters" / "01-introduction.html") in queued[0]
 +    assert "`chapters/02-installation.html`" in queued[0]
 +    assert "same file now" in queued[0]
++
++
  @pytest.mark.asyncio
  async def test_tool_batch_runner_blocked_empty_file_path_nudges_concrete_next_artifact(
      temp_dir: Path,