`3fb23b2`

Keep review todos off reads

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 2 weeks ago

SHA: 3fb23b20f0984397c7e82f7417b6bae4df78dbec
Parents: 7aafd0b
Tree: 66ed7a2

2 changed files

Status	File	+	-
M	`src/loader/runtime/workflow.py`	11	0
M	`tests/test_workflow.py`	56	0

src/loader/runtime/workflow.pymodified

+         )
      ):
          return 0
 +    if (
 +        is_discovery_tool
 +        and _contains_any(text, _ARTIFACT_SET_COMPLETION_HINTS)
 +        and not (
 +            _contains_any(text, _READ_STEP_HINTS)
 +            or _contains_any(text, _SEARCH_STEP_HINTS)
 +            or _contains_any(text, _PARSE_STEP_HINTS)
 +            or _contains_any(text, _VERIFY_STEP_HINTS)
 +        )
 +    ):
 +        return 0
      if basename and basename in text:
          score += 3

tests/test_workflow.pymodified

+     )
 +def test_advance_todos_from_tool_call_does_not_complete_consistency_style_step_from_reference_read() -> None:
 +    dod = create_definition_of_done("Create a multi-file nginx guide.")
 +    sync_todos_to_definition_of_done(
 +        dod,
 +        [
 +            {
 +                "content": "First, examine the existing fortran guide structure to understand the format",
 +                "active_form": "Working on: First, examine the existing fortran guide structure to understand the format",
 +                "status": "pending",
 +            },
 +            {
 +                "content": "Ensure consistency with fortran guide style and structure",
 +                "active_form": "Working on: Ensure consistency with fortran guide style and structure",
 +                "status": "pending",
 +            },
 +        ],
 +    )
++
 +    assert (
 +        advance_todos_from_tool_call(
 +            dod,
 +            ToolCall(
 +                id="read-reference-index",
 +                name="read",
 +                arguments={"file_path": "~/Loader/guides/fortran/index.html"},
 +            ),
 +        )
 +        is False
 +    )
 +    assert (
 +        "First, examine the existing fortran guide structure to understand the format"
 +        in dod.pending_items
 +    )
 +    assert (
 +        "Ensure consistency with fortran guide style and structure"
 +        in dod.pending_items
 +    )
++
 +    assert advance_todos_from_tool_call(
 +        dod,
 +        ToolCall(
 +            id="read-reference-chapter",
 +            name="read",
 +            arguments={"file_path": "~/Loader/guides/fortran/chapters/01-introduction.html"},
 +        ),
 +    )
 +    assert (
 +        "First, examine the existing fortran guide structure to understand the format"
 +        in dod.completed_items
 +    )
 +    assert (
 +        "Ensure consistency with fortran guide style and structure"
 +        in dod.pending_items
 +    )
++
++
  def test_sync_todos_to_definition_of_done_keeps_linking_step_pending_while_artifacts_missing(
      temp_dir: Path,
  ) -> None: