`44ab5d8`

Point HTML growth back to the root

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 1 week ago

SHA: 44ab5d87150bca8a7002c48e3fe51e78f9559534
Parents: 484a89a
Tree: b89190a

4 changed files

Status	File	+	-
M	`src/loader/runtime/safeguard_services.py`	3	1
M	`src/loader/runtime/tool_batches.py`	40	0
M	`tests/test_safeguard_services.py`	1	0
M	`tests/test_tool_batches.py`	53	0

src/loader/runtime/safeguard_services.pymodified

          declared_preview = ", ".join(sorted(declared_targets)[:3])
          if authoritative_root_graph:
 +            root_index = (root / "index.html").resolve(strict=False)
              suggestion = (
                  "Keep new non-root HTML files within the root-declared artifact set and "
 -                f"update the guide root before creating undeclared sibling pages, for example: {current_relative}"
 +                f"update the guide root `{root_index}` before creating undeclared sibling pages, "
 +                f"for example: {current_relative}"
+             )
          else:
              suggestion = (

src/loader/runtime/tool_batches.pymodified

                      outcome.event_content,
                      dod=dod,
+                 )
 +                self._queue_blocked_html_declared_file_creation_nudge(
 +                    tool_call,
 +                    outcome.event_content,
 +                )
                  self._queue_blocked_html_declared_target_nudge(
                      tool_call,
                      outcome.event_content,
+         )
          self.context.queue_steering_message(guidance)
 +    def _queue_blocked_html_declared_file_creation_nudge(
 +        self,
 +        tool_call: ToolCall,
 +        event_content: str,
 +    ) -> None:
 +        """Steer blocked undeclared HTML file creation back through the root guide."""
++
 +        if tool_call.name not in {"write", "edit", "patch"}:
 +            return
 +        if "HTML file creation falls outside the current declared artifact set" not in event_content:
 +            return
++
 +        target = str(
 +            tool_call.arguments.get("file_path")
 +            or tool_call.arguments.get("path")
 +            or ""
 +        ).strip()
 +        if not target:
 +            return
++
 +        target_path = Path(target).expanduser().resolve(strict=False)
 +        root_index = (target_path.parent.parent / "index.html").resolve(strict=False)
 +        relative_target = None
 +        try:
 +            relative_target = target_path.relative_to(root_index.parent).as_posix()
 +        except ValueError:
 +            relative_target = target_path.name
++
 +        guidance = (
 +            "That new HTML file is outside the current root-declared artifact set. "
 +            f"Before creating `{relative_target}`, update `{root_index}` so the guide root "
 +            "explicitly links to that page, then retry the file creation. "
 +            "Stay on the active guide files; do not reopen the earlier reference guide first."
 +        )
 +        self.context.queue_steering_message(guidance)
++
      def _queue_blocked_invalid_mutation_nudge(
          self,
          tool_call: ToolCall,

tests/test_safeguard_services.pymodified

      assert result.valid is False
      assert result.reason == "HTML file creation falls outside the current declared artifact set"
      assert "09-monitoring.html" in result.suggestion
 +    assert str((guide / "index.html").resolve(strict=False)) in result.suggestion
  def test_pre_action_validator_allows_declared_missing_chapter_file_creation(

tests/test_tool_batches.pymodified

      assert "closest declared target(s)" not in queued[0]
 +def test_tool_batch_runner_blocked_html_declared_file_creation_nudge_points_to_root(
 +    temp_dir: Path,
 +) -> None:
 +    async def assess_confidence(
 +        tool_name: str,
 +        tool_args: dict,
 +        context: str,
 +    ) -> ConfidenceAssessment:
 +        raise AssertionError("Confidence scoring should be disabled in this scenario")
++
 +    async def verify_action(
 +        tool_name: str,
 +        tool_args: dict,
 +        result: str,
 +        expected: str = "",
 +    ) -> ActionVerification:
 +        raise AssertionError("Verification should not run in this scenario")
++
 +    context = build_context(
 +        temp_dir=temp_dir,
 +        messages=[],
 +        safeguards=FakeSafeguards(),
 +        assess_confidence=assess_confidence,
 +        verify_action=verify_action,
 +    )
 +    queued: list[str] = []
 +    context.queue_steering_message_callback = queued.append
 +    runner = ToolBatchRunner(context, DefinitionOfDoneStore(temp_dir))
++
 +    target = temp_dir / "guide" / "chapters" / "troubleshooting.html"
 +    runner._queue_blocked_html_declared_file_creation_nudge(
 +        ToolCall(
 +            id="write-troubleshooting",
 +            name="write",
 +            arguments={"file_path": str(target)},
 +        ),
 +        (
 +            "[Blocked - HTML file creation falls outside the current declared artifact set] "
 +            "Suggestion: Keep new non-root HTML files within the root-declared artifact set and "
 +            f"update the guide root `{(temp_dir / 'guide' / 'index.html').resolve(strict=False)}` "
 +            "before creating undeclared sibling pages, for example: chapters/troubleshooting.html. "
 +            "Already-declared local targets include: chapters/advanced-topics.html, "
 +            "chapters/basic-usage.html, chapters/configuration.html"
 +        ),
 +    )
++
 +    assert queued
 +    assert "update" in queued[0].lower()
 +    assert str((temp_dir / "guide" / "index.html").resolve(strict=False)) in queued[0]
 +    assert "`chapters/troubleshooting.html`" in queued[0]
 +    assert "retry the file creation" in queued[0]
++
++
  @pytest.mark.asyncio
  async def test_tool_batch_runner_blocked_empty_file_path_nudges_concrete_next_artifact(
      temp_dir: Path,