`5f3c87e`

Extend first-file retry budget

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 1 week ago

SHA: 5f3c87e0c0df21e514d32180ccaebd5a0ffd3ecb
Parents: 78c5d51
Tree: ed17ee8

2 changed files

Status	File	+	-
M	`src/loader/runtime/repair.py`	21	1
M	`tests/test_repair.py`	58	0

src/loader/runtime/repair.pymodified

              extra_retries = _LATE_STAGE_EMPTY_RETRY_EXTRA
              if self._has_confirmed_substantive_output_file_progress(dod):
                  extra_retries += _MULTI_FILE_OUTPUT_EMPTY_RETRY_EXTRA
 -            elif completed_artifacts > 0:
 +            elif completed_artifacts > 0 or self._has_existing_planned_directory_progress(
 +                dod
 +            ):
                  extra_retries += _FIRST_FILE_EMPTY_RETRY_EXTRA
              return base_max_empty_retries + extra_retries
          return base_max_empty_retries
 +    def _has_existing_planned_directory_progress(
 +        self,
 +        dod: DefinitionOfDone,
 +    ) -> bool:
 +        for target, expect_directory in collect_planned_artifact_targets(
 +            dod,
 +            project_root=self.context.project_root,
 +            max_paths=12,
 +        ):
 +            if not expect_directory:
 +                continue
 +            try:
 +                if target.expanduser().is_dir():
 +                    return True
 +            except OSError:
 +                continue
 +        return False
++
      def _should_compact_empty_retry_message(self, dod: DefinitionOfDone) -> bool:
          completed_artifacts, missing_artifacts = self._planned_artifact_counts(dod)
          if completed_artifacts >= 3:

tests/test_repair.pymodified

+     )
 +def test_empty_response_retry_budget_extends_after_setup_directories_exist(
 +    temp_dir: Path,
 +) -> None:
 +    context = build_context(
 +        temp_dir=temp_dir,
 +        use_react=False,
 +    )
 +    repairer = ResponseRepairer(context)
++
 +    guide_root = temp_dir / "guides" / "nginx"
 +    chapters = guide_root / "chapters"
 +    chapters.mkdir(parents=True)
 +    index_path = guide_root / "index.html"
++
 +    implementation_plan = temp_dir / "implementation.md"
 +    implementation_plan.write_text(
 +        "\n".join(
 +            [
 +                "# Implementation Plan",
 +                "",
 +                "## File Changes",
 +                f"- `{guide_root}/`",
 +                f"- `{index_path}`",
 +                f"- `{chapters}/`",
 +                "",
 +            ]
 +        )
 +    )
++
 +    dod = create_definition_of_done("Create a multi-file nginx guide.")
 +    dod.implementation_plan = str(implementation_plan)
 +    dod.completed_items.extend(
 +        [
 +            "First, examine the existing Fortran guide structure to understand the format and depth",
 +            "Create the new nginx guide directory structure",
 +        ]
 +    )
 +    dod.pending_items.append("Develop the main index.html file for the nginx guide")
++
 +    decision = repairer.handle_empty_response(
 +        task="Create a multi-file nginx guide.",
 +        original_task=None,
 +        empty_retry_count=5,
 +        max_empty_retries=2,
 +        dod=dod,
 +    )
++
 +    assert decision.should_continue is True
 +    assert decision.retry_message is not None
 +    assert "retry 5/6" in decision.retry_message
 +    assert "Next missing planned artifact: `index.html`" in decision.retry_message
 +    assert (
 +        "Resume with this exact next step: continue `Develop the main index.html file for the nginx guide` "
 +        "by creating `index.html`."
 +        in decision.retry_message
 +    )
++
++
  def test_empty_response_retry_budget_extends_further_after_first_output_file_exists(
      temp_dir: Path,
  ) -> None: