`660dc4d`

Filter stale setup todos

Authored by

espadonne 2 weeks ago

SHA: 660dc4d64044ef67a796be6ab3950f492f57d995
Parents: fad3bf8
Tree: 3434a9f

3 changed files

Status	File	+
M	`src/loader/runtime/workflow.py`	45
M	`tests/test_repair.py`	64
M	`tests/test_workflow.py`	43

src/loader/runtime/workflow.pymodified

+     )
      if not planned_targets:
          return pending_items
 +    pending_items = [
 +        item
 +        for item in pending_items
 +        if not _todo_describes_completed_setup_step(
 +            item,
 +            dod=dod,
 +            planned_targets=planned_targets,
 +            project_root=project_root,
 +        )
 +    ]
      if not all_planned_artifacts_exist(dod, project_root=project_root, max_paths=24):
          return pending_items
      return False
 +def _todo_describes_completed_setup_step(
 +    item: str,
 +    *,
 +    dod,
 +    planned_targets: list[tuple[Path, bool]],
 +    project_root: Path,
 +) -> bool:
 +    text = item.strip().lower()
 +    if not text or item in _SPECIAL_TODO_ITEMS:
 +        return False
 +    if not _contains_any(text, _CREATION_STEP_HINTS):
 +        return False
 +    if not _contains_any(text, _BROAD_SETUP_HINTS):
 +        return False
++
 +    planned_directories = [
 +        target
 +        for target, expect_directory in planned_targets
 +        if expect_directory
 +    ]
 +    if not planned_directories:
 +        return False
 +    if any(
 +        not planned_artifact_target_satisfied(
 +            dod=dod,
 +            target=directory,
 +            expect_directory=True,
 +            project_root=project_root,
 +        )
 +        for directory in planned_directories
 +    ):
 +        return False
 +    return True
++
++
  def _reopen_aggregate_completion_steps_for_missing_artifacts(
      dod,
      *,

tests/test_repair.pymodified

+     )
 +def test_empty_response_retry_ignores_stale_setup_todo_after_files_created(
 +    temp_dir: Path,
 +) -> None:
 +    context = build_context(
 +        temp_dir=temp_dir,
 +        use_react=False,
 +    )
 +    repairer = ResponseRepairer(context)
++
 +    guide_root = temp_dir / "guides" / "nginx"
 +    chapters = guide_root / "chapters"
 +    chapters.mkdir(parents=True)
 +    index_path = guide_root / "index.html"
 +    chapter_one = chapters / "01-introduction.html"
 +    index_path.write_text("<html></html>\n")
 +    chapter_one.write_text("<html></html>\n")
++
 +    implementation_plan = temp_dir / "implementation.md"
 +    implementation_plan.write_text(
 +        "\n".join(
 +            [
 +                "# Implementation Plan",
 +                "",
 +                "## File Changes",
 +                f"- `{guide_root}/`",
 +                f"- `{chapters}/`",
 +                f"- `{index_path}`",
 +                f"- `{chapter_one}`",
 +                f"- `{chapters / '02-installation.html'}`",
 +                "",
 +            ]
 +        )
 +    )
++
 +    dod = create_definition_of_done("Create a multi-file nginx guide.")
 +    dod.implementation_plan = str(implementation_plan)
 +    dod.touched_files.extend([str(index_path), str(chapter_one)])
 +    dod.completed_items.extend(
 +        [
 +            "Develop the main index.html file for the nginx guide",
 +            "Create first chapter file (01-introduction.html)",
 +        ]
 +    )
 +    dod.pending_items.extend(
 +        [
 +            "Create the nginx directory structure",
 +            "Create second chapter file (02-installation.html)",
 +        ]
 +    )
++
 +    decision = repairer.handle_empty_response(
 +        task="Create a multi-file nginx guide.",
 +        original_task=None,
 +        empty_retry_count=1,
 +        max_empty_retries=2,
 +        dod=dod,
 +    )
++
 +    assert decision.should_continue is True
 +    assert decision.retry_message is not None
 +    assert "Create the nginx directory structure" not in decision.retry_message
 +    assert "02-installation.html" in decision.retry_message
++
++
  def test_empty_response_retry_fails_after_extended_late_stage_budget_is_exhausted(
      temp_dir: Path,
  ) -> None:

tests/test_workflow.pymodified

      assert not any("Fortran guide structure" in item for item in pending)
 +def test_effective_pending_todo_items_filters_completed_setup_before_build_finishes(
 +    temp_dir: Path,
 +) -> None:
 +    guide_root = temp_dir / "guides" / "nginx"
 +    chapters = guide_root / "chapters"
 +    chapters.mkdir(parents=True)
 +    index_path = guide_root / "index.html"
 +    chapter_one = chapters / "01-introduction.html"
 +    index_path.write_text("<html></html>\n")
 +    chapter_one.write_text("<h1>One</h1>\n")
++
 +    implementation_plan = temp_dir / "implementation.md"
 +    implementation_plan.write_text(
 +        "\n".join(
 +            [
 +                "# Implementation Plan",
 +                "",
 +                "## File Changes",
 +                f"- `{guide_root}/`",
 +                f"- `{chapters}/`",
 +                f"- `{index_path}`",
 +                f"- `{chapter_one}`",
 +                f"- `{chapters / '02-installation.html'}`",
 +                "",
 +            ]
 +        )
 +    )
++
 +    dod = create_definition_of_done("Create a multi-file nginx guide.")
 +    dod.implementation_plan = str(implementation_plan)
 +    dod.pending_items = [
 +        "Create the nginx directory structure",
 +        "Create each chapter file with appropriate content",
 +        "Complete the requested work",
 +    ]
++
 +    pending = effective_pending_todo_items(dod, project_root=temp_dir)
++
 +    assert "Create the nginx directory structure" not in pending
 +    assert "Create each chapter file with appropriate content" in pending
 +    assert "Complete the requested work" in pending
++
++
  def test_effective_pending_todo_items_filters_stale_creation_steps_after_artifacts_exist(
      temp_dir: Path,
  ) -> None: