`7466f7b`

fix: use skip_confirmation flag for re-execution after confirmation (match main tool loop)

Authored by

espadonne 4 months ago

SHA: 7466f7b823ce3f7748da1df24aa843d6263120a8
Parents: 2b80190
Tree: d0b5e5e

1 changed file

Status	File	+	-
M	`src/loader/agent/loop.py`	25	4

src/loader/agent/loop.pymodified

                          result_text = result.output
                          is_error = result.is_error
                      except ConfirmationRequired as e:
 +                        # Emit confirmation event
 +                        await emit(AgentEvent(
 +                            type="confirmation",
 +                            tool_name=e.tool_name,
 +                            confirm_message=e.message,
 +                            confirm_details=e.details,
 +                        ))
                          if on_confirmation:
                              confirmed = await on_confirmation(tc.name, e.message, e.details)
                              if confirmed:
 -                                result = await self.registry.execute(tc.name, **tc.arguments, confirmed=True)
 -                                result_text = result.output
 -                                is_error = result.is_error
 +                                # Re-execute with skip_confirmation
 +                                old_skip = self.registry.skip_confirmation
 +                                self.registry.skip_confirmation = True
 +                                try:
 +                                    result = await self.registry.execute(tc.name, **tc.arguments)
 +                                    result_text = result.output
 +                                    is_error = result.is_error
 +                                finally:
 +                                    self.registry.skip_confirmation = old_skip
                              else:
                                  result_text = "Tool execution cancelled by user."
                          else:
 -                            result_text = f"Tool requires confirmation: {e.message}"
 +                            # No callback - auto-confirm for extracted tool calls
 +                            old_skip = self.registry.skip_confirmation
 +                            self.registry.skip_confirmation = True
 +                            try:
 +                                result = await self.registry.execute(tc.name, **tc.arguments)
 +                                result_text = result.output
 +                                is_error = result.is_error
 +                            finally:
 +                                self.registry.skip_confirmation = old_skip
                      except Exception as e:
                          result_text = f"Error: {e}"
                          is_error = True