`9097b6f`

Nudge active quality repairs

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 1 week ago

SHA: 9097b6f61693c22a7d6e059da76ade978d7c743f
Parents: 8f1b6b4
Tree: bfe79a7

2 changed files

Status	File	+	-
M	`src/loader/runtime/turn_completion.py`	56	0
M	`tests/test_turn_completion.py`	82	0

src/loader/runtime/turn_completion.pymodified

  from dataclasses import dataclass
  from enum import StrEnum
  from pathlib import Path
 +from typing import cast
  from ..llm.base import Message, Role
  from .completion_policy import CompletionPolicy
      completion_timeline_kind,
+ )
  from .repair import ResponseRepairer
 +from .repair_focus import extract_active_repair_context
  from .rollback import RollbackPlan
  from .verification_observations import VerificationObservation
  from .workflow import (
      if not _looks_like_progress_intent(content):
          return None
 +    quality_repair = _build_html_quality_repair_continuation(messages)
 +    if quality_repair is not None:
 +        return quality_repair
++
      missing_artifact = _next_missing_planned_artifact(
          dod,
          project_root=project_root,
      return None
 +def _build_html_quality_repair_continuation(
 +    messages: list[object],
 +) -> InProgressContinuation | None:
 +    repair = extract_active_repair_context(cast(list[Message], messages))
 +    if repair is None:
 +        return None
 +    if not any(_repair_line_is_html_quality(line) for line in repair.repair_lines):
 +        return None
++
 +    target_text = repair.artifact_path or (
 +        repair.allowed_paths[0] if repair.allowed_paths else ""
 +    )
 +    if not target_text:
 +        return None
++
 +    issue_line = next(
 +        (
 +            line[2:] if line.startswith("- ") else line
 +            for line in repair.repair_lines
 +            if target_text in line and _repair_line_is_html_quality(line)
 +        ),
 +        "",
 +    )
 +    issue_sentence = f" Current verifier issue: {issue_line}" if issue_line else ""
 +    prompt = (
 +        "[CONTINUE QUALITY REPAIR]\n"
 +        "You just described a content-quality repair, but did not execute it. "
 +        f"Emit one concrete `patch`, `edit`, or `write` tool call for `{target_text}` now."
 +        f"{issue_sentence} "
 +        "Prefer a bounded append or body-section replacement before the existing "
 +        "back link, footer, or closing body. Do not rewrite the whole file from "
 +        "memory, do not reopen unrelated reference files, and do not summarize."
 +    )
 +    return InProgressContinuation(prompt=prompt, target=None)
++
++
  def _looks_like_progress_intent(content: str) -> bool:
      text = content.lower().strip()
      if not text or "?" in text:
      return any(marker in text for marker in _PROGRESS_INTENT_HINTS)
 +def _repair_line_is_html_quality(line: str) -> bool:
 +    lowered = line.lower()
 +    return any(
 +        phrase in lowered
 +        for phrase in (
 +            "thin content",
 +            "insufficient structured content",
 +            "content-quality",
 +            "quality target",
 +            "html guide content quality",
 +        )
 +    )
++
++
  def _next_missing_planned_artifact(
      dod: DefinitionOfDone,
      *,

tests/test_turn_completion.pymodified

+     )
 +@pytest.mark.asyncio
 +async def test_turn_completion_uses_quality_repair_prompt_for_rewrite_narration(
 +    temp_dir: Path,
 +) -> None:
 +    backend = ScriptedBackend()
 +    config = non_streaming_config()
 +    config.reasoning.completion_check = False
 +    agent = Agent(
 +        backend=backend,
 +        config=config,
 +        project_root=temp_dir,
 +    )
 +    runtime = ConversationRuntime(agent)
 +    events = []
++
 +    async def capture(event) -> None:
 +        events.append(event)
++
 +    prepared = await runtime.turn_preparation.prepare(
 +        task="Create an equally thorough HTML guide.",
 +        emit=capture,
 +        requested_mode="execute",
 +        original_task=None,
 +        on_user_question=None,
 +    )
 +    await runtime.phase_tracker.enter(
 +        TurnPhase.ASSISTANT,
 +        capture,
 +        detail="Requesting assistant response",
 +        reason_code="request_assistant_response",
 +    )
++
 +    chapter = temp_dir / "guides" / "nginx" / "chapters" / "01-introduction.html"
 +    chapter.parent.mkdir(parents=True)
 +    chapter.write_text("<html><body><h1>Intro</h1></body></html>\n")
 +    prepared.definition_of_done.touched_files.append(str(chapter))
 +    prepared.definition_of_done.mutating_actions.append("write")
 +    agent.session.append(
 +        Message(
 +            role=Role.USER,
 +            content=(
 +                "Repair focus:\n"
 +                f"- Improve `{chapter}`: insufficient structured content "
 +                "(12 blocks, expected at least 18).\n"
 +                f"- Immediate next step: edit `{chapter}` with a substantial "
 +                "expansion or replacement that satisfies its listed quality issue.\n"
 +            ),
 +        )
 +    )
++
 +    content = (
 +        "Let me try a different approach by rewriting the entire file with more "
 +        "comprehensive content:"
 +    )
 +    decision = await runtime.turn_completion.handle_text_response(
 +        content=content,
 +        response_content=content,
 +        task=prepared.task,
 +        effective_task=prepared.effective_task,
 +        iterations=1,
 +        max_iterations=agent.config.max_iterations,
 +        actions_taken=[],
 +        continuation_count=0,
 +        dod=prepared.definition_of_done,
 +        emit=capture,
 +        summary=prepared.summary,
 +        executor=prepared.executor,
 +        rollback_plan=prepared.rollback_plan,
 +    )
++
 +    assert decision.action == TurnCompletionAction.CONTINUE
 +    assert prepared.summary.completion_decision_code == "in_progress_transition_continue"
 +    assert agent.session.messages[-1].role.value == "user"
 +    assert agent.session.messages[-1].content.startswith("[CONTINUE QUALITY REPAIR]")
 +    assert str(chapter.resolve(strict=False)) in agent.session.messages[-1].content
 +    assert (
 +        "one concrete `patch`, `edit`, or `write` tool call"
 +        in agent.session.messages[-1].content
 +    )
 +    assert "Do not rewrite the whole file from memory" in agent.session.messages[-1].content
++
++
  @pytest.mark.asyncio
  async def test_turn_completion_allows_first_progress_narration_before_any_output_exists(
      temp_dir: Path,