Keep content study pending
- SHA
a41b947b77c359a147b02b36864c1542dd988328- Parents
-
2e86586 - Tree
1c0257c
a41b947
a41b947b77c359a147b02b36864c1542dd9883282e86586
1c0257c| Status | File | + | - |
|---|---|---|---|
| M |
src/loader/runtime/workflow.py
|
1 | 16 |
| M |
tests/test_workflow.py
|
12 | 9 |
src/loader/runtime/workflow.pymodified@@ -194,17 +194,6 @@ _CONTENT_EVIDENCE_HINTS = ( | ||
| 194 | 194 | "thorough", |
| 195 | 195 | "thoroughness", |
| 196 | 196 | ) |
| 197 | -_DEEP_CONTENT_EVIDENCE_HINTS = ( | |
| 198 | - "organization", | |
| 199 | - "cadence", | |
| 200 | - "depth", | |
| 201 | - "writing style", | |
| 202 | - "thorough", | |
| 203 | - "thoroughness", | |
| 204 | - "same structure", | |
| 205 | - "same style", | |
| 206 | - "same pattern", | |
| 207 | -) | |
| 208 | 197 | _BROAD_SETUP_HINTS = ( |
| 209 | 198 | "directory structure", |
| 210 | 199 | "directories", |
@@ -1293,7 +1282,7 @@ def _todo_progress_score(item: str, tool_call: ToolCall) -> int: | ||
| 1293 | 1282 | score += 1 |
| 1294 | 1283 | |
| 1295 | 1284 | if name == "read": |
| 1296 | - if _todo_requires_deep_content_evidence(text) and _is_summary_artifact_name( | |
| 1285 | + if _todo_requires_content_level_evidence(text) and _is_summary_artifact_name( | |
| 1297 | 1286 | basename |
| 1298 | 1287 | ): |
| 1299 | 1288 | return 0 |
@@ -1350,10 +1339,6 @@ def _todo_requires_content_level_evidence(text: str) -> bool: | ||
| 1350 | 1339 | return _contains_any(text, _CONTENT_EVIDENCE_HINTS) |
| 1351 | 1340 | |
| 1352 | 1341 | |
| 1353 | -def _todo_requires_deep_content_evidence(text: str) -> bool: | |
| 1354 | - return _contains_any(text, _DEEP_CONTENT_EVIDENCE_HINTS) | |
| 1355 | - | |
| 1356 | - | |
| 1357 | 1342 | def _is_summary_artifact_name(name: str) -> bool: |
| 1358 | 1343 | normalized = name.lower() |
| 1359 | 1344 | return normalized in { |
tests/test_workflow.pymodified@@ -974,7 +974,7 @@ def test_advance_todos_from_tool_call_tracks_bash_directory_creation_progress() | ||
| 974 | 974 | assert "Create index.html for nginx guide" in dod.pending_items |
| 975 | 975 | |
| 976 | 976 | |
| 977 | -def test_advance_todos_from_tool_call_does_not_complete_develop_step_from_reference_read() -> None: | |
| 977 | +def test_advance_todos_from_tool_call_does_not_complete_content_study_from_root_index_read() -> None: | |
| 978 | 978 | dod = create_definition_of_done("Create a multi-file nginx guide.") |
| 979 | 979 | sync_todos_to_definition_of_done( |
| 980 | 980 | dod, |
@@ -992,17 +992,20 @@ def test_advance_todos_from_tool_call_does_not_complete_develop_step_from_refere | ||
| 992 | 992 | ], |
| 993 | 993 | ) |
| 994 | 994 | |
| 995 | - assert advance_todos_from_tool_call( | |
| 996 | - dod, | |
| 997 | - ToolCall( | |
| 998 | - id="read-reference-index", | |
| 999 | - name="read", | |
| 1000 | - arguments={"file_path": "~/Loader/guides/fortran/index.html"}, | |
| 1001 | - ), | |
| 995 | + assert ( | |
| 996 | + advance_todos_from_tool_call( | |
| 997 | + dod, | |
| 998 | + ToolCall( | |
| 999 | + id="read-reference-index", | |
| 1000 | + name="read", | |
| 1001 | + arguments={"file_path": "~/Loader/guides/fortran/index.html"}, | |
| 1002 | + ), | |
| 1003 | + ) | |
| 1004 | + is False | |
| 1002 | 1005 | ) |
| 1003 | 1006 | assert ( |
| 1004 | 1007 | "First, examine the existing fortran guide structure and content" |
| 1005 | - in dod.completed_items | |
| 1008 | + in dod.pending_items | |
| 1006 | 1009 | ) |
| 1007 | 1010 | assert "Develop the main index.html file for the nginx guide" in dod.pending_items |
| 1008 | 1011 | |