`a6df5b8`

Strengthen repeated HTML write retries

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 1 week ago

SHA: a6df5b89cf530e0875e611f9b276a367d9efd423
Parents: 6d1d55c
Tree: b4d9e2d

2 changed files

Status	File	+	-
M	`src/loader/runtime/repair.py`	36	0
M	`tests/test_repair.py`	60	0

src/loader/runtime/repair.pymodified

+         )
          if html_starter_line:
              lines.append(html_starter_line)
 +        html_payload_line = self._known_minimal_html_payload_line(
 +            concrete_target,
 +            outline_label=outline_label,
 +            retry_number=retry_number,
 +        )
 +        if html_payload_line:
 +            lines.append(html_payload_line)
          if (
              not compact_retry
              and _should_encourage_initial_version(
+         )
          if html_starter_line:
              lines.append(html_starter_line)
 +        html_payload_line = self._known_minimal_html_payload_line(
 +            target,
 +            outline_label=outline_label,
 +            retry_number=retry_number,
 +        )
 +        if html_payload_line:
 +            lines.append(html_payload_line)
      def _infer_pending_item_output_target(
          self,
              "sections with short body text, and a back link to `../index.html`."
+         )
 +    def _known_minimal_html_payload_line(
 +        self,
 +        target: Path,
 +        *,
 +        outline_label: str | None,
 +        retry_number: int,
 +    ) -> str | None:
 +        if retry_number < 5:
 +            return None
 +        if target.suffix.lower() not in {".html", ".htm"}:
 +            return None
++
 +        label = outline_label.strip() if outline_label and outline_label.strip() else target.stem
 +        return (
 +            "If blanking continues, use this minimal starter payload shape inside the `write` call now: "
 +            f"`<!DOCTYPE html><html lang=\"en\"><head><meta charset=\"UTF-8\"><meta name=\"viewport\" "
 +            f"content=\"width=device-width, initial-scale=1.0\"><title>{label}</title></head><body>"
 +            f"<div class=\"container\"><h1>{label}</h1><p>...</p><h2>Overview</h2><p>...</p>"
 +            f"<h2>Key Steps</h2><p>...</p><p><a href=\"../index.html\">← Back to Main Guide Index</a></p>"
 +            "</div></body></html>` and refine it later."
 +        )
++
      def _best_known_root_html_scaffold(self, target: Path) -> Path | None:
          normalized_target = target.expanduser().resolve(strict=False)
          if normalized_target.suffix.lower() not in {".html", ".htm"}:

tests/test_repair.pymodified

      assert "Write a compact but real initial version of this file now" not in decision.retry_message
 +def test_repeated_first_substantive_retry_includes_minimal_payload_shape(
 +    temp_dir: Path,
 +) -> None:
 +    context = build_context(
 +        temp_dir=temp_dir,
 +        use_react=False,
 +    )
 +    repairer = ResponseRepairer(context)
++
 +    guide_root = temp_dir / "guides" / "nginx"
 +    chapters = guide_root / "chapters"
 +    chapters.mkdir(parents=True)
 +    index_path = guide_root / "index.html"
 +    index_path.write_text(
 +        "\n".join(
 +            [
 +                "<html>",
 +                '<a href="chapters/01-introduction.html">Chapter 1: Introduction to Nginx</a>',
 +                "</html>",
 +            ]
 +        )
 +        + "\n"
 +    )
++
 +    implementation_plan = temp_dir / "implementation.md"
 +    implementation_plan.write_text(
 +        "\n".join(
 +            [
 +                "# Implementation Plan",
 +                "",
 +                "## File Changes",
 +                f"- `{guide_root}/`",
 +                f"- `{chapters}/`",
 +                f"- `{index_path}`",
 +                "",
 +            ]
 +        )
 +    )
++
 +    dod = create_definition_of_done("Create a multi-file nginx guide.")
 +    dod.implementation_plan = str(implementation_plan)
 +    dod.touched_files.append(str(index_path))
 +    dod.completed_items.append("Develop the main index.html file with proper structure")
 +    dod.pending_items.append("Create chapter files following the established pattern")
++
 +    decision = repairer.handle_empty_response(
 +        task="Create a multi-file nginx guide.",
 +        original_task=None,
 +        empty_retry_count=5,
 +        max_empty_retries=6,
 +        dod=dod,
 +    )
++
 +    assert decision.should_continue is True
 +    assert decision.retry_message is not None
 +    assert "If blanking continues, use this minimal starter payload shape" in decision.retry_message
 +    assert "<title>Chapter 1: Introduction to Nginx</title>" in decision.retry_message
 +    assert "../index.html" in decision.retry_message
++
++
  def test_first_substantive_retry_activates_on_first_empty_turn(
      temp_dir: Path,
  ) -> None: