`aa8600f`

Extend concrete retry budget

Authored by

espadonne 2 weeks ago

SHA: aa8600f4a1d13f21ccfee69808bd22b85e019cc7
Parents: 1e0f091
Tree: f230948

2 changed files

Status	File	+	-
M	`src/loader/runtime/repair.py`	5	3
M	`tests/test_repair.py`	46	0

src/loader/runtime/repair.pymodified

          if dod is None:
              return base_max_empty_retries
          completed_artifacts, missing_artifacts = self._planned_artifact_counts(dod)
 -        if completed_artifacts < 3 or missing_artifacts == 0:
 -            return base_max_empty_retries
 -        return base_max_empty_retries + _LATE_STAGE_EMPTY_RETRY_EXTRA
 +        if completed_artifacts >= 3 and missing_artifacts > 0:
 +            return base_max_empty_retries + _LATE_STAGE_EMPTY_RETRY_EXTRA
 +        if self._has_concrete_next_output_step(dod):
 +            return base_max_empty_retries + _LATE_STAGE_EMPTY_RETRY_EXTRA
 +        return base_max_empty_retries
      def _should_compact_empty_retry_message(self, dod: DefinitionOfDone) -> bool:
          completed_artifacts, missing_artifacts = self._planned_artifact_counts(dod)

tests/test_repair.pymodified

      assert "Follow the same one-file-at-a-time mutation pattern" in decision.retry_message
 +def test_empty_response_retry_budget_extends_when_concrete_next_output_is_known(
 +    temp_dir: Path,
 +) -> None:
 +    context = build_context(
 +        temp_dir=temp_dir,
 +        use_react=False,
 +    )
 +    repairer = ResponseRepairer(context)
++
 +    implementation_plan = temp_dir / "implementation.md"
 +    implementation_plan.write_text(
 +        "\n".join(
 +            [
 +                "# Implementation Plan",
 +                "",
 +                "## File Changes",
 +                f"- `{temp_dir / 'guides' / 'nginx' / 'index.html'}`",
 +                f"- `{temp_dir / 'guides' / 'nginx' / 'chapters'}`",
 +                "",
 +            ]
 +        )
 +    )
++
 +    dod = create_definition_of_done("Create a multi-file nginx guide.")
 +    dod.implementation_plan = str(implementation_plan)
 +    dod.pending_items.append("Develop the main index.html file for the nginx guide")
++
 +    decision = repairer.handle_empty_response(
 +        task="Create a multi-file nginx guide.",
 +        original_task=None,
 +        empty_retry_count=3,
 +        max_empty_retries=2,
 +        dod=dod,
 +    )
++
 +    assert decision.should_continue is True
 +    assert decision.retry_message is not None
 +    assert "retry 3/4" in decision.retry_message
 +    assert "Next missing planned artifact: `index.html`" in decision.retry_message
 +    assert (
 +        "Resume with this exact next step: continue `Develop the main index.html file for the nginx guide` "
 +        "by creating `index.html`."
 +        in decision.retry_message
 +    )
++
++
  def test_empty_response_retry_uses_compact_prompt_after_substantial_progress(
      temp_dir: Path,
  ) -> None: