`b210a18`

Block post-build reference drift

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 1 week ago

SHA: b210a18331eb22c802b9e9cbae3401d322d96b79
Parents: 3666782
Tree: 7de00c7

2 changed files

Status	File	+	-
M	`src/loader/runtime/hooks.py`	44	2
M	`tests/test_permissions.py`	63	0

src/loader/runtime/hooks.pymodified

  from ..tools.base import ToolResult as RegistryToolResult
  from .dod import (
      DefinitionOfDoneStore,
 -    all_planned_artifacts_exist,
      collect_missing_declared_html_output_files,
      collect_planned_artifact_targets,
      planned_artifact_target_satisfied,
      return ""
 +def _planned_artifact_targets_satisfied(dod: Any, *, project_root: Path) -> bool:
 +    targets = collect_planned_artifact_targets(
 +        dod,
 +        project_root=project_root,
 +    )
 +    if not targets:
 +        return False
 +    return all(
 +        planned_artifact_target_satisfied(
 +            dod,
 +            target=target,
 +            expect_directory=expect_directory,
 +            project_root=project_root,
 +        )
 +        for target, expect_directory in targets
 +    )
++
++
 +def _planned_artifact_targets_declare_missing_html_outputs(
 +    dod: Any,
 +    *,
 +    project_root: Path,
 +) -> bool:
 +    for target, _expect_directory in collect_planned_artifact_targets(
 +        dod,
 +        project_root=project_root,
 +    ):
 +        if collect_missing_declared_html_output_files(
 +            target=target,
 +            project_root=project_root,
 +        ):
 +            return True
 +    return False
++
++
  class ActiveRepairScopeHook(BaseToolHook):
      """Keep fix-mode observations anchored to the active artifact set."""
+         )
          if not planned_targets:
              return None
 -        if not all_planned_artifacts_exist(dod, project_root=self.project_root):
 +        if not _planned_artifact_targets_satisfied(
 +            dod,
 +            project_root=self.project_root,
 +        ):
 +            return None
 +        if _planned_artifact_targets_declare_missing_html_outputs(
 +            dod,
 +            project_root=self.project_root,
 +        ):
              return None
          planned_roots: list[str] = []

tests/test_permissions.pymodified

      assert str(temp_dir / "guide") in result.message
 +@pytest.mark.asyncio
 +async def test_late_reference_drift_hook_blocks_reference_reads_when_outputs_exist_but_need_quality(
 +    temp_dir: Path,
 +) -> None:
 +    registry = create_default_registry(temp_dir)
 +    policy = build_permission_policy(
 +        active_mode=PermissionMode.WORKSPACE_WRITE,
 +        workspace_root=temp_dir,
 +        tool_requirements=registry.get_tool_requirements(),
 +    )
 +    dod_store = DefinitionOfDoneStore(temp_dir)
 +    dod = create_definition_of_done("Create an equally thorough multi-page HTML guide.")
 +    dod.status = "in_progress"
 +    dod.pending_items.append("Improve generated guide depth and formatting")
 +    plan_path = temp_dir / "implementation.md"
 +    plan_path.write_text(
 +        "\n".join(
 +            [
 +                "# Implementation Plan",
 +                "",
 +                "## File Changes",
 +                f"- `{temp_dir / 'guide' / 'index.html'}`",
 +                f"- `{temp_dir / 'guide' / 'chapters'}/`",
 +                f"- `{temp_dir / 'guide' / 'chapters' / '01-getting-started.html'}`",
 +                "",
 +            ]
 +        )
 +    )
 +    dod.implementation_plan = str(plan_path)
 +    guide_dir = temp_dir / "guide" / "chapters"
 +    guide_dir.mkdir(parents=True, exist_ok=True)
 +    (temp_dir / "guide" / "index.html").write_text(
 +        '<h1>Guide</h1><a href="chapters/01-getting-started.html">One</a>\n'
 +    )
 +    (guide_dir / "01-getting-started.html").write_text("<h1>One</h1><p>thin</p>\n")
 +    dod_path = dod_store.save(dod)
 +    session = FakeSession(active_dod_path=str(dod_path), messages=[])
 +    hook = LateReferenceDriftHook(
 +        dod_store=dod_store,
 +        project_root=temp_dir,
 +        session=session,
 +    )
++
 +    result = await hook.pre_tool_use(
 +        HookContext(
 +            tool_call=ToolCall(
 +                id="read-reference",
 +                name="read",
 +                arguments={"file_path": str(temp_dir / "reference" / "index.html")},
 +            ),
 +            tool=registry.get("read"),
 +            registry=registry,
 +            permission_policy=policy,
 +            source="native",
 +        )
 +    )
++
 +    assert result.decision == HookDecision.DENY
 +    assert result.message is not None
 +    assert "completed artifact set scope" in result.message
 +    assert str(temp_dir / "guide") in result.message
++
++
  @pytest.mark.asyncio
  async def test_late_reference_drift_hook_blocks_verification_reference_reads_after_artifacts_exist(
      temp_dir: Path,