`d14cf85`

Block declared output drift

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 1 week ago

Status	File	+	-
M	`src/loader/runtime/hooks.py`	15	0
M	`tests/test_permissions.py`	6	2

src/loader/runtime/hooks.pymodified

              return None
          missing_label = ""
 +        declared_missing_label = ""
          completed_files = 0
          planned_roots: list[str] = []
          seen_roots: set[str] = set()
                  planned_roots.append(root)
                  seen_roots.add(root)
 +        if not missing_label:
 +            for target, _expect_directory in planned_targets:
 +                declared_missing = collect_missing_declared_html_output_files(
 +                    target=target,
 +                    project_root=self.project_root,
 +                )
 +                if not declared_missing:
 +                    continue
 +                declared_missing_label = str(declared_missing[0])
 +                missing_label = declared_missing_label
 +                break
++
          if not missing_label:
              return None
          minimum_completed_files = self._MIN_COMPLETED_FILES
 +        if declared_missing_label and completed_files >= 1:
 +            minimum_completed_files = 1
          if completed_files >= 1 and self._reference_study_completed(dod):
              minimum_completed_files = 1
          if completed_files < minimum_completed_files:

tests/test_permissions.pymodified

  @pytest.mark.asyncio
 -async def test_late_reference_drift_hook_does_not_block_when_html_outputs_still_link_to_missing_files(
 +async def test_late_reference_drift_hook_blocks_when_html_outputs_declare_missing_files(
      temp_dir: Path,
  ) -> None:
      registry = create_default_registry(temp_dir)
+         )
+     )
 -    assert result.decision == HookDecision.CONTINUE
 +    assert result.decision == HookDecision.DENY
 +    assert result.terminal_state == "blocked"
 +    assert result.message is not None
 +    assert "late reference drift" in result.message
 +    assert "02-installation.html" in result.message
  @pytest.mark.asyncio