`edd45ab`

Interrupt narrated next steps

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 1 week ago

SHA: edd45ab9df650772d886e27c9bc9f24a89c9c4c4
Parents: 77e1893
Tree: fcf10db

2 changed files

Status	File	+	-
M	`src/loader/runtime/turn_completion.py`	36	1
M	`tests/test_turn_completion.py`	88	0

src/loader/runtime/turn_completion.pymodified

              assistant_message = Message(role=Role.ASSISTANT, content=response_content)
              self.context.session.append(assistant_message)
              summary.assistant_messages.append(assistant_message)
 -            if progress_intent.target is not None and continuation_count == 0:
 +            if (
 +                progress_intent.target is not None
 +                and continuation_count == 0
 +                and not _recent_concrete_target_prompt(
 +                    progress_messages,
 +                    target=progress_intent.target,
 +                )
 +            ):
                  self._append_completion_trace_entry(
                      summary=summary,
                      stage="continuation_check",
      if next_output_file is not None:
          return next_output_file
      return None
++
++
 +def _recent_concrete_target_prompt(
 +    messages: list[object],
 +    *,
 +    target: Path,
 +) -> bool:
 +    target = target.expanduser().resolve(strict=False)
 +    target_text = str(target)
 +    target_name = target.name
 +    for message in reversed(messages[-6:]):
 +        role = getattr(message, "role", None)
 +        if getattr(role, "value", role) != "user":
 +            continue
 +        content = str(getattr(message, "content", "") or "")
 +        if not content:
 +            continue
 +        if "[CONTINUE CURRENT STEP]" not in content and "[USER INTERRUPTION]" not in content and "[EMPTY ASSISTANT RESPONSE]" not in content:
 +            continue
 +        if target_text not in content and target_name not in content:
 +            continue
 +        if (
 +            "concrete mutation tool call" in content
 +            or "Resume by creating" in content
 +            or "Emit this tool shape now" in content
 +        ):
 +            return True
 +    return False

tests/test_turn_completion.pymodified

  import pytest
  from loader.agent.loop import Agent, AgentConfig
 +from loader.llm.base import Message, Role
  from loader.runtime.conversation import ConversationRuntime
  from loader.runtime.dod import VerificationEvidence
  from loader.runtime.phases import TurnPhase
      assert "02-installation.html" in agent.session.messages[-1].content
 +@pytest.mark.asyncio
 +async def test_turn_completion_interrupts_first_narration_after_concrete_target_prompt(
 +    temp_dir: Path,
 +) -> None:
 +    backend = ScriptedBackend()
 +    config = non_streaming_config()
 +    config.reasoning.completion_check = False
 +    agent = Agent(
 +        backend=backend,
 +        config=config,
 +        project_root=temp_dir,
 +    )
 +    runtime = ConversationRuntime(agent)
 +    events = []
++
 +    async def capture(event) -> None:
 +        events.append(event)
++
 +    prepared = await runtime.turn_preparation.prepare(
 +        task=(
 +            "Create a multi-file nginx guide under ~/Loader/guides/nginx "
 +            "with an index and chapter files."
 +        ),
 +        emit=capture,
 +        requested_mode="execute",
 +        original_task=None,
 +        on_user_question=None,
 +    )
 +    await runtime.phase_tracker.enter(
 +        TurnPhase.ASSISTANT,
 +        capture,
 +        detail="Requesting assistant response",
 +        reason_code="request_assistant_response",
 +    )
++
 +    implementation_plan = temp_dir / "implementation.md"
 +    implementation_plan.write_text(
 +        "# Implementation Plan\n\n"
 +        "## File Changes\n\n"
 +        f"- `{temp_dir / 'index.html'}`\n"
 +        f"- `{temp_dir / 'chapters' / '01-introduction.html'}`\n"
 +    )
 +    chapters_dir = temp_dir / "chapters"
 +    chapters_dir.mkdir()
++
 +    prepared.definition_of_done.implementation_plan = str(implementation_plan)
 +    prepared.definition_of_done.pending_items.append(
 +        "Develop the main index.html file for nginx guide"
 +    )
++
 +    agent.session.append(
 +        Message(
 +            role=Role.USER,
 +            content=(
 +                "[USER INTERRUPTION]: Directory setup is complete. Continue with the next pending item: "
 +                "`Develop the main index.html file for nginx guide`. Resume by creating `index.html` now. "
 +                f"Prefer one `write` call for `{(temp_dir / 'index.html').resolve(strict=False)}` instead of more rereads. "
 +                "Make your next response the concrete mutation tool call itself, not another bookkeeping-only turn."
 +            ),
 +        )
 +    )
++
 +    content = "Now I'll create the main index.html file for the nginx guide."
 +    decision = await runtime.turn_completion.handle_text_response(
 +        content=content,
 +        response_content=content,
 +        task=prepared.task,
 +        effective_task=prepared.effective_task,
 +        iterations=1,
 +        max_iterations=agent.config.max_iterations,
 +        actions_taken=[],
 +        continuation_count=0,
 +        dod=prepared.definition_of_done,
 +        emit=capture,
 +        summary=prepared.summary,
 +        executor=prepared.executor,
 +        rollback_plan=prepared.rollback_plan,
 +    )
++
 +    assert decision.action == TurnCompletionAction.CONTINUE
 +    assert decision.continuation_count == 1
 +    assert prepared.summary.assistant_messages[-1].content == content
 +    assert agent.session.messages[-1].role.value == "user"
 +    assert agent.session.messages[-1].content.startswith("[CONTINUE CURRENT STEP]")
 +    assert "index.html" in agent.session.messages[-1].content
++
++
  @pytest.mark.asyncio
  async def test_turn_completion_handles_fake_tool_narration_without_reroute(
      temp_dir: Path,