`26489d3`

metrics: actions trigger counters + match-duration histogram (S41b)

Adds two metrics per the S41 campaign's observability commitments:

- shithub_actions_runs_enqueued_total{event,result}
Incremented in trigger.Enqueue. Result is 'fresh' for newly
inserted runs or 'already_exists' when ON CONFLICT DO NOTHING
fired (worker retry / admin replay landing on the same
trigger_event_id). Lets dashboards show the dedup-effectiveness.

- shithub_actions_trigger_match_duration_seconds (histogram)
Wall-clock time the trigger handler spends discovering +
parsing + matching workflows for one triggering event. The
'HEAD scan cost' pitfall in the sprint spec — alert when p95
drifts up.

Both register against the shared metrics.Registry. Instrumentation
sites: enqueue.Enqueue (counter) and handler.Handler (histogram via
deferred Observe so the timer covers the entire match loop).

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 3 days ago

SHA: 26489d394b97557e272ff309716b4f527d96fa36
Parents: 802a1c3
Tree: 0a89b9a

3 changed files

Status	File	+
M	`internal/actions/trigger/enqueue.go`	3
M	`internal/actions/trigger/handler.go`	7
M	`internal/infra/metrics/metrics.go`	21

internal/actions/trigger/enqueue.gomodified

  	actionsdb "github.com/tenseleyFlow/shithub/internal/actions/sqlc"
  	"github.com/tenseleyFlow/shithub/internal/actions/workflow"
  	"github.com/tenseleyFlow/shithub/internal/checks"
 +	"github.com/tenseleyFlow/shithub/internal/infra/metrics"
+ )
  // Deps wires the trigger pipeline against runtime infra.
  			if lookupErr != nil {
  				return Result{}, fmt.Errorf("trigger: existing-run lookup: %w", lookupErr)
+ 			}
 +			metrics.ActionsRunsEnqueuedTotal.WithLabelValues(string(p.EventKind), "already_exists").Inc()
  			return Result{
  				RunID:         existing.ID,
  				RunIndex:      existing.RunIndex,
  		_ = jobIDs[i] // job_id linkage to check_run lands in S41c when the runner consumes both
+ 	}
 +	metrics.ActionsRunsEnqueuedTotal.WithLabelValues(string(p.EventKind), "fresh").Inc()
  	return Result{
  		RunID:       run.ID,
  		RunIndex:    run.RunIndex,

internal/actions/trigger/handler.gomodified

  	"encoding/json"
  	"errors"
  	"fmt"
 +	"time"
  	"github.com/jackc/pgx/v5"
  	"github.com/jackc/pgx/v5/pgxpool"
  	"github.com/tenseleyFlow/shithub/internal/actions/workflow"
 +	"github.com/tenseleyFlow/shithub/internal/infra/metrics"
  	"github.com/tenseleyFlow/shithub/internal/infra/storage"
  	orgsdb "github.com/tenseleyFlow/shithub/internal/orgs/sqlc"
  	reposdb "github.com/tenseleyFlow/shithub/internal/repos/sqlc"
  			return fmt.Errorf("trigger: repo path: %w", err)
+ 		}
 +		matchStart := time.Now()
 +		defer func() {
 +			metrics.ActionsTriggerMatchDurationSeconds.Observe(time.Since(matchStart).Seconds())
 +		}()
++
  		files, skips, err := Discover(ctx, gitDir, p.HeadSHA)
  		if err != nil {
  			return fmt.Errorf("trigger: discover: %w", err)

internal/infra/metrics/metrics.gomodified

+ 	)
+ )
 +// Actions trigger pipeline metrics (S41b). Incremented from
 +// internal/actions/trigger.
 +var (
 +	ActionsRunsEnqueuedTotal = prometheus.NewCounterVec(
 +		prometheus.CounterOpts{
 +			Name: "shithub_actions_runs_enqueued_total",
 +			Help: "Total workflow runs enqueued by triggering event kind. Result is 'fresh' for new runs or 'already_exists' when ON CONFLICT noop'd.",
 +		},
 +		[]string{"event", "result"},
 +	)
 +	ActionsTriggerMatchDurationSeconds = prometheus.NewHistogram(
 +		prometheus.HistogramOpts{
 +			Name:    "shithub_actions_trigger_match_duration_seconds",
 +			Help:    "Wall-clock time spent in the trigger handler discovering + parsing + matching workflows for one triggering event.",
 +			Buckets: prometheus.ExponentialBuckets(0.005, 2.0, 12),
 +		},
 +	)
 +)
++
  func init() {
  	Registry.MustRegister(
  		HTTPRequestsTotal,
  		WorkerJobsProcessedTotal,
  		WorkerJobDurationSeconds,
  		WorkerInFlight,
 +		ActionsRunsEnqueuedTotal,
 +		ActionsTriggerMatchDurationSeconds,
+ 	)
+ }