`722bd7c`

Fix profile pin test assertions

Authored by

espadonne 3 days ago

SHA: 722bd7c5b212dac2dfc0e4638834a25de9ba0cb0
Parents: 7f720ee
Tree: 50280e0

1 changed file

Status	File	+	-
M	`internal/web/handlers/profile/profile_test.go`	3	3

internal/web/handlers/profile/profile_test.gomodified


 	}
 
 	got = env.getAs(t, "/alice", usersdb.User{})
-	for _, want := range []string{"PINS=2", "PINNAMES=shithub;loader;", "SELECTED=loader;shithub;"} {
+	for _, want := range []string{"PINS=2", "PINNAMES=shithub;loader;", "SELECTED=shithub;loader;"} {
 		if !strings.Contains(got, want) {
 			t.Fatalf("missing %q in body: %s", want, got)
 		}

 	env := setupProfileEnv(t)
 	owner := env.insertUser(t, "alice", "Alice", "")
 	orgID := env.insertOrg(t, "tenseleyflow", "tenseleyFlow", "workflows", owner)
-	shithubID := env.insertOrgRepo(t, orgID, "shithub", "GitHub clone", "public", "Go", 5, 1)
+	env.insertOrgRepo(t, orgID, "shithub", "GitHub clone", "public", "Go", 5, 1)
 	loaderID := env.insertOrgRepo(t, orgID, "loader", "local assistant", "public", "Python", 1, 0)
 	env.insertOrgRepo(t, orgID, "private-roadmap", "hidden", "private", "Rust", 9, 0)
 

 			t.Fatalf("missing %q in body: %s", want, got)
 		}
 	}
-	if strings.Contains(got, "PINNAMES=shithub;") || strings.Contains(got, strconv.FormatInt(shithubID, 10)) {
+	if strings.Contains(got, "PINNAMES=shithub;") || strings.Contains(got, "PINNAMES=loader;shithub;") {
 		t.Fatalf("custom org pins fell back to the synthetic set: %s", got)
 	}
 }

`@@ -386,7 +386,7 @@` func TestProfile_UserPinsCanBeCustomized(t *testing.T) {
386	386	}
387	387
388	388	got = env.getAs(t, "/alice", usersdb.User{})
389		- for _, want := range []string{"PINS=2", "PINNAMES=shithub;loader;", "SELECTED=loader;shithub;"} {
	389	+ for _, want := range []string{"PINS=2", "PINNAMES=shithub;loader;", "SELECTED=shithub;loader;"} {
390	390	if !strings.Contains(got, want) {
391	391	t.Fatalf("missing %q in body: %s", want, got)
392	392	}
`@@ -401,7 +401,7 @@` func TestProfile_OrgPinsFallbackUntilCustomized(t *testing.T) {
401	401	env := setupProfileEnv(t)
402	402	owner := env.insertUser(t, "alice", "Alice", "")
403	403	orgID := env.insertOrg(t, "tenseleyflow", "tenseleyFlow", "workflows", owner)
404		- shithubID := env.insertOrgRepo(t, orgID, "shithub", "GitHub clone", "public", "Go", 5, 1)
	404	+ env.insertOrgRepo(t, orgID, "shithub", "GitHub clone", "public", "Go", 5, 1)
405	405	loaderID := env.insertOrgRepo(t, orgID, "loader", "local assistant", "public", "Python", 1, 0)
406	406	env.insertOrgRepo(t, orgID, "private-roadmap", "hidden", "private", "Rust", 9, 0)
407	407
`@@ -426,7 +426,7 @@` func TestProfile_OrgPinsFallbackUntilCustomized(t *testing.T) {
426	426	t.Fatalf("missing %q in body: %s", want, got)
427	427	}
428	428	}
429		- if strings.Contains(got, "PINNAMES=shithub;") \|\| strings.Contains(got, strconv.FormatInt(shithubID, 10)) {
	429	+ if strings.Contains(got, "PINNAMES=shithub;") \|\| strings.Contains(got, "PINNAMES=loader;shithub;") {
430	430	t.Fatalf("custom org pins fell back to the synthetic set: %s", got)
431	431	}
432	432	}