`7c9dd0d`

actions/trigger + scripts: gofumpt + drop unused placeholder + lint-unused bash 3.2 shim (S41b)

- gofumpt fixes across the trigger package + dispatch handler
- drop the stale 'startedAtNow' placeholder var in enqueue.go that
the lint-unused script flagged as a dead 'silence unused import'
shim (it was originally a hint for S41c+, but never used)
- scripts/lint-unused.sh: ${ALLOWED_FILES[@]:-} so an empty
array doesn't trip set -u under macOS bash 3.2

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 3 days ago

SHA: 7c9dd0d4789b042a805e99e30cca0daf62ffb0f8
Parents: b5d3edd
Tree: 63bbcac

7 changed files

Status	File	+	-
M	`cmd/shithubd/worker.go`	1	1
M	`internal/actions/trigger/enqueue.go`	0	8
M	`internal/actions/trigger/glob.go`	3	3
M	`internal/actions/trigger/glob_test.go`	2	2
M	`internal/actions/trigger/match.go`	9	9
M	`internal/web/handlers/repo/actions_dispatch.go`	2	1
M	`scripts/lint-unused.sh`	4	2

cmd/shithubd/worker.gomodified

  	"github.com/spf13/cobra"
 +	"github.com/tenseleyFlow/shithub/internal/actions/trigger"
  	"github.com/tenseleyFlow/shithub/internal/auth/audit"
  	"github.com/tenseleyFlow/shithub/internal/auth/email"
  	"github.com/tenseleyFlow/shithub/internal/auth/secretbox"
  	"github.com/tenseleyFlow/shithub/internal/infra/config"
  	"github.com/tenseleyFlow/shithub/internal/infra/db"
  	"github.com/tenseleyFlow/shithub/internal/infra/storage"
 -	"github.com/tenseleyFlow/shithub/internal/actions/trigger"
  	"github.com/tenseleyFlow/shithub/internal/webhook"
  	"github.com/tenseleyFlow/shithub/internal/worker"
  	"github.com/tenseleyFlow/shithub/internal/worker/jobs"

internal/actions/trigger/enqueue.gomodified

  	"errors"
  	"fmt"
  	"log/slog"
 -	"time"
  	"github.com/jackc/pgx/v5"
  	"github.com/jackc/pgx/v5/pgtype"
+ 	}
  	return json.Marshal(out)
+ }
+-
 -// startedAtNow is a small helper used by tests + future re-run callers
 -// to set started_at on insert (S41c+ scenarios). Not currently used by
 -// Enqueue — runs start in queued state.
 -var _ = func() pgtype.Timestamptz {
 -	return pgtype.Timestamptz{Time: time.Now(), Valid: true}
 -}

internal/web/handlers/repo/actions_dispatch.gomodified

  const dispatchMaxBody = 64 * 1024
  // repoActionsDispatch implements
 +//
  //	POST /{owner}/{repo}/actions/workflows/{file}/dispatches
  //
  // 204 on success; the trigger pipeline runs synchronously here

scripts/lint-unused.shmodified

    exit 0
  fi
 -# Strip allowlisted files.
 -for allowed in "${ALLOWED_FILES[@]}"; do
 +# Strip allowlisted files. ${arr[@]:-} guards against bash 3.2's
 +# unbound-empty-array behavior under set -u (macOS default shell).
 +for allowed in "${ALLOWED_FILES[@]:-}"; do
 +  [ -z "$allowed" ] && continue
    matches=$(echo "$matches" | grep -v "^${allowed}:" || true)
  done