`a73b2e2`

drop var-_-equals-symbol unused-import shims (SR2 M1)

Pre-fix: 8 sites carried 'var _ = symbol' shims with comments like
'silence unused-import warnings during refactors'. These were lying:
in every case the import was already used elsewhere in the file or
the symbol was unreachable. Audit 2026-05-08 flagged 3 occurrences;
audit 2026-05-10 found 8 — the pattern grew because nothing failed
CI on it.

Sites cleaned:
- internal/auth/totp/recovery.go (base32.StdEncoding)
- internal/web/middleware/pat.go (pgx.ErrNoRows)
- internal/web/handlers/orgs/teams.go (pgx.ErrNoRows + errors.New)
- internal/web/handlers/profile/profile.go (context.Background)
- internal/web/handlers/api/api.go (context.Background)
- internal/web/handlers/repo/code.go (pgtype.Int8{})
- internal/web/handlers/repo/redirect.go (usersdb.New)

Build still passes after each shim drop because the imports are
genuinely live; the shims were cargo-cult.

Authored by

espadonne 3 days ago

SHA: a73b2e28962820aa766759ab953b1aaa6cad9451
Parents: c8058f1
Tree: 192f834

7 changed files

Status	File	-
M	`internal/auth/totp/recovery.go`	4
M	`internal/web/handlers/api/api.go`	4
M	`internal/web/handlers/orgs/teams.go`	11
M	`internal/web/handlers/profile/profile.go`	5
M	`internal/web/handlers/repo/code.go`	5
M	`internal/web/handlers/repo/redirect.go`	5
M	`internal/web/middleware/pat.go`	5

internal/auth/totp/recovery.gomodified

  	"crypto/rand"
  	"crypto/sha256"
  	"crypto/subtle"
 -	"encoding/base32"
  	"errors"
  	"strings"
+ )
  // ErrRecoveryCodeInvalid is returned by callers when the typed code
  // doesn't match any stored hash.
  var ErrRecoveryCodeInvalid = errors.New("totp: recovery code invalid")
+-
 -// noOpUseStdEncoding silences unused-import warnings during refactors.
 -var _ = base32.StdEncoding

internal/web/handlers/api/api.gomodified

  package api
  import (
 -	"context"
  	"encoding/json"
  	"errors"
  	"net/http"
  func writeAPIError(w http.ResponseWriter, status int, msg string) {
  	writeJSON(w, status, map[string]string{"error": msg})
+ }
+-
 -// silence unused import on the rare branch where context is not used.
 -var _ = context.Background

internal/web/handlers/orgs/teams.gomodified

  package orgs
  import (
 -	"errors"
  	"net/http"
  	"strconv"
  	"strings"
  	"github.com/go-chi/chi/v5"
 -	"github.com/jackc/pgx/v5"
  	"github.com/tenseleyFlow/shithub/internal/orgs"
  	orgsdb "github.com/tenseleyFlow/shithub/internal/orgs/sqlc"
  func (h *Handlers) teamPath(org orgsdb.Org, team orgsdb.Team) string {
  	return "/" + string(org.Slug) + "/teams/" + string(team.Slug)
+ }
+-
 -// ensure pgx is referenced when the rest of the file's imports
 -// settle (avoids a "imported and not used" if a future refactor
 -// drops the only inline pgx use).
 -var _ = pgx.ErrNoRows
+-
 -// errTeamNotFound is reserved for the future; surfaced via
 -// orgs.ErrTeamNotFound when needed.
 -var _ = errors.New

internal/web/handlers/profile/profile.gomodified

  package profile
  import (
 -	"context"
  	"errors"
  	"fmt"
  	"html/template"
+ 	}
  	return template.URL(u.String()) //nolint:gosec // schemes vetted above.
+ }
+-
 -// ensure context import is used by static analysis even if a future
 -// refactor removes its only inline use.
 -var _ = context.Background

internal/web/handlers/repo/code.gomodified

  	"strings"
  	"github.com/go-chi/chi/v5"
 -	"github.com/jackc/pgx/v5/pgtype"
  	"github.com/tenseleyFlow/shithub/internal/auth/policy"
  	mdrender "github.com/tenseleyFlow/shithub/internal/markdown"
+ 	}
  	return parent + "/" + child
+ }
+-
 -// silence pgtype unused-import warning when the loadRepoAndAuthorize
 -// helper is in this file's package but defined elsewhere.
 -var _ = pgtype.Int8{}

internal/web/handlers/repo/redirect.gomodified

  	"github.com/jackc/pgx/v5/pgtype"
  	reposdb "github.com/tenseleyFlow/shithub/internal/repos/sqlc"
 -	usersdb "github.com/tenseleyFlow/shithub/internal/users/sqlc"
+ )
  // tryRedirect resolves a (stale_owner, stale_name) URL to its current
  	tail := strings.TrimPrefix(r.URL.Path, "/"+ownerName+"/"+repoName)
  	return "/" + currentOwner + "/" + row.Name + tail
+ }
+-
 -// _ keeps usersdb imported even when only its types are referenced
 -// indirectly via the handlers struct. Unused-import guard.
 -var _ = usersdb.New

internal/web/middleware/pat.gomodified

  	"strings"
  	"time"
 -	"github.com/jackc/pgx/v5"
  	"github.com/jackc/pgx/v5/pgxpool"
  	"github.com/tenseleyFlow/shithub/internal/auth/pat"
+ 	}
  	return nil
+ }
+-
 -// ensure pgx import is used by static-analysis tools (the ErrNoRows
 -// sentinel is referenced via err comparison in dependent middleware).
 -var _ = pgx.ErrNoRows