`aa9ab45`

S14: install hooks on repo create; thread shithubd path from web layer

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 6 days ago

Status	File	+	-
M	`internal/repos/create.go`	18	0
M	`internal/web/handlers/repo/repo.go`	10	5
M	`internal/web/repo_wiring.go`	19	6

internal/repos/create.gomodified

  	"github.com/tenseleyFlow/shithub/internal/auth/audit"
  	"github.com/tenseleyFlow/shithub/internal/auth/throttle"
 +	"github.com/tenseleyFlow/shithub/internal/git/hooks"
  	"github.com/tenseleyFlow/shithub/internal/infra/storage"
  	repogit "github.com/tenseleyFlow/shithub/internal/repos/git"
  	reposdb "github.com/tenseleyFlow/shithub/internal/repos/sqlc"
  	Limiter *throttle.Limiter
  	Logger  *slog.Logger
  	Now     func() time.Time
 +	// ShithubdPath is the absolute path to the running shithubd binary,
 +	// baked into the hook shims so push -> hook -> shithubd round-trip
 +	// works in dev and prod. Empty disables hook installation (tests
 +	// that don't care about hooks; the full E2E happy path provides it).
 +	ShithubdPath string
+ }
  // Params describes one repo-create request as it arrives from the
  		return Result{}, fmt.Errorf("repos: init bare: %w", err)
+ 	}
 +	// Install push-pipeline hooks. Skipped when ShithubdPath is empty
 +	// (test fixtures that exercise repo creation without the hook
 +	// stack). The plumbing-driven initial commit doesn't fire hooks —
 +	// hooks only run on user-driven pushes — so this is the right
 +	// boundary.
 +	if deps.ShithubdPath != "" {
 +		if err := hooks.Install(diskPath, deps.ShithubdPath); err != nil {
 +			_ = os.RemoveAll(diskPath)
 +			return Result{}, fmt.Errorf("repos: install hooks: %w", err)
 +		}
 +	}
++
  	var commitOID string
  	if wantInit {
  		commitWhen := p.InitialCommitWhen

internal/web/handlers/repo/repo.gomodified

  	Audit     *audit.Recorder
  	Limiter   *throttle.Limiter
  	CloneURLs CloneURLs
 +	// ShithubdPath is forwarded to repos.Create so newly-init'd repos
 +	// have hook shims pointing at the right binary. Empty in test fixtures
 +	// that don't exercise hooks.
 +	ShithubdPath string
+ }
  // Handlers is the registered handler set. Construct via New.
  		Audit:        h.d.Audit,
  		Limiter:      h.d.Limiter,
  		Logger:       h.d.Logger,
 +		ShithubdPath: h.d.ShithubdPath,
  	}, repos.Params{
  		OwnerUserID:   user.ID,
  		OwnerUsername: user.Username,

internal/web/repo_wiring.gomodified

  	"fmt"
  	"io/fs"
  	"log/slog"
 +	"os"
  	"path/filepath"
  	"github.com/jackc/pgx/v5/pgxpool"
  	if err != nil {
  		return nil, fmt.Errorf("repo: render.New: %w", err)
+ 	}
 +	// shithubdPath is the running binary, baked into hook shims by
 +	// repos.Create. os.Executable can rarely fail (e.g. exec name
 +	// stripped); when it does we fall back to "shithubd" on PATH so
 +	// hook shims still resolve in unusual environments.
 +	shithubdPath := "shithubd"
 +	if exe, err := os.Executable(); err == nil {
 +		if abs, err := filepath.Abs(exe); err == nil {
 +			shithubdPath = abs
 +		}
 +	}
++
  	return repoh.New(repoh.Deps{
  		Logger:       logger,
  		Render:       rr,
  		RepoFS:       rfs,
  		Audit:        audit.NewRecorder(),
  		Limiter:      throttle.NewLimiter(),
 +		ShithubdPath: shithubdPath,
  		CloneURLs: repoh.CloneURLs{
  			BaseURL:    cfg.Auth.BaseURL,
  			SSHEnabled: false, // S12/S13 will flip this when SSH service ships.