`b8dabf2`

api/actions_lifecycle_rest: detach cleanup goroutine via WithoutCancel

Authored by mfwolffe <wolffemf@dukes.jmu.edu> yesterday

Status	File	+	-
M	`internal/web/handlers/api/actions_lifecycle_rest.go`	8	4

internal/web/handlers/api/actions_lifecycle_rest.gomodified

  		return
+ 	}
  	if h.d.ObjectStore != nil && len(objectKeys) > 0 {
 -		go h.purgeArtifactObjects(objectKeys)
 +		go h.purgeArtifactObjects(context.WithoutCancel(r.Context()), objectKeys)
+ 	}
  	w.WriteHeader(http.StatusNoContent)
+ }
  // request lifecycle. Failures are logged but never surfaced — the
  // authoritative DB row is gone, and the cleanup sweeper retries
  // orphan-object deletion on its own schedule.
 -func (h *Handlers) purgeArtifactObjects(keys []string) {
 -	ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
 +//
 +// parent is expected to be `context.WithoutCancel(r.Context())` so
 +// the goroutine survives response completion while still carrying
 +// trace/log values from the originating request.
 +func (h *Handlers) purgeArtifactObjects(parent context.Context, keys []string) {
 +	ctx, cancel := context.WithTimeout(parent, 30*time.Second)
  	defer cancel()
  	for _, k := range keys {
  		if err := h.d.ObjectStore.Delete(ctx, k); err != nil {
  		return
+ 	}
  	if h.d.ObjectStore != nil {
 -		go h.purgeArtifactObjects([]string{artifact.ObjectKey})
 +		go h.purgeArtifactObjects(context.WithoutCancel(r.Context()), []string{artifact.ObjectKey})
+ 	}
  	w.WriteHeader(http.StatusNoContent)
+ }