`bc5cbb9`

Add repo product tab shells

Authored by

espadonne 3 days ago

SHA: bc5cbb9f9c7281275bfa794402d18338e37586fc
Parents: 4463c19
Tree: 44530dd

7 changed files

Status	File	+	-
M	`docs/internal/code-tab.md`	24	3
A	`internal/web/handlers/repo/deferred_tabs.go`	141	0
M	`internal/web/handlers/repo/repo.go`	11	3
M	`internal/web/render/octicons.go`	2	0
M	`internal/web/static/css/shithub.css`	96	1
M	`internal/web/templates/_repo_subnav.html`	14	3
A	`internal/web/templates/repo/deferred_tab.html`	30	0

docs/internal/code-tab.mdmodified

  The code tab is the GitHub-style repo browser: tree listing, blob view
  with syntax highlighting, raw view, "Go to file" finder, and the
 -branch/tag switcher. After a successful push, hitting `/{owner}/{repo}`
 -sends the user to `/tree/{default_branch}`.
 +branch/tag switcher. For populated repos, `/{owner}/{repo}` renders the
 +default branch Code tab directly, matching GitHub's canonical repo URL.
  ## Routes
  | Route                                            | Handler                          |
  | ------------------------------------------------ | -------------------------------- |
 -| `GET /{owner}/{repo}`                            | redirects to `/tree/{default}`   |
 +| `GET /{owner}/{repo}`                            | default-branch Code tab          |
  | `GET /{owner}/{repo}/tree/{ref}/{path...}`       | `codeTree`                       |
  | `GET /{owner}/{repo}/blob/{ref}/{path...}`       | `codeBlob`                       |
  | `GET /{owner}/{repo}/raw/{ref}/{path...}`        | `codeRaw`                        |
  | `GET /{owner}/{repo}/find/{ref}?q=...`           | `codeFinder`                     |
 +| `GET /{owner}/{repo}/actions`                    | parked product-tab shell         |
 +| `GET /{owner}/{repo}/projects`                   | parked product-tab shell         |
 +| `GET /{owner}/{repo}/wiki`                       | parked product-tab shell         |
 +| `GET /{owner}/{repo}/security`                   | parked product-tab shell         |
 +| `GET /{owner}/{repo}/pulse`                      | parked product-tab shell         |
 +| `GET /{owner}/{repo}/packages`                   | parked product-tab shell         |
 +| `GET /{owner}/{repo}/releases`                   | parked product-tab shell         |
  | `GET /static/css/chroma.css`                     | runtime-generated Chroma theme   |
  Every code-tab handler runs through `policy.Can(... ActionRepoRead)` —
  private repos hide from anonymous viewers and unrelated users via the
  existence-leak 404 guard from S15.
 +## Repository product tabs
++
 +The repo header intentionally exposes GitHub's major product-map tabs:
 +Code, Issues, Pull requests, Actions, Projects, Wiki, Security and
 +quality, Insights, and Settings when visible to the viewer. Forks remain
 +available from the repo action button and About sidebar, but are not a
 +top-level tab on GitHub.
++
 +Actions, Projects, Wiki, Security and quality, Insights, Packages, and
 +Releases currently render honest parked shells via `repo/deferred_tab`.
 +They are public read surfaces gated by `ActionRepoRead`, so private repo
 +existence behavior matches Code/Issues/Pull requests while the deeper
 +systems remain assigned to their later sprints.
++
  ## Ref + path disambiguation
  `{ref}` is the chi `*` wildcard, so the URL `/tree/feature/x/sub/file.go`

internal/web/handlers/repo/deferred_tabs.goadded

 +// SPDX-License-Identifier: AGPL-3.0-or-later
++
 +package repo
++
 +import (
 +	"net/http"
++
 +	"github.com/tenseleyFlow/shithub/internal/auth/policy"
 +	reposdb "github.com/tenseleyFlow/shithub/internal/repos/sqlc"
 +	"github.com/tenseleyFlow/shithub/internal/web/middleware"
 +)
++
 +type repoDeferredTab struct {
 +	Active      string
 +	Heading     string
 +	Description string
 +	Icon        string
 +	Sections    []repoDeferredSection
 +}
++
 +type repoDeferredSection struct {
 +	Anchor string
 +	Title  string
 +	Body   string
 +}
++
 +func (h *Handlers) repoTabActions(w http.ResponseWriter, r *http.Request) {
 +	h.renderDeferredRepoTab(w, r, repoDeferredTab{
 +		Active:      "actions",
 +		Heading:     "Actions",
 +		Description: "Automate your development workflow with repository workflows and check runs.",
 +		Icon:        "play",
 +		Sections: []repoDeferredSection{
 +			{Anchor: "all-workflows", Title: "All workflows", Body: "Workflow execution is parked for the Actions sprint. Check runs posted by external systems still appear on pull requests."},
 +			{Anchor: "workflows", Title: "Workflows", Body: "Add workflow files later under .shithub/workflows to run jobs on push and pull request events."},
 +		},
 +	})
 +}
++
 +func (h *Handlers) repoTabProjects(w http.ResponseWriter, r *http.Request) {
 +	h.renderDeferredRepoTab(w, r, repoDeferredTab{
 +		Active:      "projects",
 +		Heading:     "Projects",
 +		Description: "Organize issues and pull requests with repository project views.",
 +		Icon:        "table",
 +		Sections: []repoDeferredSection{
 +			{Anchor: "open", Title: "Open", Body: "No projects have been created for this repository."},
 +			{Anchor: "closed", Title: "Closed", Body: "Closed repository projects will appear here."},
 +		},
 +	})
 +}
++
 +func (h *Handlers) repoTabWiki(w http.ResponseWriter, r *http.Request) {
 +	h.renderDeferredRepoTab(w, r, repoDeferredTab{
 +		Active:      "wiki",
 +		Heading:     "Wiki",
 +		Description: "Create long-form documentation pages connected to this repository.",
 +		Icon:        "book",
 +		Sections: []repoDeferredSection{
 +			{Anchor: "pages", Title: "Pages", Body: "No wiki pages have been created yet."},
 +		},
 +	})
 +}
++
 +func (h *Handlers) repoTabSecurity(w http.ResponseWriter, r *http.Request) {
 +	h.renderDeferredRepoTab(w, r, repoDeferredTab{
 +		Active:      "security",
 +		Heading:     "Security and quality",
 +		Description: "Review repository security posture, policy files, alerts, and dependency health.",
 +		Icon:        "shield-check",
 +		Sections: []repoDeferredSection{
 +			{Anchor: "overview", Title: "Overview", Body: "Security overview is not wired yet."},
 +			{Anchor: "policy", Title: "Policy", Body: "Security policy detection already appears in the repository About sidebar when SECURITY.md exists."},
 +			{Anchor: "alerts", Title: "Alerts", Body: "Code scanning, secret scanning, and dependency alerts are reserved for later security sprints."},
 +		},
 +	})
 +}
++
 +func (h *Handlers) repoTabInsights(w http.ResponseWriter, r *http.Request) {
 +	h.renderDeferredRepoTab(w, r, repoDeferredTab{
 +		Active:      "insights",
 +		Heading:     "Insights",
 +		Description: "Understand activity, contributors, traffic, community health, and dependency graph data.",
 +		Icon:        "pulse",
 +		Sections: []repoDeferredSection{
 +			{Anchor: "pulse", Title: "Pulse", Body: "Repository pulse data is not available yet."},
 +			{Anchor: "contributors", Title: "Contributors", Body: "Contributor graphs will be derived from git history in a later pass."},
 +			{Anchor: "community", Title: "Community", Body: "README, license, code of conduct, contributing, and security files are already detected on the Code tab."},
 +		},
 +	})
 +}
++
 +func (h *Handlers) repoTabPackages(w http.ResponseWriter, r *http.Request) {
 +	h.renderDeferredRepoTab(w, r, repoDeferredTab{
 +		Active:      "packages",
 +		Heading:     "Packages",
 +		Description: "Publish and install packages associated with this repository.",
 +		Icon:        "package",
 +		Sections: []repoDeferredSection{
 +			{Anchor: "repository-packages", Title: "Repository packages", Body: "No packages have been published for this repository."},
 +		},
 +	})
 +}
++
 +func (h *Handlers) repoTabReleases(w http.ResponseWriter, r *http.Request) {
 +	h.renderDeferredRepoTab(w, r, repoDeferredTab{
 +		Active:      "releases",
 +		Heading:     "Releases",
 +		Description: "Package release notes, binaries, and source archives from repository tags.",
 +		Icon:        "tag",
 +		Sections: []repoDeferredSection{
 +			{Anchor: "latest-release", Title: "Latest release", Body: "No releases have been published yet."},
 +			{Anchor: "tags", Title: "Tags", Body: "Tags are available from the Code tab and the repository tags page."},
 +		},
 +	})
 +}
++
 +func (h *Handlers) renderDeferredRepoTab(w http.ResponseWriter, r *http.Request, tab repoDeferredTab) {
 +	row, owner, ok := h.loadRepoAndAuthorize(w, r, policy.ActionRepoRead)
 +	if !ok {
 +		return
 +	}
 +	data := h.repoHeaderData(r, row, owner.Username, tab.Active)
 +	data["Title"] = tab.Heading + " · " + row.Name
 +	data["Tab"] = tab
 +	if err := h.d.Render.RenderPage(w, r, "repo/deferred_tab", data); err != nil {
 +		h.d.Logger.ErrorContext(r.Context(), "repo deferred tab render", "tab", tab.Active, "error", err)
 +	}
 +}
++
 +func (h *Handlers) repoHeaderData(r *http.Request, row reposdb.Repo, owner, active string) map[string]any {
 +	return map[string]any{
 +		"CSRFToken":    middleware.CSRFTokenForRequest(r),
 +		"Owner":        owner,
 +		"Repo":         row,
 +		"RepoActions":  h.repoActions(r, row.ID),
 +		"RepoCounts":   h.subnavCounts(r.Context(), row.ID, row.ForkCount),
 +		"CanSettings":  h.canViewSettings(middleware.CurrentUserFromContext(r.Context())),
 +		"ActiveSubnav": active,
 +	}
 +}

internal/web/handlers/repo/repo.gomodified

  	r.Post("/new", h.newRepoSubmit)
+ }
 -// MountRepoHome registers /{owner}/{repo}. This is a 2-segment route so
 -// it doesn't collide with the /{username} catch-all from S09. Caller is
 -// responsible for ordering: register this BEFORE /{username}.
 +// MountRepoHome registers the root repository route plus product-tab shells
 +// that are intentionally public and read-gated like the Code tab. The
 +// two-segment route doesn't collide with the /{username} catch-all from S09;
 +// caller is responsible for ordering this BEFORE /{username}.
  func (h *Handlers) MountRepoHome(r chi.Router) {
 +	r.Get("/{owner}/{repo}/actions", h.repoTabActions)
 +	r.Get("/{owner}/{repo}/projects", h.repoTabProjects)
 +	r.Get("/{owner}/{repo}/wiki", h.repoTabWiki)
 +	r.Get("/{owner}/{repo}/security", h.repoTabSecurity)
 +	r.Get("/{owner}/{repo}/pulse", h.repoTabInsights)
 +	r.Get("/{owner}/{repo}/packages", h.repoTabPackages)
 +	r.Get("/{owner}/{repo}/releases", h.repoTabReleases)
  	r.Get("/{owner}/{repo}", h.repoHome)
+ }

internal/web/render/octicons.gomodified

  			`><path d="M6.906.664a1.75 1.75 0 0 1 2.188 0l5.25 4.2c.414.331.656.833.656 1.363v7.023A1.75 1.75 0 0 1 13.25 15h-2.5A1.75 1.75 0 0 1 9 13.25V10H7v3.25A1.75 1.75 0 0 1 5.25 15h-2.5A1.75 1.75 0 0 1 1 13.25V6.227c0-.53.242-1.032.656-1.363Zm1.25 1.171a.25.25 0 0 0-.312 0l-5.25 4.2a.25.25 0 0 0-.094.192v7.023c0 .138.112.25.25.25h2.5a.25.25 0 0 0 .25-.25V9.75A1.25 1.25 0 0 1 6.75 8.5h2.5a1.25 1.25 0 0 1 1.25 1.25v3.5c0 .138.112.25.25.25h2.5a.25.25 0 0 0 .25-.25V6.227a.25.25 0 0 0-.094-.192Z"/></svg>`),
  		"table": trustedSVG(`<svg xmlns="http://www.w3.org/2000/svg" ` + cls +
  			`><path d="M0 1.75C0 .784.784 0 1.75 0h12.5C15.216 0 16 .784 16 1.75v12.5A1.75 1.75 0 0 1 14.25 16H1.75A1.75 1.75 0 0 1 0 14.25ZM6.5 6.5v8h7.75a.25.25 0 0 0 .25-.25V6.5Zm8-1.5V1.75a.25.25 0 0 0-.25-.25H6.5V5Zm-13 1.5v7.75c0 .138.112.25.25.25H5v-8ZM5 5V1.5H1.75a.25.25 0 0 0-.25.25V5Z"/></svg>`),
 +		"play": trustedSVG(`<svg xmlns="http://www.w3.org/2000/svg" ` + cls +
 +			`><path d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Zm4.879-2.773 4.264 2.559a.25.25 0 0 1 0 .428l-4.264 2.559A.25.25 0 0 1 6 10.559V5.442a.25.25 0 0 1 .379-.215Z"/></svg>`),
  		"code": trustedSVG(`<svg xmlns="http://www.w3.org/2000/svg" ` + cls +
  			`><path d="M5.22 4.22a.75.75 0 0 1 1.06 1.06L3.56 8l2.72 2.72a.75.75 0 1 1-1.06 1.06L1.97 8.53a.75.75 0 0 1 0-1.06Zm5.56 0a.75.75 0 0 1 1.06 0l3.25 3.25a.75.75 0 0 1 0 1.06l-3.25 3.25a.75.75 0 1 1-1.06-1.06L13.5 8l-2.72-2.72a.75.75 0 0 1 0-1.06Z"/></svg>`),
  		"git-pull-request": trustedSVG(`<svg xmlns="http://www.w3.org/2000/svg" ` + cls +

internal/web/static/css/shithub.cssmodified

    gap: 0.25rem;
    margin: 0;
    border-bottom: 1px solid var(--border-default);
 -  flex-wrap: wrap;
 +  overflow-x: auto;
 +  overscroll-behavior-x: contain;
+ }
  .shithub-repo-subnav-tab {
    display: inline-flex;
    text-decoration: none;
    position: relative;
    bottom: -1px;
 +  flex: 0 0 auto;
 +  white-space: nowrap;
+ }
  .shithub-repo-subnav-tab:hover { background: var(--canvas-subtle); border-radius: 6px 6px 0 0; }
  .shithub-repo-subnav-tab.is-active { border-bottom-color: var(--accent-emphasis, #fd8c73); font-weight: 600; }
    align-items: start;
+ }
  .shithub-repo-main { min-width: 0; }
++
 +.shithub-repo-product-page {
 +  max-width: 80rem;
 +  margin: 1.5rem auto 2rem;
 +  padding: 0 1rem;
 +  display: grid;
 +  grid-template-columns: 18rem minmax(0, 1fr);
 +  gap: 1.5rem;
 +}
 +.shithub-repo-product-sidebar { min-width: 0; }
 +.shithub-repo-product-sidebar h2 {
 +  margin: 0 0 0.75rem;
 +  font-size: 1rem;
 +}
 +.shithub-repo-product-sidebar nav {
 +  display: grid;
 +  gap: 0.15rem;
 +}
 +.shithub-repo-product-sidebar a {
 +  display: block;
 +  padding: 0.45rem 0.6rem;
 +  border-radius: 6px;
 +  color: var(--fg-default);
 +  text-decoration: none;
 +  font-size: 0.875rem;
 +}
 +.shithub-repo-product-sidebar a:hover,
 +.shithub-repo-product-sidebar a.is-active {
 +  background: var(--canvas-subtle);
 +}
 +.shithub-repo-product-main { min-width: 0; }
 +.shithub-repo-product-head {
 +  display: flex;
 +  align-items: flex-start;
 +  gap: 0.8rem;
 +  padding-bottom: 1rem;
 +  border-bottom: 1px solid var(--border-default);
 +}
 +.shithub-repo-product-icon {
 +  display: inline-flex;
 +  align-items: center;
 +  justify-content: center;
 +  width: 2rem;
 +  height: 2rem;
 +  border: 1px solid var(--border-default);
 +  border-radius: 6px;
 +  color: var(--fg-muted);
 +  background: var(--canvas-subtle);
 +  flex: 0 0 auto;
 +}
 +.shithub-repo-product-head h1 {
 +  margin: 0 0 0.2rem;
 +  font-size: 1.5rem;
 +  font-weight: 600;
 +}
 +.shithub-repo-product-head p {
 +  margin: 0;
 +  color: var(--fg-muted);
 +  font-size: 0.95rem;
 +}
 +.shithub-repo-product-blankslate {
 +  margin-top: 1rem;
 +  border: 1px solid var(--border-default);
 +  border-radius: 6px;
 +  background: var(--canvas-default);
 +}
 +.shithub-repo-product-section {
 +  padding: 1rem;
 +  border-bottom: 1px solid var(--border-default);
 +}
 +.shithub-repo-product-section:last-child { border-bottom: 0; }
 +.shithub-repo-product-section h2 {
 +  margin: 0 0 0.35rem;
 +  font-size: 1rem;
 +}
 +.shithub-repo-product-section p {
 +  margin: 0;
 +  color: var(--fg-muted);
 +  font-size: 0.9rem;
 +}
 +@media (max-width: 800px) {
 +  .shithub-repo-product-page {
 +    grid-template-columns: 1fr;
 +  }
 +  .shithub-repo-product-sidebar nav {
 +    display: flex;
 +    overflow-x: auto;
 +  }
 +  .shithub-repo-product-sidebar a {
 +    white-space: nowrap;
 +  }
 +}
  .shithub-tree-panel {
    border: 1px solid var(--border-default);
    border-radius: 6px;

internal/web/templates/_repo_subnav.htmlmodified

      {{ octicon "git-pull-request" }} Pull requests
      {{ with .RepoCounts.Pulls }}<span class="shithub-tab-count">{{ . }}</span>{{ end }}
    </a>
 -  <a href="/{{ .Owner }}/{{ .Repo.Name }}/forks" class="shithub-repo-subnav-tab{{ if eq .ActiveSubnav "forks" }} is-active{{ end }}">
 -    {{ octicon "repo-forked" }} Forks
 -    {{ with .RepoCounts.Forks }}<span class="shithub-tab-count">{{ . }}</span>{{ end }}
 +  <a href="/{{ .Owner }}/{{ .Repo.Name }}/actions" class="shithub-repo-subnav-tab{{ if eq .ActiveSubnav "actions" }} is-active{{ end }}">
 +    {{ octicon "play" }} Actions
 +  </a>
 +  <a href="/{{ .Owner }}/{{ .Repo.Name }}/projects" class="shithub-repo-subnav-tab{{ if eq .ActiveSubnav "projects" }} is-active{{ end }}">
 +    {{ octicon "table" }} Projects
 +  </a>
 +  <a href="/{{ .Owner }}/{{ .Repo.Name }}/wiki" class="shithub-repo-subnav-tab{{ if eq .ActiveSubnav "wiki" }} is-active{{ end }}">
 +    {{ octicon "book" }} Wiki
 +  </a>
 +  <a href="/{{ .Owner }}/{{ .Repo.Name }}/security" class="shithub-repo-subnav-tab{{ if eq .ActiveSubnav "security" }} is-active{{ end }}">
 +    {{ octicon "shield-check" }} Security and quality
 +  </a>
 +  <a href="/{{ .Owner }}/{{ .Repo.Name }}/pulse" class="shithub-repo-subnav-tab{{ if eq .ActiveSubnav "insights" }} is-active{{ end }}">
 +    {{ octicon "pulse" }} Insights
    </a>
    {{ if .CanSettings }}
    <a href="/{{ .Owner }}/{{ .Repo.Name }}/settings" class="shithub-repo-subnav-tab{{ if eq .ActiveSubnav "settings" }} is-active{{ end }}">

internal/web/templates/repo/deferred_tab.htmladded

 +{{ define "page" -}}
 +{{ template "repo-header" . }}
 +<section class="shithub-repo-product-page">
 +  <aside class="shithub-repo-product-sidebar" aria-label="{{ .Tab.Heading }}">
 +    <h2>{{ .Tab.Heading }}</h2>
 +    <nav aria-label="{{ .Tab.Heading }} sections">
 +      {{ range $i, $section := .Tab.Sections }}
 +        <a href="#{{ $section.Anchor }}"{{ if eq $i 0 }} class="is-active" aria-current="page"{{ end }}>{{ $section.Title }}</a>
 +      {{ end }}
 +    </nav>
 +  </aside>
 +  <div class="shithub-repo-product-main">
 +    <header class="shithub-repo-product-head">
 +      <span class="shithub-repo-product-icon">{{ octicon .Tab.Icon }}</span>
 +      <div>
 +        <h1>{{ .Tab.Heading }}</h1>
 +        <p>{{ .Tab.Description }}</p>
 +      </div>
 +    </header>
 +    <div class="shithub-repo-product-blankslate">
 +      {{ range .Tab.Sections }}
 +      <section id="{{ .Anchor }}" class="shithub-repo-product-section">
 +        <h2>{{ .Title }}</h2>
 +        <p>{{ .Body }}</p>
 +      </section>
 +      {{ end }}
 +    </div>
 +  </div>
 +</section>
 +{{- end }}