@@ -67,10 +67,7 @@ class PersonViewSet(viewsets.ReadOnlyModelViewSet): |
| 67 | 67 | |
| 68 | 68 | if conflict_id is not None: |
| 69 | 69 | queryset = queryset.filter(conflict_id=conflict_id) |
| 70 | | - return queryset.extra( |
| 71 | | - select={'class_year_null': 'class_year IS NULL'}, |
| 72 | | - order_by=['class_year_null', 'class_year', 'last_name', 'first_name'] |
| 73 | | - ) |
| 70 | + return queryset.order_by('last_name', 'first_name') |
| 74 | 71 | |
| 75 | 72 | order_by = self.request.query_params.get('order_by', 'name') |
| 76 | 73 | |
@@ -135,10 +132,7 @@ class PersonViewSet(viewsets.ReadOnlyModelViewSet): |
| 135 | 132 | except ValueError: |
| 136 | 133 | pass |
| 137 | 134 | |
| 138 | | - queryset = queryset.extra( |
| 139 | | - select={'class_year_null': 'class_year IS NULL'}, |
| 140 | | - order_by=['class_year_null', 'class_year', 'last_name', 'first_name'] |
| 141 | | - ) |
| 135 | + queryset = queryset.order_by('last_name', 'first_name') |
| 142 | 136 | |
| 143 | 137 | serializer = PersonDetailSerializer(queryset, many=True) |
| 144 | 138 | return Response({ |
@@ -354,10 +348,7 @@ def memorial_index(request): |
| 354 | 348 | data = [] |
| 355 | 349 | |
| 356 | 350 | for conflict in conflicts: |
| 357 | | - casualties = Person.objects.filter(conflict=conflict).extra( |
| 358 | | - select={'class_year_null': 'class_year IS NULL'}, |
| 359 | | - order_by=['class_year_null', 'class_year', 'last_name', 'first_name'] |
| 360 | | - ) |
| 351 | + casualties = Person.objects.filter(conflict=conflict).order_by('last_name', 'first_name') |
| 361 | 352 | conflict_data = ConflictSerializer(conflict).data |
| 362 | 353 | conflict_data['casualties'] = PersonDetailSerializer(casualties, many=True).data |
| 363 | 354 | data.append(conflict_data) |