vmi-virtual-memorial/vmi-wd-backend / f34b2eb

Browse files

sort complete index alphabetically isntead of by class year

Authored by espadonne
SHA
f34b2eb87259823c6d3ec8042ed6b60fb9419f5c
Parents
f8b8fc2
Tree
29b6fe7

1 changed file

StatusFile+-
M memorial/views.py 3 12
memorial/views.pymodified
@@ -67,10 +67,7 @@ class PersonViewSet(viewsets.ReadOnlyModelViewSet):
6767
 
6868
         if conflict_id is not None:
6969
             queryset = queryset.filter(conflict_id=conflict_id)
70
-            return queryset.extra(
71
-                select={'class_year_null': 'class_year IS NULL'},
72
-                order_by=['class_year_null', 'class_year', 'last_name', 'first_name']
73
-            )
70
+            return queryset.order_by('last_name', 'first_name')
7471
 
7572
         order_by = self.request.query_params.get('order_by', 'name')
7673
 
@@ -135,10 +132,7 @@ class PersonViewSet(viewsets.ReadOnlyModelViewSet):
135132
                 except ValueError:
136133
                     pass
137134
 
138
-        queryset = queryset.extra(
139
-            select={'class_year_null': 'class_year IS NULL'},
140
-            order_by=['class_year_null', 'class_year', 'last_name', 'first_name']
141
-        )
135
+        queryset = queryset.order_by('last_name', 'first_name')
142136
 
143137
         serializer = PersonDetailSerializer(queryset, many=True)
144138
         return Response({
@@ -354,10 +348,7 @@ def memorial_index(request):
354348
     data = []
355349
     
356350
     for conflict in conflicts:
357
-        casualties = Person.objects.filter(conflict=conflict).extra(
358
-            select={'class_year_null': 'class_year IS NULL'},
359
-            order_by=['class_year_null', 'class_year', 'last_name', 'first_name']
360
-        )
351
+        casualties = Person.objects.filter(conflict=conflict).order_by('last_name', 'first_name')
361352
         conflict_data = ConflictSerializer(conflict).data
362353
         conflict_data['casualties'] = PersonDetailSerializer(casualties, many=True).data
363354
         data.append(conflict_data)