`cce3b1d`

add Display for ProtonCompatibility, improve version preference handling

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 2 months ago

SHA: cce3b1d79fbe85ae330b35dbdc48f1595ad7d8f6
Parents: 60ee785
Tree: ef2e5f7

1 changed file

Status	File	+	-
M	`crates/wanda-core/src/steam/proton.rs`	38	5

crates/wanda-core/src/steam/proton.rsmodified

  use crate::error::{Result, WandaError};
  use crate::steam::SteamInstallation;
  use std::cmp::Ordering;
 +use std::fmt;
  use std::path::{Path, PathBuf};
  use tracing::{debug, info, warn};
      Unsupported,
+ }
 +impl fmt::Display for ProtonCompatibility {
 +    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 +        match self {
 +            ProtonCompatibility::Recommended => write!(f, "Recommended"),
 +            ProtonCompatibility::Supported => write!(f, "Supported"),
 +            ProtonCompatibility::Experimental => write!(f, "Experimental"),
 +            ProtonCompatibility::Unsupported => write!(f, "Unsupported"),
 +        }
 +    }
 +}
++
  /// A detected Proton installation
  #[derive(Debug, Clone)]
  pub struct ProtonVersion {
          // Check user preference first
          if let Some(ref preferred) = config.proton.preferred_version {
              if let Some(v) = self.find_by_name(preferred) {
 -                if v.compatibility == ProtonCompatibility::Unsupported {
 -                    warn!(
 -                        "Preferred Proton version {} has known compatibility issues",
 -                        v.name
 -                    );
 +                match v.compatibility {
 +                    ProtonCompatibility::Unsupported => {
 +                        warn!(
 +                            "Preferred Proton version '{}' is {} — it has known compatibility issues with WeMod",
 +                            v.name, v.compatibility
 +                        );
 +                        if let Some(rec) = self.get_recommended() {
 +                            warn!(
 +                                "Consider switching to '{}' ({}): wanda init --proton '{}'",
 +                                rec.name, rec.compatibility, rec.name
 +                            );
 +                        }
 +                    }
 +                    ProtonCompatibility::Experimental => {
 +                        warn!(
 +                            "Preferred Proton version '{}' is {} — GE-Proton 10.x wow64 mode can break WeMod's renderer",
 +                            v.name, v.compatibility
 +                        );
 +                        if let Some(rec) = self.get_recommended() {
 +                            warn!(
 +                                "Consider switching to '{}' ({}): wanda init --proton '{}'",
 +                                rec.name, rec.compatibility, rec.name
 +                            );
 +                        }
 +                    }
 +                    _ => {}
+                 }
                  return Ok(v);
+             }