`71ebaed`

Resolve dlm-registry aliases in --teacher hf:<key>

Audit 12 M12.6: 'hf:smollm2-135m' was passed literally to HF Hub (401), inconsistent with 'dlm init --base smollm2-135m' which resolves the alias. Normalize at parse_teacher_ref's hf branch — canonical HF id wins, literal org/repo passes through unchanged.

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 2 weeks ago

SHA: 71ebaedd02823e3e71ae76f7bf8ce364b658b8f8
Parents: a19a302
Tree: 7a57e98

2 changed files

Status	File	+	-
M	`src/dlm/synth/teachers.py`	9	0
M	`tests/unit/synth/test_teachers.py`	11	0

src/dlm/synth/teachers.pymodified

          target = spec.removeprefix("hf:").strip()
          if not target:
              raise InvalidTeacherSpecError("hf teacher selector must include a model id")
 +        # Resolve dlm-registry aliases (e.g. `hf:smollm2-135m`) to their
 +        # canonical HuggingFace id. Keeps `--teacher hf:<key>` consistent
 +        # with `dlm init --base <key>`. A literal HF id (`org/repo`)
 +        # passes through unchanged.
 +        from dlm.base_models.registry import BASE_MODELS
++
 +        spec_entry = BASE_MODELS.get(target)
 +        if spec_entry is not None:
 +            target = spec_entry.hf_id
          return TeacherRef(raw=spec, kind="hf", target=target)
      if spec.startswith("openai:"):
          target = spec.removeprefix("openai:").strip()

tests/unit/synth/test_teachers.pymodified

          with pytest.raises(InvalidTeacherSpecError, match=message):
              parse_teacher_ref(raw)
 +    def test_hf_teacher_resolves_dlm_registry_alias(self) -> None:
 +        # Audit 12 M12.6: `hf:smollm2-135m` should resolve via the registry,
 +        # mirroring `dlm init --base smollm2-135m`. A literal HF id stays put.
 +        ref = parse_teacher_ref("hf:smollm2-135m")
 +        assert ref.kind == "hf"
 +        assert ref.target == "HuggingFaceTB/SmolLM2-135M-Instruct"
++
 +    def test_hf_teacher_passes_through_literal_hf_id(self) -> None:
 +        ref = parse_teacher_ref("hf:Qwen/Qwen2.5-1.5B-Instruct")
 +        assert ref.target == "Qwen/Qwen2.5-1.5B-Instruct"
++
  class TestBuildTeacher:
      def test_self_requires_dlm_path(self) -> None: