`a53d8d8`

Extend multi-file retry budget

Authored by

espadonne 2 weeks ago

SHA: a53d8d87392f3609cce9b492c69548ccae3b4929
Parents: a41b947
Tree: 50a2684

2 changed files

Status	File	+	-
M	`src/loader/runtime/repair.py`	21	1
M	`tests/test_repair.py`	55	0

src/loader/runtime/repair.pymodified

      "Collect verification evidence",
+ }
  _LATE_STAGE_EMPTY_RETRY_EXTRA = 2
 +_MULTI_FILE_OUTPUT_EMPTY_RETRY_EXTRA = 2
  _WORKING_NOTE_TOOL_NAMES = (
      "notepad_write_working",
      "notepad_append",
          if completed_artifacts >= 3 and missing_artifacts > 0:
              return base_max_empty_retries + _LATE_STAGE_EMPTY_RETRY_EXTRA
          if self._has_concrete_next_output_step(dod):
 -            return base_max_empty_retries + _LATE_STAGE_EMPTY_RETRY_EXTRA
 +            extra_retries = _LATE_STAGE_EMPTY_RETRY_EXTRA
 +            if self._has_confirmed_output_file_progress(dod):
 +                extra_retries += _MULTI_FILE_OUTPUT_EMPTY_RETRY_EXTRA
 +            return base_max_empty_retries + extra_retries
          return base_max_empty_retries
      def _should_compact_empty_retry_message(self, dod: DefinitionOfDone) -> bool:
+         )
          return next_output_file is not None
 +    def _has_confirmed_output_file_progress(self, dod: DefinitionOfDone) -> bool:
 +        return any(
 +            not expect_directory
 +            and planned_artifact_target_satisfied(
 +                dod,
 +                target=target,
 +                expect_directory=False,
 +                project_root=self.context.project_root,
 +            )
 +            for target, expect_directory in collect_planned_artifact_targets(
 +                dod,
 +                project_root=self.context.project_root,
 +                max_paths=12,
 +            )
 +        )
++
      def _planned_artifact_progress_lines(self, dod: DefinitionOfDone) -> list[str]:
          targets = collect_planned_artifact_targets(
              dod,

tests/test_repair.pymodified

+     )
 +def test_empty_response_retry_budget_extends_further_after_first_output_file_exists(
 +    temp_dir: Path,
 +) -> None:
 +    context = build_context(
 +        temp_dir=temp_dir,
 +        use_react=False,
 +    )
 +    repairer = ResponseRepairer(context)
++
 +    guide_root = temp_dir / "guides" / "nginx"
 +    chapters = guide_root / "chapters"
 +    guide_root.mkdir(parents=True)
 +    chapters.mkdir()
 +    index_path = guide_root / "index.html"
 +    index_path.write_text("<html></html>\n")
++
 +    implementation_plan = temp_dir / "implementation.md"
 +    implementation_plan.write_text(
 +        "\n".join(
 +            [
 +                "# Implementation Plan",
 +                "",
 +                "## File Changes",
 +                f"- `{chapters}/`",
 +                f"- `{index_path}`",
 +                "",
 +            ]
 +        )
 +    )
++
 +    dod = create_definition_of_done("Create a multi-file nginx guide.")
 +    dod.implementation_plan = str(implementation_plan)
 +    dod.touched_files.append(str(index_path))
 +    dod.completed_items.extend(
 +        [
 +            "Create the new nginx guide directory structure",
 +            "Develop the main index.html file with proper structure",
 +        ]
 +    )
 +    dod.pending_items.append("Create 01-introduction.html")
++
 +    decision = repairer.handle_empty_response(
 +        task="Create a multi-file nginx guide.",
 +        original_task=None,
 +        empty_retry_count=5,
 +        max_empty_retries=2,
 +        dod=dod,
 +    )
++
 +    assert decision.should_continue is True
 +    assert decision.retry_message is not None
 +    assert "retry 5/6" in decision.retry_message
 +    assert "01-introduction.html" in decision.retry_message
++
++
  def test_empty_response_retry_uses_compact_prompt_after_substantial_progress(
      temp_dir: Path,
  ) -> None: