`7c9dd0d`

actions/trigger + scripts: gofumpt + drop unused placeholder + lint-unused bash 3.2 shim (S41b)

- gofumpt fixes across the trigger package + dispatch handler
- drop the stale 'startedAtNow' placeholder var in enqueue.go that
the lint-unused script flagged as a dead 'silence unused import'
shim (it was originally a hint for S41c+, but never used)
- scripts/lint-unused.sh: ${ALLOWED_FILES[@]:-} so an empty
array doesn't trip set -u under macOS bash 3.2

Authored by mfwolffe <wolffemf@dukes.jmu.edu> 3 days ago

SHA: 7c9dd0d4789b042a805e99e30cca0daf62ffb0f8
Parents: b5d3edd
Tree: 63bbcac

7 changed files

Status	File	+	-
M	`cmd/shithubd/worker.go`	1	1
M	`internal/actions/trigger/enqueue.go`	0	8
M	`internal/actions/trigger/glob.go`	3	3
M	`internal/actions/trigger/glob_test.go`	2	2
M	`internal/actions/trigger/match.go`	9	9
M	`internal/web/handlers/repo/actions_dispatch.go`	2	1
M	`scripts/lint-unused.sh`	4	2

cmd/shithubd/worker.gomodified

  	"github.com/spf13/cobra"
++	"github.com/tenseleyFlow/shithub/internal/actions/trigger"
  	"github.com/tenseleyFlow/shithub/internal/auth/audit"
  	"github.com/tenseleyFlow/shithub/internal/auth/email"
  	"github.com/tenseleyFlow/shithub/internal/auth/secretbox"
  	"github.com/tenseleyFlow/shithub/internal/infra/config"
  	"github.com/tenseleyFlow/shithub/internal/infra/db"
  	"github.com/tenseleyFlow/shithub/internal/infra/storage"
--	"github.com/tenseleyFlow/shithub/internal/actions/trigger"
  	"github.com/tenseleyFlow/shithub/internal/webhook"
  	"github.com/tenseleyFlow/shithub/internal/worker"
  	"github.com/tenseleyFlow/shithub/internal/worker/jobs"

internal/actions/trigger/enqueue.gomodified

  	"errors"
  	"fmt"
  	"log/slog"
--	"time"
  	"github.com/jackc/pgx/v5"
  	"github.com/jackc/pgx/v5/pgtype"
+ 	}
  	return json.Marshal(out)
+ }
--
--// startedAtNow is a small helper used by tests + future re-run callers
--// to set started_at on insert (S41c+ scenarios). Not currently used by
--// Enqueue — runs start in queued state.
--var _ = func() pgtype.Timestamptz {
--	return pgtype.Timestamptz{Time: time.Now(), Valid: true}
--}

internal/actions/trigger/glob.gomodified

  //   - `*`           matches any sequence of non-`/` characters.
  //   - `**`          matches any sequence including `/`.
  //   - `/**` at end  matches zero or more trailing segments
--//                   (so `feature/**` matches both `feature` and
++//     (so `feature/**` matches both `feature` and
--//                   `feature/foo/bar`).
++//     `feature/foo/bar`).
  //   - `!pattern`    excludes. Evaluated in declaration order;
--//                   last-match wins. (Mirrors minimatch.)
++//     last-match wins. (Mirrors minimatch.)
  //
  // Empty pattern list returns true — "no filter" means "match all" per
  // GHA convention.

internal/actions/trigger/glob_test.gomodified


 		s       string
 		want    bool
 	}{
+		{"feature/**", "feature", true}, // zero trailing segments
 		{"feature/**", "feature/foo", true},
 		{"feature/**", "feature/foo/bar", true},
 		{"feature/**", "main", false},

 		{"**/*.go", "pkg/sub/x.go", true},
 		{"**/*.go", "pkg/sub/x.txt", false},
 		{"docs/**/*.md", "docs/internal/x.md", true},
+		{"docs/**/*.md", "docs/x.md", true}, // ** matches zero segments
 		{"docs/**/*.md", "src/x.md", false},
 		{"**", "literally/any/path", true},
 	}

internal/actions/trigger/match.gomodified

  // The four event kinds:
  //
  //   - push              → on.push present, branch/tag classification
--//                         passes the appropriate sub-filter, paths
++//     passes the appropriate sub-filter, paths
--//                         filter (when set) hits at least one
++//     filter (when set) hits at least one
--//                         changed path
++//     changed path
  //   - pull_request      → on.pull_request present, action is in the
--//                         configured types: list (default ["opened",
++//     configured types: list (default ["opened",
--//                         "synchronize", "reopened"]), base branch
++//     "synchronize", "reopened"]), base branch
--//                         passes branches: filter, paths filter hits
++//     passes branches: filter, paths filter hits
  //   - schedule          → on.schedule has any entry whose cron string
--//                         equals event.Cron (the sweep tells us which
++//     equals event.Cron (the sweep tells us which
--//                         cron fired; we just verify the workflow
++//     cron fired; we just verify the workflow
--//                         declared it)
++//     declared it)
  //   - workflow_dispatch → on.workflow_dispatch present
  //
  // Anything else returns false silently — strict-allowlist v1 posture.

internal/web/handlers/repo/actions_dispatch.gomodified


 const dispatchMaxBody = 64 * 1024
 
 // repoActionsDispatch implements
+//
+//	POST /{owner}/{repo}/actions/workflows/{file}/dispatches
 //
 // 204 on success; the trigger pipeline runs synchronously here
 // because the workflow file is already known (no discovery needed),

scripts/lint-unused.shmodified

    exit 0
  fi
--# Strip allowlisted files.
++# Strip allowlisted files. ${arr[@]:-} guards against bash 3.2's
--for allowed in "${ALLOWED_FILES[@]}"; do
++# unbound-empty-array behavior under set -u (macOS default shell).
++for allowed in "${ALLOWED_FILES[@]:-}"; do
++  [ -z "$allowed" ] && continue
    matches=$(echo "$matches" | grep -v "^${allowed}:" || true)
  done

`@@ -45,7 +45,7 @@` func TestGlobMatch_DoubleStar(t *testing.T) {
45	s string	45	s string
46	want bool	46	want bool
47	}{	47	}{
48	- {"feature/**", "feature", true}, // zero trailing segments	48	+ {"feature/**", "feature", true}, // zero trailing segments
49	{"feature/**", "feature/foo", true},	49	{"feature/**", "feature/foo", true},
50	{"feature/**", "feature/foo/bar", true},	50	{"feature/**", "feature/foo/bar", true},
51	{"feature/**", "main", false},	51	{"feature/**", "main", false},
`@@ -53,7 +53,7 @@` func TestGlobMatch_DoubleStar(t *testing.T) {
53	{"*/.go", "pkg/sub/x.go", true},	53	{"*/.go", "pkg/sub/x.go", true},
54	{"*/.go", "pkg/sub/x.txt", false},	54	{"*/.go", "pkg/sub/x.txt", false},
55	{"docs/*/.md", "docs/internal/x.md", true},	55	{"docs/*/.md", "docs/internal/x.md", true},
56	- {"docs/*/.md", "docs/x.md", true}, // ** matches zero segments	56	+ {"docs/*/.md", "docs/x.md", true}, // ** matches zero segments
57	{"docs/*/.md", "src/x.md", false},	57	{"docs/*/.md", "src/x.md", false},
58	{"**", "literally/any/path", true},	58	{"**", "literally/any/path", true},
59	}	59	}

`@@ -42,7 +42,8 @@` type dispatchRequest struct {
42	const dispatchMaxBody = 64 * 1024	42	const dispatchMaxBody = 64 * 1024
43		43
44	// repoActionsDispatch implements	44	// repoActionsDispatch implements
45	-// POST /{owner}/{repo}/actions/workflows/{file}/dispatches	45	+//
		46	+// POST /{owner}/{repo}/actions/workflows/{file}/dispatches
46	//	47	//
47	// 204 on success; the trigger pipeline runs synchronously here	48	// 204 on success; the trigger pipeline runs synchronously here
48	// because the workflow file is already known (no discovery needed),	49	// because the workflow file is already known (no discovery needed),