gofumpt sweep — formatter now runs in CI · shithub

Status	File	+	-
M	`cmd/shithubd/hook.go`	14	15
M	`cmd/shithubd/ssh.go`	4	2
M	`internal/auth/audit/audit.go`	42	42
M	`internal/auth/policy/adapters.go`	0	1
M	`internal/auth/policy/policy_test.go`	3	4
M	`internal/auth/reserved.go`	2	2
M	`internal/checks/checks.go`	9	9
M	`internal/checks/checks_test.go`	4	4
M	`internal/checks/create.go`	3	3
M	`internal/checks/required_eval.go`	4	4
M	`internal/checks/suite_rollup_test.go`	4	4
M	`internal/git/protocol/ssh_dispatch_test.go`	2	1
M	`internal/issues/notif_emit.go`	2	1
M	`internal/issues/references.go`	4	4
M	`internal/issues/references_test.go`	0	1
M	`internal/markdown/extensions/emoji.go`	90	90
M	`internal/markdown/extensions/extensions.go`	23	23
M	`internal/markdown/markdown_test.go`	2	2
M	`internal/notif/email.go`	2	1
M	`internal/notif/emit.go`	2	2
M	`internal/notif/fanout_test.go`	5	4
M	`internal/notif/notif.go`	7	7
M	`internal/notif/routing.go`	4	4
M	`internal/orgs/create.go`	9	9
M	`internal/orgs/hard_delete.go`	2	1
M	`internal/orgs/invitations.go`	7	7
M	`internal/pulls/merge.go`	0	1
M	`internal/pulls/pulls.go`	7	7
M	`internal/pulls/review/request.go`	2	1
M	`internal/pulls/review/review_test.go`	9	9
M	`internal/pulls/review/submit.go`	3	3
M	`internal/repos/diff/parse/parse.go`	4	4
M	`internal/repos/diff/render/render.go`	4	2
M	`internal/repos/diff/source/source.go`	6	3
M	`internal/repos/fork/fork.go`	13	13
M	`internal/repos/git/branchops.go`	2	1
M	`internal/repos/git/logops.go`	10	9
M	`internal/repos/git/mergeops.go`	10	5
M	`internal/repos/git/plumbing.go`	2	1
M	`internal/repos/lifecycle/hard_delete.go`	0	1
M	`internal/repos/lifecycle/transfer.go`	14	14
M	`internal/repos/protection/protection.go`	4	5
M	`internal/search/query_parse.go`	2	2
M	`internal/search/search_test.go`	4	2
M	`internal/social/social.go`	2	2
M	`internal/web/handlers/api/checks.go`	4	4
M	`internal/web/handlers/api/stars.go`	0	1
M	`internal/web/handlers/auth/auth_test.go`	2	1
M	`internal/web/handlers/auth/avatar.go`	2	1
M	`internal/web/handlers/auth/danger_test.go`	2	1
M	`internal/web/handlers/auth/tokens_test.go`	2	1
M	`internal/web/handlers/orgs/orgs.go`	9	9
M	`internal/web/handlers/orgs/teams.go`	7	4
M	`internal/web/handlers/repo/branches.go`	19	19
M	`internal/web/handlers/repo/code.go`	8	8
M	`internal/web/handlers/repo/fork.go`	2	2
M	`internal/web/handlers/repo/issues.go`	2	1
M	`internal/web/handlers/repo/lifecycle.go`	3	3
M	`internal/web/handlers/repo/pulls.go`	9	8
M	`internal/web/handlers/repo/repo.go`	3	3
M	`internal/web/handlers/repo/settings_branches.go`	21	21
M	`internal/web/handlers/repo/webhooks.go`	1	1
M	`internal/webhook/deliver.go`	0	1
M	`internal/webhook/fanout.go`	13	13
M	`internal/webhook/jobs.go`	3	3
M	`internal/webhook/manage.go`	4	4
M	`internal/webhook/ssrf_test.go`	4	4
M	`internal/worker/jobs/push_process.go`	1	2
M	`internal/worker/jobs/repo_index_reconcile.go`	2	1
M	`internal/worker/pool.go`	2	1

cmd/shithubd/hook.gomodified

  	pool   *pgxpool.Pool
  	logger *slog.Logger
--	userID     int64
++	userID    int64
--	username   string
++	username  string
--	repoID     int64
++	repoID    int64
--	repoFull   string
++	repoFull  string
--	protocol   string
++	protocol  string
--	remoteIP   string
++	remoteIP  string
--	requestID  string
++	requestID string
+ }
  func loadHookCtx(ctx context.Context) (*hookCtx, error) {
+ 	}
  	for _, r := range refs {
  		event, err := wq.InsertPushEvent(ctx, tx, workerdb.InsertPushEventParams{
--			RepoID:        h.repoID,
++			RepoID:       h.repoID,
--			BeforeSha:     r.before,
++			BeforeSha:    r.before,
--			AfterSha:      r.after,
++			AfterSha:     r.after,
--			Ref:           r.ref,
++			Ref:          r.ref,
--			Protocol:      protocol,
++			Protocol:     protocol,
--			PusherUserID:  pgtype.Int8{Int64: h.userID, Valid: h.userID != 0},
++			PusherUserID: pgtype.Int8{Int64: h.userID, Valid: h.userID != 0},
--			RequestID:     pgtype.Text{String: h.requestID, Valid: h.requestID != ""},
++			RequestID:    pgtype.Text{String: h.requestID, Valid: h.requestID != ""},
  		})
  		if err != nil {
  			return fmt.Errorf("insert push_event: %w", err)
  	rootCmd.AddCommand(hookCmd)
  	rootCmd.AddCommand(hooksParentCmd)
+ }
--

cmd/shithubd/ssh.gomodified

  		if dispatchErr != nil {
  			pool.Close()
  			_, _ = fmt.Fprintln(cmd.ErrOrStderr(), protocol.FriendlyMessageFor(dispatchErr, ""))
--			logger.WarnContext(ctx, "ssh-shell: denied",
++			logger.WarnContext(
++				ctx, "ssh-shell: denied",
  				"user_id", userID,
  				"original", original,
  				"remote_ip", remoteIP,
  			)
  			return dispatchErr
  		}
--		logger.InfoContext(ctx, "ssh-shell: dispatch",
++		logger.InfoContext(
++			ctx, "ssh-shell: dispatch",
  			"user_id", userID,
  			"op", string(parsed.Service),
  			"owner", parsed.Owner,

internal/auth/audit/audit.gomodified

  type Action string
  const (
--	Action2FAEnabled           Action = "2fa_enabled"
++	Action2FAEnabled            Action = "2fa_enabled"
--	Action2FADisabled          Action = "2fa_disabled"
++	Action2FADisabled           Action = "2fa_disabled"
--	ActionRecoveryCodesIssued  Action = "recovery_codes_issued"
++	ActionRecoveryCodesIssued   Action = "recovery_codes_issued"
--	ActionRecoveryCodeUsed     Action = "recovery_code_used"
++	ActionRecoveryCodeUsed      Action = "recovery_code_used"
--	ActionRecoveryRegenerated  Action = "recovery_codes_regenerated"
++	ActionRecoveryRegenerated   Action = "recovery_codes_regenerated"
--	ActionAdminCleared2FA      Action = "admin_cleared_2fa"
++	ActionAdminCleared2FA       Action = "admin_cleared_2fa"
--	ActionPasswordChanged      Action = "password_changed"
++	ActionPasswordChanged       Action = "password_changed"
--	ActionPasswordReset        Action = "password_reset_consumed"
++	ActionPasswordReset         Action = "password_reset_consumed"
--	ActionLoginSucceeded       Action = "login_succeeded"
++	ActionLoginSucceeded        Action = "login_succeeded"
--	ActionLoginFailedThrottled Action = "login_failed_throttled"
++	ActionLoginFailedThrottled  Action = "login_failed_throttled"
--	ActionAccountSuspended     Action = "account_suspended"
++	ActionAccountSuspended      Action = "account_suspended"
--	ActionSSHKeyAdded          Action = "ssh_key_added"
++	ActionSSHKeyAdded           Action = "ssh_key_added"
--	ActionSSHKeyDeleted        Action = "ssh_key_deleted"
++	ActionSSHKeyDeleted         Action = "ssh_key_deleted"
--	ActionPATCreated           Action = "pat_created"
++	ActionPATCreated            Action = "pat_created"
--	ActionPATRevoked           Action = "pat_revoked"
++	ActionPATRevoked            Action = "pat_revoked"
--	ActionUsernameChanged      Action = "username_changed"
++	ActionUsernameChanged       Action = "username_changed"
--	ActionAccountDeleted       Action = "account_deleted"
++	ActionAccountDeleted        Action = "account_deleted"
--	ActionAccountRestored      Action = "account_restored"
++	ActionAccountRestored       Action = "account_restored"
--	ActionRepoCreated            Action = "repo_created"
++	ActionRepoCreated           Action = "repo_created"
--	ActionRepoRenamed            Action = "repo_renamed"
++	ActionRepoRenamed           Action = "repo_renamed"
--	ActionRepoArchived           Action = "repo_archived"
++	ActionRepoArchived          Action = "repo_archived"
--	ActionRepoUnarchived         Action = "repo_unarchived"
++	ActionRepoUnarchived        Action = "repo_unarchived"
--	ActionRepoVisibilityChanged  Action = "repo_visibility_changed"
++	ActionRepoVisibilityChanged Action = "repo_visibility_changed"
--	ActionRepoSoftDeleted        Action = "repo_soft_deleted"
++	ActionRepoSoftDeleted       Action = "repo_soft_deleted"
--	ActionRepoRestored           Action = "repo_restored"
++	ActionRepoRestored          Action = "repo_restored"
--	ActionRepoHardDeleted        Action = "repo_hard_deleted"
++	ActionRepoHardDeleted       Action = "repo_hard_deleted"
--	ActionRepoTransferRequested  Action = "repo_transfer_requested"
++	ActionRepoTransferRequested Action = "repo_transfer_requested"
--	ActionRepoTransferAccepted   Action = "repo_transfer_accepted"
++	ActionRepoTransferAccepted  Action = "repo_transfer_accepted"
--	ActionRepoTransferDeclined   Action = "repo_transfer_declined"
++	ActionRepoTransferDeclined  Action = "repo_transfer_declined"
--	ActionRepoTransferCanceled   Action = "repo_transfer_canceled"
++	ActionRepoTransferCanceled  Action = "repo_transfer_canceled"
--	ActionRepoTransferExpired    Action = "repo_transfer_expired"
++	ActionRepoTransferExpired   Action = "repo_transfer_expired"
--	ActionIssueStateChanged      Action = "issue_state_changed"
++	ActionIssueStateChanged     Action = "issue_state_changed"
--	ActionIssueLockChanged       Action = "issue_lock_changed"
++	ActionIssueLockChanged      Action = "issue_lock_changed"
--	ActionIssueCommentCreated    Action = "issue_comment_created"
++	ActionIssueCommentCreated   Action = "issue_comment_created"
--	ActionPullStateChanged       Action = "pull_state_changed"
++	ActionPullStateChanged      Action = "pull_state_changed"
--	ActionPullMerged             Action = "pull_merged"
++	ActionPullMerged            Action = "pull_merged"
--	ActionStarCreated            Action = "star_created"
++	ActionStarCreated           Action = "star_created"
--	ActionStarDeleted            Action = "star_deleted"
++	ActionStarDeleted           Action = "star_deleted"
--	ActionWatchSet               Action = "watch_set"
++	ActionWatchSet              Action = "watch_set"
--	ActionWatchUnset             Action = "watch_unset"
++	ActionWatchUnset            Action = "watch_unset"
--	ActionRepoForked             Action = "repo_forked"
++	ActionRepoForked            Action = "repo_forked"
--	ActionRepoForkSynced         Action = "repo_fork_synced"
++	ActionRepoForkSynced        Action = "repo_fork_synced"
+ )
  // Target is a typed target-type constant.

internal/auth/policy/adapters.gomodified

`@@ -25,4 +25,3 @@` func NewRepoRefFromRepo(r reposdb.Repo) RepoRef {
25	}	25	}
26	return ref	26	return ref
27	}	27	}
28	-

internal/auth/policy/policy_test.gomodified

  }
  const (
--	ownerID  int64 = 100
++	ownerID int64 = 100
--	otherID  int64 = 200
++	otherID int64 = 200
--	repoIDV  int64 = 1000
++	repoIDV int64 = 1000
  )
  func makeActor(k actorKind) policy.Actor {
  	}
  }
--
  // TestPermissionsDoc_CoversEveryAction guards against drift between
  // the policy package and docs/internal/permissions.md. The doc's
  // "Action → minimum role" table must mention every Action constant

internal/auth/reserved.gomodified


 	"shithubd":      {},
 	"shithubbot":    {},
 	// S29 — notification subscribe/unsubscribe per thread.
+	"threads": {},
 	// S30 — invitation accept/decline.
+	"invitations": {},
 }
 
 // IsReserved reports whether name is on the reserved list. The check is

internal/checks/checks.gomodified

  // Errors surfaced to API + handlers.
  var (
--	ErrEmptyName              = errors.New("checks: name is required")
++	ErrEmptyName                = errors.New("checks: name is required")
--	ErrNameTooLong            = errors.New("checks: name too long (max 200)")
++	ErrNameTooLong              = errors.New("checks: name too long (max 200)")
--	ErrInvalidStatus          = errors.New("checks: status must be queued, in_progress, completed, or pending")
++	ErrInvalidStatus            = errors.New("checks: status must be queued, in_progress, completed, or pending")
--	ErrInvalidConclusion      = errors.New("checks: invalid conclusion")
++	ErrInvalidConclusion        = errors.New("checks: invalid conclusion")
  	ErrCompletedNeedsConclusion = errors.New("checks: completed status requires conclusion")
--	ErrOutputTextTooLarge     = errors.New("checks: output.text exceeds 256 KiB cap")
++	ErrOutputTextTooLarge       = errors.New("checks: output.text exceeds 256 KiB cap")
--	ErrOutputSummaryTooLarge  = errors.New("checks: output.summary exceeds 64 KiB cap")
++	ErrOutputSummaryTooLarge    = errors.New("checks: output.summary exceeds 64 KiB cap")
--	ErrShortHeadSHA           = errors.New("checks: head_sha must be at least 7 hex chars")
++	ErrShortHeadSHA             = errors.New("checks: head_sha must be at least 7 hex chars")
--	ErrCheckRunNotFound       = errors.New("checks: run not found")
++	ErrCheckRunNotFound         = errors.New("checks: run not found")
--	ErrSuiteNotFound          = errors.New("checks: suite not found")
++	ErrSuiteNotFound            = errors.New("checks: suite not found")
+ )
  // validStatus / validConclusion mirror the Postgres enums.

internal/checks/checks_test.gomodified

  		RepoID: f.repoID, HeadSHA: strings.Repeat("a", 40), Name: "lint",
  	})
  	if _, err := checks.Update(ctx, f.deps, checks.UpdateParams{
--		RunID:          run.ID,
++		RunID:     run.ID,
--		HasStatus:      true, Status: "completed",
++		HasStatus: true, Status: "completed",
--		HasConclusion:  true, Conclusion: "success",
++		HasConclusion: true, Conclusion: "success",
--		HasStartedAt:   true, StartedAt: when,
++		HasStartedAt: true, StartedAt: when,
  		HasCompletedAt: true, CompletedAt: when.Add(30 * time.Second),
  	}); err != nil {
  		t.Fatalf("Update: %v", err)

internal/checks/create.gomodified

  	}()
  	suite, err := q.GetOrCreateCheckSuite(ctx, tx, checksdb.GetOrCreateCheckSuiteParams{
--		RepoID:   p.RepoID,
++		RepoID:  p.RepoID,
--		HeadSha:  p.HeadSHA,
++		HeadSha: p.HeadSHA,
--		AppSlug:  p.AppSlug,
++		AppSlug: p.AppSlug,
  	})
  	if err != nil {
  		return checksdb.CheckRun{}, fmt.Errorf("suite: %w", err)

internal/checks/required_eval.gomodified

  // GateInputs is the small struct the merge gate cares about.
  type GateInputs struct {
--	RepoID         int64
++	RepoID        int64
--	HeadSHA        string
++	HeadSHA       string
--	RequiredNames  []string // from branch_protection_rules.status_checks_required
++	RequiredNames []string // from branch_protection_rules.status_checks_required
+ }
  // GateResult mirrors the spec's blocked-with-reason vocabulary.
  type GateResult struct {
  	Satisfied bool
--	Reason    string  // "" when Satisfied; otherwise human-readable cause
++	Reason    string // "" when Satisfied; otherwise human-readable cause
  	// Missing is the subset of RequiredNames that haven't yet succeeded
  	// or returned neutral on HeadSHA. Populated for UI tooltips.
  	Missing []string

internal/checks/suite_rollup_test.gomodified

  func TestDeriveSuiteRollup(t *testing.T) {
  	t.Parallel()
  	cases := []struct {
--		name        string
++		name       string
--		runs        []checksdb.CheckRun
++		runs       []checksdb.CheckRun
--		wantStatus  string
++		wantStatus string
--		wantConcl   string
++		wantConcl  string
  	}{
+ 		{
  			"empty → queued",

internal/git/protocol/ssh_dispatch_test.gomodified

  func TestDispatch_SuspendedUserSuspended(t *testing.T) {
  	t.Parallel()
  	env := setupDispatch(t)
--	if _, err := env.pool.Exec(context.Background(),
++	if _, err := env.pool.Exec(
++		context.Background(),
  		"UPDATE users SET suspended_at = now(), suspended_reason = 'test' WHERE id = $1",
  		env.alice,
  	); err != nil {

internal/issues/notif_emit.gomodified

  // which is the safe default for the public-feed flag on the event row.
  func repoVisibilityPublic(ctx context.Context, db pgxRow, repoID int64) (bool, error) {
  	var vis string
--	err := db.QueryRow(ctx,
++	err := db.QueryRow(
++		ctx,
  		`SELECT visibility::text FROM repos WHERE id = $1`,
  		repoID,
  	).Scan(&vis)

internal/issues/references.gomodified

  // Two patterns:
  //
--//   #N            — same-repo reference. Captured digits.
++//	#N            — same-repo reference. Captured digits.
--//   owner/repo#N  — cross-repo reference. Captured owner, repo, digits.
++//	owner/repo#N  — cross-repo reference. Captured owner, repo, digits.
  //
  // Word-boundary on the leading side so we don't grab "abc#1". The N is
  // limited to 1–9 leading digit + arbitrary digits, capped at 9 total to
  			pKind string
  			pID   int64
  		)
--		err = tx.QueryRow(ctx,
++		err = tx.QueryRow(
++			ctx,
  			`SELECT kind::text, id FROM principals WHERE slug = $1`,
  			strings.ToLower(owner),
  		).Scan(&pKind, &pID)
  	return nil
  }
--

internal/issues/references_test.gomodified

`@@ -67,4 +67,3 @@` func TestCrossRepoRefRegex(t *testing.T) {
67	t.Errorf("got %v, want %v", got, want)	67	t.Errorf("got %v, want %v", got, want)
68	}	68	}
69	}	69	}
70	-

internal/markdown/extensions/emoji.gomodified

  // the rendered output.
  var emojiMap = map[string]string{
  	// Common reactions
--	"+1":              "👍",
++	"+1":                     "👍",
--	"-1":              "👎",
++	"-1":                     "👎",
--	"thumbsup":        "👍",
++	"thumbsup":               "👍",
--	"thumbsdown":      "👎",
++	"thumbsdown":             "👎",
--	"smile":           "😄",
++	"smile":                  "😄",
--	"laughing":        "😆",
++	"laughing":               "😆",
--	"joy":             "😂",
++	"joy":                    "😂",
--	"heart":           "❤️",
++	"heart":                  "❤️",
--	"heart_eyes":      "😍",
++	"heart_eyes":             "😍",
--	"tada":            "🎉",
++	"tada":                   "🎉",
--	"rocket":          "🚀",
++	"rocket":                 "🚀",
--	"fire":            "🔥",
++	"fire":                   "🔥",
--	"sparkles":        "✨",
++	"sparkles":               "✨",
--	"eyes":            "👀",
++	"eyes":                   "👀",
--	"thinking":        "🤔",
++	"thinking":               "🤔",
--	"thinking_face":   "🤔",
++	"thinking_face":          "🤔",
--	"wave":            "👋",
++	"wave":                   "👋",
--	"clap":            "👏",
++	"clap":                   "👏",
--	"pray":            "🙏",
++	"pray":                   "🙏",
--	"100":             "💯",
++	"100":                    "💯",
--	"check":           "✅",
++	"check":                  "✅",
--	"x":               "❌",
++	"x":                      "❌",
--	"warning":         "⚠️",
++	"warning":                "⚠️",
--	"bug":             "🐛",
++	"bug":                    "🐛",
--	"sparkle":         "✨",
++	"sparkle":                "✨",
--	"star":            "⭐",
++	"star":                   "⭐",
--	"hammer":          "🔨",
++	"hammer":                 "🔨",
--	"wrench":          "🔧",
++	"wrench":                 "🔧",
--	"package":         "📦",
++	"package":                "📦",
--	"books":           "📚",
++	"books":                  "📚",
--	"book":            "📖",
++	"book":                   "📖",
--	"memo":            "📝",
++	"memo":                   "📝",
--	"pencil":          "✏️",
++	"pencil":                 "✏️",
--	"shipit":          "🚢",
++	"shipit":                 "🚢",
--	"ship":            "🚢",
++	"ship":                   "🚢",
--	"lock":            "🔒",
++	"lock":                   "🔒",
--	"unlock":          "🔓",
++	"unlock":                 "🔓",
--	"key":             "🔑",
++	"key":                    "🔑",
--	"link":            "🔗",
++	"link":                   "🔗",
--	"speech_balloon":  "💬",
++	"speech_balloon":         "💬",
--	"thought_balloon": "💭",
++	"thought_balloon":        "💭",
--	"computer":        "💻",
++	"computer":               "💻",
--	"keyboard":        "⌨️",
++	"keyboard":               "⌨️",
--	"floppy_disk":     "💾",
++	"floppy_disk":            "💾",
--	"cd":              "💿",
++	"cd":                     "💿",
--	"dvd":             "📀",
++	"dvd":                    "📀",
--	"clipboard":       "📋",
++	"clipboard":              "📋",
--	"chart":           "📈",
++	"chart":                  "📈",
--	"bar_chart":       "📊",
++	"bar_chart":              "📊",
--	"calendar":        "📅",
++	"calendar":               "📅",
--	"date":            "📆",
++	"date":                   "📆",
--	"hourglass":       "⌛",
++	"hourglass":              "⌛",
--	"alarm_clock":     "⏰",
++	"alarm_clock":            "⏰",
--	"clock1":          "🕐",
++	"clock1":                 "🕐",
--	"bell":            "🔔",
++	"bell":                   "🔔",
--	"no_bell":         "🔕",
++	"no_bell":                "🔕",
--	"loudspeaker":     "📢",
++	"loudspeaker":            "📢",
--	"mega":            "📣",
++	"mega":                   "📣",
--	"mailbox":         "📫",
++	"mailbox":                "📫",
--	"envelope":        "✉️",
++	"envelope":               "✉️",
--	"postbox":         "📮",
++	"postbox":                "📮",
--	"package_2":       "📮",
++	"package_2":              "📮",
--	"mag":             "🔍",
++	"mag":                    "🔍",
--	"telescope":       "🔭",
++	"telescope":              "🔭",
--	"microscope":      "🔬",
++	"microscope":             "🔬",
--	"hammer_and_wrench": "🛠️",
++	"hammer_and_wrench":      "🛠️",
--	"gear":              "⚙️",
++	"gear":                   "⚙️",
--	"toolbox":           "🧰",
++	"toolbox":                "🧰",
--	"nut_and_bolt":      "🔩",
++	"nut_and_bolt":           "🔩",
--	"satellite":         "📡",
++	"satellite":              "📡",
--	"globe":             "🌍",
++	"globe":                  "🌍",
--	"earth_americas":    "🌎",
++	"earth_americas":         "🌎",
--	"earth_asia":        "🌏",
++	"earth_asia":             "🌏",
--	"new":               "🆕",
++	"new":                    "🆕",
--	"free":              "🆓",
++	"free":                   "🆓",
--	"abc":               "🔤",
++	"abc":                    "🔤",
--	"abcd":              "🔡",
++	"abcd":                   "🔡",
--	"capital_abcd":      "🔠",
++	"capital_abcd":           "🔠",
--	"information_source": "ℹ️",
++	"information_source":     "ℹ️",
--	"interrobang":        "⁉️",
++	"interrobang":            "⁉️",
--	"question":           "❓",
++	"question":               "❓",
--	"grey_question":      "❔",
++	"grey_question":          "❔",
--	"exclamation":        "❗",
++	"exclamation":            "❗",
--	"grey_exclamation":   "❕",
++	"grey_exclamation":       "❕",
--	"o":                  "⭕",
++	"o":                      "⭕",
--	"x_circle":           "❌",
++	"x_circle":               "❌",
--	"white_check_mark":   "✅",
++	"white_check_mark":       "✅",
--	"ballot_box_with_check": "☑️",
++	"ballot_box_with_check":  "☑️",
--	"heavy_check_mark":      "✔️",
++	"heavy_check_mark":       "✔️",
  	"heavy_multiplication_x": "✖️",
  	"heavy_plus_sign":        "➕",
  	"heavy_minus_sign":       "➖",
  	"gem":                    "💎",
  	"art":                    "🎨",
  	"musical_note":           "🎵",
--	"musical_score":           "🎼",
++	"musical_score":          "🎼",
  	"sound":                  "🔊",
  	"mute":                   "🔇",
  	"video_camera":           "📹",

internal/markdown/extensions/extensions.gomodified

  //	#14               user mention: username
  //	#16               commit prefix
  //	#18               emoji name
--var reCombined = regexp.MustCompile(`` +
++var reCombined = regexp.MustCompile(
--	// cross-repo: alice/proj#3 — left boundary required so we don't
++	`` +
--	// chew into a preceding word.
++		// cross-repo: alice/proj#3 — left boundary required so we don't
--	`(?:^|[^\w/])([A-Za-z0-9][A-Za-z0-9._-]*)/([A-Za-z0-9][A-Za-z0-9._-]*)#([0-9]{1,9})\b` +
++		// chew into a preceding word.
--	// or same-repo: #3
++		`(?:^|[^\w/])([A-Za-z0-9][A-Za-z0-9._-]*)/([A-Za-z0-9][A-Za-z0-9._-]*)#([0-9]{1,9})\b` +
--	`|(?:^|[^\w/])#([0-9]{1,9})\b` +
++		// or same-repo: #3
--	// or team mention: @org/team — comes BEFORE @user so the
++		`|(?:^|[^\w/])#([0-9]{1,9})\b` +
--	// trailing `/team` doesn't get split off as text. Slug shape
++		// or team mention: @org/team — comes BEFORE @user so the
--	// matches users.username + teams.slug.
++		// trailing `/team` doesn't get split off as text. Slug shape
--	`|(?:^|[^\w])@([a-z0-9](?:[a-z0-9-]{0,37}[a-z0-9])?)/([a-z0-9](?:[a-z0-9._-]{0,48}[a-z0-9])?)\b` +
++		// matches users.username + teams.slug.
--	// or user mention: @alice
++		`|(?:^|[^\w])@([a-z0-9](?:[a-z0-9-]{0,37}[a-z0-9])?)/([a-z0-9](?:[a-z0-9._-]{0,48}[a-z0-9])?)\b` +
--	`|(?:^|[^\w])@([A-Za-z0-9][A-Za-z0-9_-]{0,38})\b` +
++		// or user mention: @alice
--	// or commit SHA: 7–40 lowercase hex
++		`|(?:^|[^\w])@([A-Za-z0-9][A-Za-z0-9_-]{0,38})\b` +
--	`|(?:^|[^\w/])([0-9a-f]{7,40})\b` +
++		// or commit SHA: 7–40 lowercase hex
--	// or emoji shortcode: :smile:
++		`|(?:^|[^\w/])([0-9a-f]{7,40})\b` +
--	`|:([a-z0-9_+\-]+):`,
++		// or emoji shortcode: :smile:
++		`|:([a-z0-9_+\-]+):`,
+ )
  // Extension is a goldmark.Extender that registers the AST transformer.
  		// content starts (excluding the regex-consumed boundary
  		// char, if any).
  		var (
--			isCrossRepo  = m[2] >= 0
++			isCrossRepo = m[2] >= 0
--			isSameRepo   = m[8] >= 0
++			isSameRepo  = m[8] >= 0
--			isTeamMen    = m[10] >= 0
++			isTeamMen   = m[10] >= 0
--			isMention    = m[14] >= 0
++			isMention   = m[14] >= 0
--			isCommit     = m[16] >= 0
++			isCommit    = m[16] >= 0
--			isEmoji      = m[18] >= 0
++			isEmoji     = m[18] >= 0
+ 		)
  		var contentStart int
  		switch {
+ 	}
  	return true
+ }
--

internal/markdown/markdown_test.gomodified

  func TestRender_AllowsSafeHTML(t *testing.T) {
  	t.Parallel()
  	cases := []struct {
--		name      string
++		name        string
--		src       string
++		src         string
  		mustContain []string
  	}{
+ 		{

internal/notif/email.gomodified

  // participating threads master toggle, default on").
  func emailPrefOn(ctx context.Context, pool *pgxpool.Pool, userID int64, key string) (bool, error) {
  	var raw json.RawMessage
--	err := pool.QueryRow(ctx,
++	err := pool.QueryRow(
++		ctx,
  		`SELECT value FROM user_notification_prefs WHERE user_id = $1 AND key = $2`,
  		userID, key,
  	).Scan(&raw)

internal/notif/emit.gomodified

  	RepoID      int64  // 0 → user-scoped event (NULL).
  	SourceKind  string // "issue", "pull", "repo", "user", …
  	SourceID    int64
--	Public      bool     // matches repo visibility (caller decides).
++	Public      bool    // matches repo visibility (caller decides).
--	Mentions    []int64  // resolved user-ids to fan out @-mentions to.
++	Mentions    []int64 // resolved user-ids to fan out @-mentions to.
  	Extra       map[string]any
+ }

internal/notif/fanout_test.gomodified

  	c.messages = append(c.messages, m)
  	return nil
+ }
++
  func (c *captureSender) count() int {
  	c.mu.Lock()
  	defer c.mu.Unlock()
  func TestUnsubscribe_HMACRoundtrip(t *testing.T) {
  	key := []byte("test-key-32-bytes-aaaaaaaaaaaaaa")
  	const (
--		uid  = int64(123)
++		uid   = int64(123)
--		tk   = "issue"
++		tk    = "issue"
--		tid  = int64(45)
++		tid   = int64(45)
--		bad  = "issues"
++		bad   = "issues"
  		other = int64(46)
+ 	)
  	// Build by parsing the URL the same path the email-side uses.

internal/notif/notif.gomodified

  // Errors surfaced by the orchestrator.
  var (
--	ErrNotFound        = errors.New("notif: notification not found")
++	ErrNotFound       = errors.New("notif: notification not found")
--	ErrUnauthorized    = errors.New("notif: not your notification")
++	ErrUnauthorized   = errors.New("notif: not your notification")
--	ErrUnsubscribeBad  = errors.New("notif: invalid unsubscribe token")
++	ErrUnsubscribeBad = errors.New("notif: invalid unsubscribe token")
+ )
  // FanoutBatch is the per-tick cap on how many domain_events the
  // 10 minutes (the spec's day-1 lean). Per-recipient absolute cap
  // is 100 emails per hour.
  const (
--	StormPerThreadCap   = 1
++	StormPerThreadCap  = 1
--	StormPerThreadMins  = 10
++	StormPerThreadMins = 10
--	StormAbsoluteCap    = 100
++	StormAbsoluteCap   = 100
--	StormAbsoluteMins   = 60
++	StormAbsoluteMins  = 60
+ )

internal/notif/routing.gomodified

  	ReasonMention         Reason = "mention"
  	ReasonAssignment      Reason = "assignment"
  	ReasonReviewRequested Reason = "review_requested"
--	ReasonAuthor          Reason = "author"          // you opened the thread
++	ReasonAuthor          Reason = "author"     // you opened the thread
--	ReasonCommenter       Reason = "commenter"       // you commented earlier
++	ReasonCommenter       Reason = "commenter"  // you commented earlier
--	ReasonSubscribed      Reason = "subscribed"      // explicit thread sub
++	ReasonSubscribed      Reason = "subscribed" // explicit thread sub
--	ReasonWatching        Reason = "watching"        // repo-level watch
++	ReasonWatching        Reason = "watching"   // repo-level watch
  	ReasonRepoAdminAction Reason = "repo_admin_action"
+ )

internal/orgs/create.gomodified

  // CreateParams describes a create-org request.
  type CreateParams struct {
--	Slug             string
++	Slug            string
--	DisplayName      string
++	DisplayName     string
--	Description      string
++	Description     string
--	BillingEmail     string
++	BillingEmail    string
--	CreatedByUserID  int64
++	CreatedByUserID int64
+ }
  // slugRE mirrors the username pattern (lowercase letters, digits,
+ 	}
  	if err := q.AddOrgMember(ctx, tx, orgsdb.AddOrgMemberParams{
--		OrgID:            row.ID,
++		OrgID:           row.ID,
--		UserID:           p.CreatedByUserID,
++		UserID:          p.CreatedByUserID,
--		Role:             orgsdb.OrgRoleOwner,
++		Role:            orgsdb.OrgRoleOwner,
--		InvitedByUserID:  pgtype.Int8{Valid: false},
++		InvitedByUserID: pgtype.Int8{Valid: false},
  	}); err != nil {
  		return orgsdb.Org{}, fmt.Errorf("seed owner: %w", err)
+ 	}

internal/orgs/hard_delete.gomodified

  	// soft-delete). Refuse to restore if so — the operator can rename
  	// the conflicting principal and retry.
  	var taken bool
--	if err := deps.Pool.QueryRow(ctx,
++	if err := deps.Pool.QueryRow(
++		ctx,
  		`SELECT EXISTS(SELECT 1 FROM principals WHERE slug = $1)`,
  		row.Slug,
  	).Scan(&taken); err != nil {

internal/orgs/invitations.gomodified

  		return InviteResult{}, fmt.Errorf("invite token: %w", err)
+ 	}
  	row, err := q.CreateOrgInvitation(ctx, deps.Pool, orgsdb.CreateOrgInvitationParams{
--		OrgID:            p.OrgID,
++		OrgID:           p.OrgID,
--		InvitedByUserID:  pgtype.Int8{Int64: p.InvitedByUserID, Valid: true},
++		InvitedByUserID: pgtype.Int8{Int64: p.InvitedByUserID, Valid: true},
--		TargetUserID:     targetUserID,
++		TargetUserID:    targetUserID,
--		TargetEmail:      emailToCitext(targetEmail),
++		TargetEmail:     emailToCitext(targetEmail),
--		Role:             role,
++		Role:            role,
--		TokenHash:        tokHash,
++		TokenHash:       tokHash,
--		ExpiresAt:        pgtype.Timestamptz{Time: time.Now().Add(7 * 24 * time.Hour), Valid: true},
++		ExpiresAt:       pgtype.Timestamptz{Time: time.Now().Add(7 * 24 * time.Hour), Valid: true},
  	})
  	if err != nil {
  		return InviteResult{}, fmt.Errorf("create invitation: %w", err)

internal/pulls/merge.gomodified

`@@ -296,4 +296,3 @@` func fetchCommitsForLinkScan(ctx context.Context, db pullsdb.DBTX, prID int64) [
296	}	296	}
297	return out	297	return out
298	}	298	}
299	-

internal/pulls/pulls.gomodified

+ 	}
  	prRow, err := pullsdb.New().CreatePullRequest(ctx, deps.Pool, pullsdb.CreatePullRequestParams{
--		IssueID:     issueRow.ID,
++		IssueID:    issueRow.ID,
--		BaseRef:     base,
++		BaseRef:    base,
--		HeadRef:     head,
++		HeadRef:    head,
--		HeadRepoID:  p.RepoID,
++		HeadRepoID: p.RepoID,
--		BaseOid:     baseOID,
++		BaseOid:    baseOID,
--		HeadOid:     headOID,
++		HeadOid:    headOID,
--		Draft:       p.Draft,
++		Draft:      p.Draft,
  	})
  	if err != nil {
  		return CreateResult{}, fmt.Errorf("create pull_request: %w", err)

internal/pulls/review/request.gomodified

  	issue, ierr := issuesdb.New().GetIssueByID(ctx, deps.Pool, p.PRIssueID)
  	if ierr == nil {
  		var public bool
--		_ = deps.Pool.QueryRow(ctx,
++		_ = deps.Pool.QueryRow(
++			ctx,
  			`SELECT visibility = 'public' FROM repos WHERE id = $1`,
  			issue.RepoID,
  		).Scan(&public)

internal/pulls/review/review_test.gomodified

+ }
  type fx struct {
--	pool        *pgxpool.Pool
++	pool       *pgxpool.Pool
--	pullsDeps   pulls.Deps
++	pullsDeps  pulls.Deps
--	reviewDeps  review.Deps
++	reviewDeps review.Deps
--	authorID    int64
++	authorID   int64
--	reviewerID  int64
++	reviewerID int64
--	otherID     int64
++	otherID    int64
--	repoID      int64
++	repoID     int64
--	gitDir      string
++	gitDir     string
+ }
  func setup(t *testing.T) fx {
  	logger := slog.New(slog.NewTextHandler(io.Discard, nil))
  	return fx{
--		pool: pool,
++		pool:       pool,
  		pullsDeps:  pulls.Deps{Pool: pool, Logger: logger},
  		reviewDeps: review.Deps{Pool: pool, Logger: logger},
  		authorID:   author.ID,

internal/pulls/review/submit.gomodified


 		return err
 	}
 	return q.DismissPRReview(ctx, deps.Pool, pullsdb.DismissPRReviewParams{
+		ID:                reviewID,
+		DismissedByUserID: pgtype.Int8{Int64: actorUserID, Valid: actorUserID != 0},
+		DismissalReason:   strings.TrimSpace(reason),
 	})
 }

internal/repos/diff/parse/parse.gomodified

  // Line is one rendered row in a hunk.
  type Line struct {
--	Kind        LineKind
++	Kind      LineKind
--	OldLineNo   int    // 0 when the line is a pure addition
++	OldLineNo int    // 0 when the line is a pure addition
--	NewLineNo   int    // 0 when the line is a pure deletion
++	NewLineNo int    // 0 when the line is a pure deletion
--	Content     string // without the leading +/-/space marker, no trailing newline
++	Content   string // without the leading +/-/space marker, no trailing newline
+ }
  // Parse consumes a unified diff stream into the typed shape. The

internal/repos/diff/render/render.gomodified

  		for _, l := range h.Lines {
  			old, neu := lineNoCells(l)
  			content := highlightOrEscape(f.NewPath, l.Content, opts)
--			fmt.Fprintf(&buf,
++			fmt.Fprintf(
++				&buf,
  				`<tr class="%s"><td class="shithub-diff-lineno">%s</td><td class="shithub-diff-lineno">%s</td><td class="shithub-diff-content"><pre>%s%s</pre></td></tr>`,
  				lineClass(l.Kind), old, neu, lineMarker(l.Kind), content,
  			)
  				rightNo = numStr(p.right.NewLineNo)
  				rightContent = lineMarker(p.right.Kind) + highlightOrEscape(f.NewPath, p.right.Content, opts)
  			}
--			fmt.Fprintf(&buf,
++			fmt.Fprintf(
++				&buf,
  				`<tr><td class="shithub-diff-lineno %s">%s</td><td class="shithub-diff-content %s"><pre>%s</pre></td><td class="shithub-diff-lineno %s">%s</td><td class="shithub-diff-content %s"><pre>%s</pre></td></tr>`,
  				leftClass, leftNo, leftClass, leftContent,
  				rightClass, rightNo, rightClass, rightContent,

internal/repos/diff/source/source.gomodified

  // root commit (no parent) we diff against the empty tree by using
  // `git diff-tree -p -r --root`.
  func FromCommit(ctx context.Context, gitDir, sha string, opts Options) ([]byte, error) {
--	args := []string{"-C", gitDir,
++	args := []string{
++		"-C", gitDir,
  		"diff-tree", "-p", "-r", "--root",
  		"--no-color", "--no-ext-diff",
  		"--full-index",
  // FromRange returns the two-dot diff base..head. Use for "show me
  // every change between these two refs", regardless of merge graph.
  func FromRange(ctx context.Context, gitDir, base, head string, opts Options) ([]byte, error) {
--	args := []string{"-C", gitDir,
++	args := []string{
++		"-C", gitDir,
  		"diff", "--patch",
  		"--no-color", "--no-ext-diff",
  		"--full-index",
  // `git diff $(git merge-base base head)..head`. Used by PR / compare
  // pages — shows only what `head` adds over the common ancestor.
  func FromMergeBase(ctx context.Context, gitDir, base, head string, opts Options) ([]byte, error) {
--	args := []string{"-C", gitDir,
++	args := []string{
++		"-C", gitDir,
  		"diff", "--patch",
  		"--no-color", "--no-ext-diff",
  		"--full-index",

internal/repos/fork/fork.gomodified

  // Errors surfaced to handlers.
  var (
--	ErrNotLoggedIn          = errors.New("fork: login required")
++	ErrNotLoggedIn         = errors.New("fork: login required")
--	ErrSourceNotFound       = errors.New("fork: source repo not found")
++	ErrSourceNotFound      = errors.New("fork: source repo not found")
--	ErrSourceNotVisible     = errors.New("fork: source repo not visible to actor")
++	ErrSourceNotVisible    = errors.New("fork: source repo not visible to actor")
--	ErrTargetNameTaken      = errors.New("fork: target name already exists for owner")
++	ErrTargetNameTaken     = errors.New("fork: target name already exists for owner")
--	ErrVisibilityFloor      = errors.New("fork: target visibility cannot exceed source visibility")
++	ErrVisibilityFloor     = errors.New("fork: target visibility cannot exceed source visibility")
--	ErrSelfForkSameName     = errors.New("fork: forking into the same owner requires a different name")
++	ErrSelfForkSameName    = errors.New("fork: forking into the same owner requires a different name")
--	ErrSourceArchived       = errors.New("fork: source repo is archived")
++	ErrSourceArchived      = errors.New("fork: source repo is archived")
--	ErrSourceDeleted        = errors.New("fork: source repo is deleted")
++	ErrSourceDeleted       = errors.New("fork: source repo is deleted")
--	ErrSyncDiverged         = errors.New("fork: fork has diverged from upstream; sync via your client")
++	ErrSyncDiverged        = errors.New("fork: fork has diverged from upstream; sync via your client")
--	ErrSyncUpToDate         = errors.New("fork: already up to date")
++	ErrSyncUpToDate        = errors.New("fork: already up to date")
--	ErrSyncDefaultsMissing  = errors.New("fork: source or fork default branch is empty")
++	ErrSyncDefaultsMissing = errors.New("fork: source or fork default branch is empty")
--	ErrSyncRefRaced         = errors.New("fork: ref changed concurrently; retry")
++	ErrSyncRefRaced        = errors.New("fork: ref changed concurrently; retry")
--	ErrForkNotInitialized   = errors.New("fork: fork is still being prepared")
++	ErrForkNotInitialized  = errors.New("fork: fork is still being prepared")
+ )

internal/repos/git/branchops.gomodified

  	const sep = "\x1f"
  	const recordEnd = "\x1e"
  	format := strings.Join([]string{"%H", "%h", "%an", "%ae", "%at", "%s"}, sep) + sep + "%b" + recordEnd
--	cmd := exec.CommandContext(ctx, "git", "-C", gitDir,
++	cmd := exec.CommandContext(
++		ctx, "git", "-C", gitDir,
  		"log",
  		"--max-count="+strconv.Itoa(max),
  		"--format="+format,

internal/repos/git/logops.gomodified

  // arrive via `git log --format=...`; the per-file stats live on
  // CommitDetail.
  type Commit struct {
--	OID         string    // full 40-char SHA
++	OID         string // full 40-char SHA
--	ShortOID    string    // git's --abbrev result, typically 7 chars
++	ShortOID    string // git's --abbrev result, typically 7 chars
  	AuthorName  string
  	AuthorEmail string
  	AuthorWhen  time.Time
  	// don't confuse SplitN.
  	format := strings.Join([]string{"%H", "%h", "%an", "%ae", "%at", "%s"}, sep) + sep + "%b" + recordEnd
--	args := []string{"-C", gitDir, "log",
++	args := []string{
++		"-C", gitDir, "log",
  		"--max-count=" + strconv.Itoa(o.MaxCount),
  		"--skip=" + strconv.Itoa(o.Skip),
  		"--format=" + format,
  // Status is git's letter code: A added, M modified, D deleted, R renamed,
  // C copied, T type-changed.
  type FileChange struct {
--	Status   string
++	Status  string
--	Path     string
++	Path    string
--	OldPath  string // populated for R/C
++	OldPath string // populated for R/C
--	Insert   int
++	Insert  int
--	Delete   int
++	Delete  int
--	Binary   bool
++	Binary  bool
+ }
  // GetCommit returns the full detail for one SHA. Two commands: one for

internal/repos/git/mergeops.gomodified

  		"%cn", "%ce", "%ct",
  		"%s",
  	}, sep) + sep + "%b" + recordEnd
--	cmd := exec.CommandContext(ctx, "git", "-C", gitDir,
++	cmd := exec.CommandContext(
++		ctx, "git", "-C", gitDir,
  		"log", "--reverse",
  		"--max-count="+strconv.Itoa(max),
  		"--format="+format,
  // changes from merge-base to head). Status is git's letter code,
  // renames carry the old path as the second column.
  func FilesChangedBetween(ctx context.Context, gitDir, baseOID, headOID string) ([]PRFileChange, error) {
--	cmd := exec.CommandContext(ctx, "git", "-C", gitDir,
++	cmd := exec.CommandContext(
++		ctx, "git", "-C", gitDir,
  		"diff", "--name-status", "-M", "-C",
  		baseOID+"..."+headOID,
  	)
  		}
  		return nil, wrapExecErr(err)
  	}
--	cmd = exec.CommandContext(ctx, "git", "-C", gitDir,
++	cmd = exec.CommandContext(
++		ctx, "git", "-C", gitDir,
  		"diff", "--numstat", "-M", "-C",
  		baseOID+"..."+headOID,
  	)
  	// Identity for the merge commit. `--no-edit` + a baked subject
  	// keeps the merge non-interactive.
--	envBase := append(os.Environ(),
++	envBase := append(
++		os.Environ(),
  		"GIT_AUTHOR_NAME="+opts.AuthorName,
  		"GIT_AUTHOR_EMAIL="+opts.AuthorEmail,
  		"GIT_COMMITTER_NAME="+opts.CommitterName,
  		"GIT_COMMITTER_EMAIL="+opts.CommitterEmail,
  	)
  	if !opts.When.IsZero() {
--		envBase = append(envBase,
++		envBase = append(
++			envBase,
  			"GIT_AUTHOR_DATE="+opts.When.Format(time.RFC3339),
  			"GIT_COMMITTER_DATE="+opts.When.Format(time.RFC3339),
  		)

internal/repos/git/plumbing.gomodified

  	//nolint:gosec // G204: tree is git's stdout (40-char OID); gitDir validated.
  	cmd := exec.CommandContext(ctx, "git", "-C", ic.GitDir, "commit-tree", tree, "-m", ic.Message)
  	stamp := ic.When.Format(time.RFC3339)
--	cmd.Env = append(os.Environ(),
++	cmd.Env = append(
++		os.Environ(),
  		"GIT_AUTHOR_NAME="+ic.AuthorName,
  		"GIT_AUTHOR_EMAIL="+ic.AuthorEmail,
  		"GIT_AUTHOR_DATE="+stamp,

internal/repos/lifecycle/hard_delete.gomodified

`@@ -118,4 +118,3 @@` func HardDelete(ctx context.Context, deps Deps, actorUserID, repoID int64) error
118	}	118	}
119	return nil	119	return nil
120	}	120	}
121	-

internal/repos/lifecycle/transfer.gomodified

  // TransferRequestParams describes a new transfer offer.
  type TransferRequestParams struct {
--	ActorUserID    int64
++	ActorUserID     int64
--	RepoID         int64
++	RepoID          int64
--	FromUserID     int64
++	FromUserID      int64
  	ToPrincipalKind string // "user" — "org" arrives in S31
--	ToPrincipalID  int64
++	ToPrincipalID   int64
+ }
  // RequestTransfer creates a pending transfer with a 7-day TTL. Returns
  	rq := reposdb.New()
  	row, err := rq.InsertTransferRequest(ctx, deps.Pool, reposdb.InsertTransferRequestParams{
--		RepoID:           p.RepoID,
++		RepoID:          p.RepoID,
--		FromUserID:       p.FromUserID,
++		FromUserID:      p.FromUserID,
--		ToPrincipalKind:  reposdb.TransferPrincipalKind(p.ToPrincipalKind),
++		ToPrincipalKind: reposdb.TransferPrincipalKind(p.ToPrincipalKind),
--		ToPrincipalID:    p.ToPrincipalID,
++		ToPrincipalID:   p.ToPrincipalID,
--		CreatedBy:        p.ActorUserID,
++		CreatedBy:       p.ActorUserID,
--		ExpiresAt:        pgtype.Timestamptz{Time: deps.now().Add(transferTTL), Valid: true},
++		ExpiresAt:       pgtype.Timestamptz{Time: deps.now().Add(transferTTL), Valid: true},
  	})
  	if err != nil {
  		return 0, fmt.Errorf("insert transfer: %w", err)
  	// Update owner. We keep the same name; if it collides on the
  	// recipient, the unique index trips and the tx rolls back.
  	if err := rq.TransferRepoOwner(ctx, tx, reposdb.TransferRepoOwnerParams{
--		ID:           repo.ID,
++		ID:          repo.ID,
--		Name:         repo.Name,
++		Name:        repo.Name,
--		OwnerUserID:  pgtype.Int8{Int64: actorUserID, Valid: true},
++		OwnerUserID: pgtype.Int8{Int64: actorUserID, Valid: true},
--		OwnerOrgID:   pgtype.Int8{Valid: false},
++		OwnerOrgID:  pgtype.Int8{Valid: false},
  	}); err != nil {
  		var pgErr *pgconn.PgError
  		if errAs(err, &pgErr) && pgErr.Code == "23505" {

internal/repos/protection/protection.gomodified


 // the rule set. Allow=true means the push proceeds; Allow=false
 // surfaces the reason+rule pattern back to the user via stderr.
 type Decision struct {
+	Allow   bool
+	Reason  string
+	RuleID  int64
+	Pattern string
 }
 
 // Update is one ref update from the pre-receive hook's stdin.

 	}
 	return fmt.Sprintf("shithub: %s (rule pattern %q).", d.Reason, d.Pattern)
 }


internal/search/query_parse.gomodified

  // to take effect (a bare `repo:foo` without slash is treated as
  // free text).
  type ParsedQuery struct {
--	Text         string  // free-text query (what tsvector matches against)
++	Text         string // free-text query (what tsvector matches against)
--	Phrase       string  // when a quoted phrase was supplied; empty when not
++	Phrase       string // when a quoted phrase was supplied; empty when not
  	RepoFilter   *RepoFilter
  	StateFilter  string // "open" | "closed" | ""
  	AuthorFilter string // username or empty

internal/search/search_test.gomodified

  		{"", search.ParsedQuery{}},
  		{"hello world", search.ParsedQuery{Text: "hello world"}},
  		{`"quoted phrase"`, search.ParsedQuery{Phrase: "quoted phrase"}},
--		{"repo:alice/demo bug", search.ParsedQuery{Text: "bug",
++		{"repo:alice/demo bug", search.ParsedQuery{
--			RepoFilter: &search.RepoFilter{Owner: "alice", Name: "demo"}}},
++			Text:       "bug",
++			RepoFilter: &search.RepoFilter{Owner: "alice", Name: "demo"},
++		}},
  		{"repo:noslash bug", search.ParsedQuery{Text: "repo:noslash bug"}},
  		{"is:open broken", search.ParsedQuery{Text: "broken", StateFilter: "open"}},
  		{"state:closed bug", search.ParsedQuery{Text: "bug", StateFilter: "closed"}},

internal/social/social.gomodified

  // Errors surfaced to handlers.
  var (
--	ErrNotLoggedIn      = errors.New("social: login required")
++	ErrNotLoggedIn       = errors.New("social: login required")
  	ErrInvalidWatchLevel = errors.New("social: watch level must be all, participating, or ignore")
--	ErrStarRateLimit    = errors.New("social: star/unstar rate limit exceeded")
++	ErrStarRateLimit     = errors.New("social: star/unstar rate limit exceeded")
+ )

internal/web/handlers/api/checks.gomodified

  func presentSuite(s checksdb.CheckSuite) map[string]any {
  	out := map[string]any{
--		"id":        s.ID,
++		"id":       s.ID,
--		"head_sha":  s.HeadSha,
++		"head_sha": s.HeadSha,
--		"app_slug":  s.AppSlug,
++		"app_slug": s.AppSlug,
--		"status":    string(s.Status),
++		"status":   string(s.Status),
+ 	}
  	if s.Conclusion.Valid {
  		out["conclusion"] = string(s.Conclusion.CheckConclusion)

internal/web/handlers/api/stars.gomodified

`@@ -141,4 +141,3 @@` func pgTextString(t pgtype.Text) any {
141	}	141	}
142	return t.String	142	return t.String
143	}	143	}
144	-

internal/web/handlers/auth/auth_test.gomodified

  			epoch       int32
  			suspendedAt sql.NullTime
  		)
--		err = u.QueryRow(ctx,
++		err = u.QueryRow(
++			ctx,
  			"SELECT username, session_epoch, suspended_at FROM users WHERE id = $1", id,
  		).Scan(&name, &epoch, &suspendedAt)
  		return middleware.UserLookupResult{

internal/web/handlers/auth/avatar.gomodified

  		if v.Size == variants[0].Size {
  			key = largestKey
  		}
--		if _, err := h.d.ObjectStore.Put(r.Context(), key,
++		if _, err := h.d.ObjectStore.Put(
++			r.Context(), key,
  			bytes.NewReader(v.Data),
  			storage.PutOpts{ContentType: "image/png", ContentLength: int64(len(v.Data))},
  		); err != nil {

internal/web/handlers/auth/danger_test.gomodified

  	// be treated as nonexistent. Uses the SAME pool the test server is
  	// reading from — a fresh dbtest.NewTestDB call would clone a brand
  	// new database.
--	if _, err := pool.Exec(context.Background(),
++	if _, err := pool.Exec(
++		context.Background(),
  		"UPDATE users SET deleted_at = $1 WHERE username = 'dangb'",
  		time.Now().Add(-30*24*time.Hour),
  	); err != nil {

internal/web/handlers/auth/tokens_test.gomodified

  			epoch       int32
  			suspendedAt sql.NullTime
  		)
--		err = c.QueryRow(ctx,
++		err = c.QueryRow(
++			ctx,
  			"SELECT username, session_epoch, suspended_at FROM users WHERE id = $1", id,
  		).Scan(&name, &epoch, &suspendedAt)
  		return middleware.UserLookupResult{

internal/web/handlers/orgs/orgs.gomodified

  // Package orgs wires the S30 organization web surface:
  //
--//   GET  /organizations/new            create form
++//	GET  /organizations/new            create form
--//   POST /organizations                create submit
++//	POST /organizations                create submit
--//   GET  /{org}/people                 members + pending invites + invite form
++//	GET  /{org}/people                 members + pending invites + invite form
--//   POST /{org}/people/invite          invite by username or email
++//	POST /{org}/people/invite          invite by username or email
--//   POST /{org}/people/{user}/role     change role
++//	POST /{org}/people/{user}/role     change role
--//   POST /{org}/people/{user}/remove   remove member
++//	POST /{org}/people/{user}/remove   remove member
--//   GET  /invitations/{token}          accept/decline view
++//	GET  /invitations/{token}          accept/decline view
--//   POST /invitations/{token}/accept   accept
++//	POST /invitations/{token}/accept   accept
--//   POST /invitations/{token}/decline  decline
++//	POST /invitations/{token}/decline  decline
  //
  // Profile rendering for /{org} is dispatched from the existing
  // /{username} catch-all in internal/web/handlers/profile via the

internal/web/handlers/orgs/teams.gomodified

  func (h *Handlers) userIDByUsername(r *http.Request, username string) (int64, bool) {
  	var id int64
--	err := h.d.Pool.QueryRow(r.Context(),
++	err := h.d.Pool.QueryRow(
++		r.Context(),
  		`SELECT id FROM users WHERE username = $1 AND deleted_at IS NULL`,
  		username,
  	).Scan(&id)
  		return false
  	}
  	var member bool
--	_ = h.d.Pool.QueryRow(r.Context(),
++	_ = h.d.Pool.QueryRow(
++		r.Context(),
  		`SELECT EXISTS(SELECT 1 FROM team_members WHERE team_id = $1 AND user_id = $2)`,
  		team.ID, viewer.ID,
  	).Scan(&member)
  			continue
  		}
  		var member bool
--		err := h.d.Pool.QueryRow(r.Context(),
++		err := h.d.Pool.QueryRow(
++			r.Context(),
  			`SELECT EXISTS(SELECT 1 FROM team_members WHERE team_id = $1 AND user_id = $2)`,
  			t.ID, viewer.ID,
  		).Scan(&member)
  // errTeamNotFound is reserved for the future; surfaced via
  // orgs.ErrTeamNotFound when needed.
--var _ = errors.New
++var _ = errors.New

internal/web/handlers/repo/branches.gomodified

  	refs, _ := repogit.ListRefs(r.Context(), gitDir)
  	type tagRow struct {
--		Name        string
++		Name       string
--		OID         string
++		OID        string
--		ShortOID    string
++		ShortOID   string
--		Subject     string
++		Subject    string
--		AuthorName  string
++		AuthorName string
--		AuthorWhen  time.Time
++		AuthorWhen time.Time
+ 	}
  	rows := make([]tagRow, 0, len(refs.Tags))
  	for _, t := range refs.Tags {
  	refs, _ := repogit.ListRefs(r.Context(), gitDir)
  	h.d.Render.RenderPage(w, r, "repo/compare", map[string]any{
--		"Title":     "Compare · " + row.Name,
++		"Title":      "Compare · " + row.Name,
--		"CSRFToken": middleware.CSRFTokenForRequest(r),
++		"CSRFToken":  middleware.CSRFTokenForRequest(r),
--		"Owner":     owner.Username,
++		"Owner":      owner.Username,
--		"Repo":      row,
++		"Repo":       row,
--		"Base":      base,
++		"Base":       base,
--		"Head":      head,
++		"Head":       head,
--		"Ahead":     ahead,
++		"Ahead":      ahead,
--		"Behind":    behind,
++		"Behind":     behind,
--		"Commits":   commits,
++		"Commits":    commits,
--		"DiffHTML":  diffHTML,
++		"DiffHTML":   diffHTML,
--		"NotFound":  notFound,
++		"NotFound":   notFound,
  		"CommitsErr": cerr != nil,
--		"Branches":  refs.Branches,
++		"Branches":   refs.Branches,
--		"Tags":      refs.Tags,
++		"Tags":       refs.Tags,
  	})
+ }

internal/web/handlers/repo/code.gomodified

  	"github.com/jackc/pgx/v5/pgtype"
  	"github.com/tenseleyFlow/shithub/internal/auth/policy"
++	mdrender "github.com/tenseleyFlow/shithub/internal/markdown"
  	"github.com/tenseleyFlow/shithub/internal/repos/finder"
  	repogit "github.com/tenseleyFlow/shithub/internal/repos/git"
  	"github.com/tenseleyFlow/shithub/internal/repos/highlight"
--	mdrender "github.com/tenseleyFlow/shithub/internal/markdown"
  	reposdb "github.com/tenseleyFlow/shithub/internal/repos/sqlc"
  	"github.com/tenseleyFlow/shithub/internal/web/middleware"
+ )
  // derive once at the top. Owner+repo come from chi; ref+path come from
  // the wildcard, resolved against the repo's ref list.
  type codeContext struct {
--	owner    string
++	owner   string
--	row      reposdb.Repo
++	row     reposdb.Repo
--	gitDir   string
++	gitDir  string
--	refs     repogit.RefListing
++	refs    repogit.RefListing
--	allRefs  []string
++	allRefs []string
--	ref      string // matched ref name (or 40-hex sha)
++	ref     string // matched ref name (or 40-hex sha)
--	subpath  string // path inside the ref, no leading slash
++	subpath string // path inside the ref, no leading slash
+ }
  // loadCodeContext does the resolve dance for tree/blob/raw/find. On

internal/web/handlers/repo/fork.gomodified

  	}
  	// Enqueue the on-disk clone. The fork row exists with
  	// init_status='init_pending' so the URL resolves immediately.
--	if _, err := worker.Enqueue(r.Context(), h.d.Pool, worker.KindRepoForkClone,
++	if _, err := worker.Enqueue(
++		r.Context(), h.d.Pool, worker.KindRepoForkClone,
  		map[string]any{"source_repo_id": res.Source.ID, "fork_repo_id": res.Fork.ID},
  		worker.EnqueueOptions{},
  	); err != nil {
  		h.d.Render.HTTPError(w, r, http.StatusInternalServerError, "")
  	}
  }
--

internal/web/handlers/repo/issues.gomodified

  	// thread events to them. Non-destructive — no-op if the user
  	// already has an explicit preference.
  	_ = social.AutoWatchOnInvolvement(r.Context(), h.socialDeps(), viewer.ID, row.ID)
--	http.Redirect(w, r,
++	http.Redirect(
++		w, r,
  		"/"+owner.Username+"/"+row.Name+"/issues/"+strconv.FormatInt(created.Number, 10),
  		http.StatusSeeOther,
  	)

internal/web/handlers/repo/lifecycle.gomodified

  	"github.com/tenseleyFlow/shithub/internal/orgs"
  	"github.com/tenseleyFlow/shithub/internal/repos/lifecycle"
  	reposdb "github.com/tenseleyFlow/shithub/internal/repos/sqlc"
--	"github.com/tenseleyFlow/shithub/internal/web/middleware"
  	usersdb "github.com/tenseleyFlow/shithub/internal/users/sqlc"
++	"github.com/tenseleyFlow/shithub/internal/web/middleware"
  )
  // MountLifecycle registers the repo settings danger-zone routes plus
  		return reposdb.Repo{}, usersdb.User{}, false
  	}
  	var (
--		row    reposdb.Repo
++		row   reposdb.Repo
--		owner  usersdb.User
++		owner usersdb.User
  	)
  	switch principal.Kind {
  	case orgs.PrincipalUser:

internal/web/handlers/repo/pulls.gomodified

  	checksdb "github.com/tenseleyFlow/shithub/internal/checks/sqlc"
  	"github.com/tenseleyFlow/shithub/internal/issues"
  	issuesdb "github.com/tenseleyFlow/shithub/internal/issues/sqlc"
++	mdrender "github.com/tenseleyFlow/shithub/internal/markdown"
  	"github.com/tenseleyFlow/shithub/internal/pulls"
  	pullsdb "github.com/tenseleyFlow/shithub/internal/pulls/sqlc"
  	repogit "github.com/tenseleyFlow/shithub/internal/repos/git"
--	mdrender "github.com/tenseleyFlow/shithub/internal/markdown"
  	reposdb "github.com/tenseleyFlow/shithub/internal/repos/sqlc"
  	"github.com/tenseleyFlow/shithub/internal/social"
  	"github.com/tenseleyFlow/shithub/internal/web/middleware"
  		h.d.Logger.WarnContext(r.Context(), "pulls: enqueue mergeability", "error", err)
  	}
  	_ = worker.Notify(r.Context(), h.d.Pool)
--	http.Redirect(w, r,
++	http.Redirect(
++		w, r,
  		"/"+owner.Username+"/"+row.Name+"/pulls/"+strconv.FormatInt(res.Issue.Number, 10),
  		http.StatusSeeOther,
  	)
  		threadsByFile[f.Path] = out
  	}
  	h.renderPullPage(w, r, "files", map[string]any{
--		"Files":          files,
++		"Files":         files,
--		"DiffHTML":       diffHTML,
++		"DiffHTML":      diffHTML,
--		"ThreadsByFile":  threadsByFile,
++		"ThreadsByFile": threadsByFile,
  	})
  }
  		return
  	}
  	type runRow struct {
--		R              checksdb.CheckRun
++		R           checksdb.CheckRun
--		SummaryHTML    template.HTML
++		SummaryHTML template.HTML
--		AppSlug        string
++		AppSlug     string
  	}
  	type suiteGroup struct {
  		Suite checksdb.CheckSuite

internal/web/handlers/repo/repo.gomodified

  	"errors"
  	"log/slog"
  	"net/http"
--	"strings"
--
  	"strconv"
++	"strings"
  	"github.com/go-chi/chi/v5"
  	"github.com/jackc/pgx/v5"
  	"github.com/tenseleyFlow/shithub/internal/auth/policy"
  	"github.com/tenseleyFlow/shithub/internal/auth/secretbox"
  	"github.com/tenseleyFlow/shithub/internal/auth/throttle"
--	"github.com/tenseleyFlow/shithub/internal/infra/storage"
  	checksdb "github.com/tenseleyFlow/shithub/internal/checks/sqlc"
++	"github.com/tenseleyFlow/shithub/internal/infra/storage"
  	issuesdb "github.com/tenseleyFlow/shithub/internal/issues/sqlc"
  	"github.com/tenseleyFlow/shithub/internal/orgs"
  	orgsdb "github.com/tenseleyFlow/shithub/internal/orgs/sqlc"
  func (h *Handlers) cloneHTTPS(owner, name string) string {
  	return h.d.CloneURLs.BaseURL + "/" + owner + "/" + name + ".git"
  }
++
  func (h *Handlers) cloneSSH(owner, name string) string {
  	return h.d.CloneURLs.SSHHost + ":" + owner + "/" + name + ".git"
  }

internal/web/handlers/repo/settings_branches.gomodified

  	if idStr == "" {
  		// Create.
  		newID, err := h.rq.UpsertBranchProtectionRule(r.Context(), h.d.Pool, reposdb.UpsertBranchProtectionRuleParams{
--			RepoID:                row.ID,
++			RepoID:               row.ID,
--			Pattern:               pattern,
++			Pattern:              pattern,
--			PreventForcePush:      preventForcePush,
++			PreventForcePush:     preventForcePush,
--			PreventDeletion:       preventDeletion,
++			PreventDeletion:      preventDeletion,
--			RequirePrForPush:      requirePR,
++			RequirePrForPush:     requirePR,
--			AllowedPusherUserIds:  allowed,
++			AllowedPusherUserIds: allowed,
--			CreatedByUserID:       pgtype.Int8{Int64: viewer.ID, Valid: viewer.ID != 0},
++			CreatedByUserID:      pgtype.Int8{Int64: viewer.ID, Valid: viewer.ID != 0},
  		})
  		if err != nil {
  			h.d.Logger.WarnContext(r.Context(), "branch-protection: insert", "error", err)
  			return
+ 		}
  		if err := h.rq.UpdateBranchProtectionReviewSettings(r.Context(), h.d.Pool, reposdb.UpdateBranchProtectionReviewSettingsParams{
--			ID:                          newID,
++			ID:                        newID,
--			RequiredReviewCount:         int32(requiredReviews),
++			RequiredReviewCount:       int32(requiredReviews),
--			DismissStaleReviewsOnPush:   dismissStale,
++			DismissStaleReviewsOnPush: dismissStale,
--			RequireCodeOwnerReview:      false,
++			RequireCodeOwnerReview:    false,
  		}); err != nil {
  			h.d.Logger.WarnContext(r.Context(), "branch-protection: review settings", "error", err)
+ 		}
  		if err := h.rq.UpdateBranchProtectionCheckSettings(r.Context(), h.d.Pool, reposdb.UpdateBranchProtectionCheckSettingsParams{
--			ID:                              newID,
++			ID:                             newID,
--			StatusChecksRequired:            requiredChecks,
++			StatusChecksRequired:           requiredChecks,
--			DismissStaleStatusChecksOnPush:  dismissStaleChecks,
++			DismissStaleStatusChecksOnPush: dismissStaleChecks,
  		}); err != nil {
  			h.d.Logger.WarnContext(r.Context(), "branch-protection: check settings", "error", err)
+ 		}
  			return
+ 		}
  		if err := h.rq.UpdateBranchProtectionReviewSettings(r.Context(), h.d.Pool, reposdb.UpdateBranchProtectionReviewSettingsParams{
--			ID:                          id,
++			ID:                        id,
--			RequiredReviewCount:         int32(requiredReviews),
++			RequiredReviewCount:       int32(requiredReviews),
--			DismissStaleReviewsOnPush:   dismissStale,
++			DismissStaleReviewsOnPush: dismissStale,
--			RequireCodeOwnerReview:      false,
++			RequireCodeOwnerReview:    false,
  		}); err != nil {
  			h.d.Logger.WarnContext(r.Context(), "branch-protection: review settings", "error", err)
+ 		}
  		if err := h.rq.UpdateBranchProtectionCheckSettings(r.Context(), h.d.Pool, reposdb.UpdateBranchProtectionCheckSettingsParams{
--			ID:                              id,
++			ID:                             id,
--			StatusChecksRequired:            requiredChecks,
++			StatusChecksRequired:           requiredChecks,
--			DismissStaleStatusChecksOnPush:  dismissStaleChecks,
++			DismissStaleStatusChecksOnPush: dismissStaleChecks,
  		}); err != nil {
  			h.d.Logger.WarnContext(r.Context(), "branch-protection: check settings", "error", err)
+ 		}

internal/web/handlers/repo/webhooks.gomodified

  	"github.com/tenseleyFlow/shithub/internal/auth/audit"
  	"github.com/tenseleyFlow/shithub/internal/auth/policy"
++	"github.com/tenseleyFlow/shithub/internal/web/middleware"
  	"github.com/tenseleyFlow/shithub/internal/webhook"
  	webhookdb "github.com/tenseleyFlow/shithub/internal/webhook/sqlc"
--	"github.com/tenseleyFlow/shithub/internal/web/middleware"
  )
  // MountWebhooks registers the per-repo webhook CRUD + delivery views.

internal/webhook/deliver.gomodified

`@@ -374,4 +374,3 @@` func Redeliver(ctx context.Context, deps FanoutDeps, originalID int64) (int64, e
374	}	374	}
375	return row.ID, nil	375	return row.ID, nil
376	}	376	}
377	-

internal/webhook/fanout.gomodified

  	"github.com/jackc/pgx/v5/pgtype"
  	"github.com/jackc/pgx/v5/pgxpool"
--	"github.com/tenseleyFlow/shithub/internal/worker"
  	webhookdb "github.com/tenseleyFlow/shithub/internal/webhook/sqlc"
++	"github.com/tenseleyFlow/shithub/internal/worker"
+ )
  // FanoutConsumer is the consumer name in domain_events_processed.
+ 		}
  		idem := idempotencyKey(w.ID, ev.ID, body)
  		row, err := q.CreateDelivery(ctx, deps.Pool, webhookdb.CreateDeliveryParams{
--			WebhookID:       w.ID,
++			WebhookID:      w.ID,
--			EventKind:       ev.Kind,
++			EventKind:      ev.Kind,
--			EventID:         pgtype.Int8{Int64: ev.ID, Valid: true},
++			EventID:        pgtype.Int8{Int64: ev.ID, Valid: true},
--			Payload:         body,
++			Payload:        body,
--			RequestHeaders:  headersJSON,
++			RequestHeaders: headersJSON,
--			RequestBody:     body,
++			RequestBody:    body,
--			Attempt:         1,
++			Attempt:        1,
--			MaxAttempts:     8,
++			MaxAttempts:    8,
--			NextRetryAt:     pgtype.Timestamptz{Time: time.Now(), Valid: true},
++			NextRetryAt:    pgtype.Timestamptz{Time: time.Now(), Valid: true},
--			Status:          webhookdb.WebhookDeliveryStatusPending,
++			Status:         webhookdb.WebhookDeliveryStatusPending,
--			IdempotencyKey:  idem,
++			IdempotencyKey: idem,
--			RedeliverOf:     pgtype.Int8{Valid: false},
++			RedeliverOf:    pgtype.Int8{Valid: false},
  		})
  		if err != nil {
  			return fmt.Errorf("create delivery: %w", err)

internal/webhook/jobs.gomodified

  // Job kinds shipped by S33. Registered by cmd/shithubd/worker.go.
  const (
--	KindWebhookFanout    worker.Kind = "webhook:fanout"
++	KindWebhookFanout   worker.Kind = "webhook:fanout"
--	KindWebhookDeliver   worker.Kind = "webhook:deliver"
++	KindWebhookDeliver  worker.Kind = "webhook:deliver"
--	KindWebhookPurgeOld  worker.Kind = "webhook:purge_old"
++	KindWebhookPurgeOld worker.Kind = "webhook:purge_old"
+ )
  // deliverPayload is the schema for a `webhook:deliver` job. The

internal/webhook/manage.gomodified

  // CreateErrors surfaces user-friendly validation failures so handlers
  // can render them in-page.
  var (
--	ErrBadURL          = errors.New("webhook: URL must be http or https with a host")
++	ErrBadURL         = errors.New("webhook: URL must be http or https with a host")
--	ErrBadContentType  = errors.New("webhook: content_type must be json or form")
++	ErrBadContentType = errors.New("webhook: content_type must be json or form")
--	ErrBadOwnerKind    = errors.New("webhook: owner_kind must be repo or org")
++	ErrBadOwnerKind   = errors.New("webhook: owner_kind must be repo or org")
--	ErrBadEvent        = errors.New("webhook: event names must be 1–64 lowercase chars")
++	ErrBadEvent       = errors.New("webhook: event names must be 1–64 lowercase chars")
+ )
  // Create persists a new webhook + emits a synthetic ping delivery so

internal/webhook/ssrf_test.gomodified

  		"10.0.0.1", "10.255.255.255",
  		"172.16.0.1", "172.31.255.255",
  		"192.168.0.1",
--		"100.64.0.1",       // CGNAT
++		"100.64.0.1",      // CGNAT
  		"169.254.169.254", // AWS metadata service
  		"0.0.0.0",
  		"255.255.255.255",
  		"::1",
--		"fe80::1",        // link-local
++		"fe80::1", // link-local
--		"fd00::1",        // ULA
++		"fd00::1", // ULA
--		"fc00::1",        // ULA
++		"fc00::1", // ULA
+ 	}
  	for _, addr := range forbidden {
  		ip := net.ParseIP(addr)

internal/worker/jobs/push_process.gomodified

  	"errors"
  	"fmt"
  	"log/slog"
++	"path/filepath"
  	"strings"
  	"github.com/jackc/pgx/v5"
  	reposdb "github.com/tenseleyFlow/shithub/internal/repos/sqlc"
  	"github.com/tenseleyFlow/shithub/internal/worker"
  	workerdb "github.com/tenseleyFlow/shithub/internal/worker/sqlc"
--
--	"path/filepath"
  )
  // PushProcessDeps wires the data this handler needs.

internal/worker/jobs/repo_index_reconcile.gomodified

  			return err
  		}
  		for _, r := range repos {
--			if _, err := worker.Enqueue(ctx, deps.Pool, worker.KindRepoIndexCode,
++			if _, err := worker.Enqueue(
++				ctx, deps.Pool, worker.KindRepoIndexCode,
  				map[string]any{"repo_id": r.ID},
  				worker.EnqueueOptions{},
  			); err != nil {

internal/worker/pool.gomodified


 	cancel()
 	metrics.WorkerJobDurationSeconds.WithLabelValues(job.Kind).Observe(time.Since(start).Seconds())
 
+	logger.InfoContext(
+		ctx, "worker: dispatched",
 		"job_id", job.ID,
 		"kind", job.Kind,
 		"attempt", job.Attempts,

`@@ -83,9 +83,9 @@` var reservedNames = map[string]struct{}{
83	"shithubd": {},	83	"shithubd": {},
84	"shithubbot": {},	84	"shithubbot": {},
85	// S29 — notification subscribe/unsubscribe per thread.	85	// S29 — notification subscribe/unsubscribe per thread.
86	- "threads": {},	86	+ "threads": {},
87	// S30 — invitation accept/decline.	87	// S30 — invitation accept/decline.
88	- "invitations": {},	88	+ "invitations": {},
89	}	89	}
90		90
91	// IsReserved reports whether name is on the reserved list. The check is	91	// IsReserved reports whether name is on the reserved list. The check is

tenseleyflow/shithub / `fa6f995`

gofumpt sweep — formatter now runs in CI

70 changed files

`@@ -119,8 +119,8 @@` func Dismiss(ctx context.Context, deps Deps, actorUserID, reviewID int64, reason
119	return err	119	return err
120	}	120	}
121	return q.DismissPRReview(ctx, deps.Pool, pullsdb.DismissPRReviewParams{	121	return q.DismissPRReview(ctx, deps.Pool, pullsdb.DismissPRReviewParams{
122	- ID: reviewID,	122	+ ID: reviewID,
123	- DismissedByUserID: pgtype.Int8{Int64: actorUserID, Valid: actorUserID != 0},	123	+ DismissedByUserID: pgtype.Int8{Int64: actorUserID, Valid: actorUserID != 0},
124	- DismissalReason: strings.TrimSpace(reason),	124	+ DismissalReason: strings.TrimSpace(reason),
125	})	125	})
126	}	126	}

`@@ -26,10 +26,10 @@` import (
26	// the rule set. Allow=true means the push proceeds; Allow=false	26	// the rule set. Allow=true means the push proceeds; Allow=false
27	// surfaces the reason+rule pattern back to the user via stderr.	27	// surfaces the reason+rule pattern back to the user via stderr.
28	type Decision struct {	28	type Decision struct {
29	- Allow bool	29	+ Allow bool
30	- Reason string	30	+ Reason string
31	- RuleID int64	31	+ RuleID int64
32	- Pattern string	32	+ Pattern string
33	}	33	}
34		34
35	// Update is one ref update from the pre-receive hook's stdin.	35	// Update is one ref update from the pre-receive hook's stdin.
`@@ -178,4 +178,3 @@` func FriendlyMessage(d Decision) string {
178	}	178	}
179	return fmt.Sprintf("shithub: %s (rule pattern %q).", d.Reason, d.Pattern)	179	return fmt.Sprintf("shithub: %s (rule pattern %q).", d.Reason, d.Pattern)
180	}	180	}
181	-

`@@ -257,7 +257,8 @@` func (p Pool) runOne(ctx context.Context, kind Kind, logger slog.Logger) (bool
257	cancel()	257	cancel()
258	metrics.WorkerJobDurationSeconds.WithLabelValues(job.Kind).Observe(time.Since(start).Seconds())	258	metrics.WorkerJobDurationSeconds.WithLabelValues(job.Kind).Observe(time.Since(start).Seconds())
259		259
260	- logger.InfoContext(ctx, "worker: dispatched",	260	+ logger.InfoContext(
		261	+ ctx, "worker: dispatched",
261	"job_id", job.ID,	262	"job_id", job.ID,
262	"kind", job.Kind,	263	"kind", job.Kind,
263	"attempt", job.Attempts,	264	"attempt", job.Attempts,