fortrangoingonforty/facsimile / 3d6f981

Browse files

compiler warnings

Authored by espadonne
SHA
3d6f981b6f5af616406ddf6c14af556663f49fdf
Parents
b251bb4
Tree
5f157d6

9 changed files

StatusFile+-
M src/commands/command_handler_module.f90 2 2
M src/lsp/server_detection_module.f90 2 3
M src/syntax/syntax_highlighter_module.f90 1 0
M src/terminal/renderer_module.f90 3 3
M src/ui/command_palette_module.f90 6 6
M src/ui/diagnostics_panel_module.f90 3 3
M src/ui/lsp_server_installer_panel_module.f90 5 5
M src/ui/references_panel_module.f90 4 5
M src/workspace/file_tree_renderer_module.f90 5 5
src/commands/command_handler_module.f90modified
@@ -262,7 +262,7 @@ contains
262
         if (is_lsp_server_installer_panel_visible(editor%lsp_installer_panel)) then
262
         if (is_lsp_server_installer_panel_visible(editor%lsp_installer_panel)) then
263
             if (lsp_server_installer_panel_handle_key(editor%lsp_installer_panel, trim(key_str))) then
263
             if (lsp_server_installer_panel_handle_key(editor%lsp_installer_panel, trim(key_str))) then
264
                 call render_lsp_server_installer_panel(editor%lsp_installer_panel, &
264
                 call render_lsp_server_installer_panel(editor%lsp_installer_panel, &
265
-                    editor%screen_rows, editor%screen_cols)
265
+                    editor%screen_cols)
266
                 return
266
                 return
267
             end if
267
             end if
268
         end if
268
         end if
@@ -1583,7 +1583,7 @@ contains
1583
                 use command_palette_module, only: show_command_palette_interactive
1583
                 use command_palette_module, only: show_command_palette_interactive
1584
                 character(len=:), allocatable :: cmd_id
1584
                 character(len=:), allocatable :: cmd_id
1585
 
1585
 
1586
-                cmd_id = show_command_palette_interactive(editor%command_palette, editor%screen_rows, editor%screen_cols)
1586
+                cmd_id = show_command_palette_interactive(editor%command_palette, editor%screen_cols)
1587
 
1587
 
1588
                 if (allocated(cmd_id) .and. len_trim(cmd_id) > 0) then
1588
                 if (allocated(cmd_id) .and. len_trim(cmd_id) > 0) then
1589
                     ! Execute the command by re-processing as a key
1589
                     ! Execute the command by re-processing as a key
src/lsp/server_detection_module.f90modified
@@ -34,7 +34,7 @@ contains
34
         allocate(servers(num_servers))
34
         allocate(servers(num_servers))
35
 
35
 
36
         ! Initialize all known servers
36
         ! Initialize all known servers
37
-        call init_known_servers(servers, num_servers)
37
+        call init_known_servers(servers)
38
 
38
 
39
         ! Check which are installed
39
         ! Check which are installed
40
         do i = 1, num_servers
40
         do i = 1, num_servers
@@ -42,9 +42,8 @@ contains
42
         end do
42
         end do
43
     end subroutine detect_all_servers
43
     end subroutine detect_all_servers
44
 
44
 
45
-    subroutine init_known_servers(servers, num_servers)
45
+    subroutine init_known_servers(servers)
46
         type(detected_server_t), intent(inout) :: servers(:)
46
         type(detected_server_t), intent(inout) :: servers(:)
47
-        integer, intent(in) :: num_servers
48
         integer :: i
47
         integer :: i
49
 
48
 
50
         i = 1
49
         i = 1
src/syntax/syntax_highlighter_module.f90modified
@@ -137,6 +137,7 @@ contains
137
         character(len=*), intent(in) :: line
137
         character(len=*), intent(in) :: line
138
         type(token_t), allocatable, intent(out) :: tokens(:)
138
         type(token_t), allocatable, intent(out) :: tokens(:)
139
         integer :: i, line_len, token_count
139
         integer :: i, line_len, token_count
140
+        character :: ch
140
 
141
 
141
         if (.not. highlighter%enabled) then
142
         if (.not. highlighter%enabled) then
142
             allocate(tokens(1))
143
             allocate(tokens(1))
src/terminal/renderer_module.f90modified
@@ -219,7 +219,7 @@ contains
219
                 ! Render LSP server installer panel if visible (for panes path)
219
                 ! Render LSP server installer panel if visible (for panes path)
220
                 if (is_lsp_server_installer_panel_visible(editor%lsp_installer_panel)) then
220
                 if (is_lsp_server_installer_panel_visible(editor%lsp_installer_panel)) then
221
                     call render_lsp_server_installer_panel(editor%lsp_installer_panel, &
221
                     call render_lsp_server_installer_panel(editor%lsp_installer_panel, &
222
-                        editor%screen_rows, editor%screen_cols)
222
+                        editor%screen_cols)
223
                 end if
223
                 end if
224
 
224
 
225
                 ! Position cursor for panes
225
                 ! Position cursor for panes
@@ -296,7 +296,7 @@ contains
296
         ! Render LSP server installer panel if visible
296
         ! Render LSP server installer panel if visible
297
         if (is_lsp_server_installer_panel_visible(editor%lsp_installer_panel)) then
297
         if (is_lsp_server_installer_panel_visible(editor%lsp_installer_panel)) then
298
             call render_lsp_server_installer_panel(editor%lsp_installer_panel, &
298
             call render_lsp_server_installer_panel(editor%lsp_installer_panel, &
299
-                editor%screen_rows, editor%screen_cols)
299
+                editor%screen_cols)
300
         end if
300
         end if
301
 
301
 
302
         ! Position cursor for panes or regular view
302
         ! Position cursor for panes or regular view
@@ -908,7 +908,7 @@ contains
908
         ! Render LSP server installer panel if visible
908
         ! Render LSP server installer panel if visible
909
         if (is_lsp_server_installer_panel_visible(editor%lsp_installer_panel)) then
909
         if (is_lsp_server_installer_panel_visible(editor%lsp_installer_panel)) then
910
             call render_lsp_server_installer_panel(editor%lsp_installer_panel, &
910
             call render_lsp_server_installer_panel(editor%lsp_installer_panel, &
911
-                editor%screen_rows, editor%screen_cols)
911
+                editor%screen_cols)
912
         end if
912
         end if
913
 
913
 
914
         ! Position cursor in editor pane (use appropriate method based on pane count)
914
         ! Position cursor in editor pane (use appropriate method based on pane count)
src/ui/command_palette_module.f90modified
@@ -292,9 +292,9 @@ contains
292
         end select
292
         end select
293
     end subroutine command_palette_handle_key
293
     end subroutine command_palette_handle_key
294
 
294
 
295
-    subroutine render_command_palette(palette, screen_rows, screen_cols)
295
+    subroutine render_command_palette(palette, screen_cols)
296
         type(command_palette_t), intent(in) :: palette
296
         type(command_palette_t), intent(in) :: palette
297
-        integer, intent(in) :: screen_rows, screen_cols
297
+        integer, intent(in) :: screen_cols
298
         integer :: i, visible_start, visible_end, row, start_col, start_row
298
         integer :: i, visible_start, visible_end, row, start_col, start_row
299
         integer :: content_width, display_width
299
         integer :: content_width, display_width
300
         character(len=256) :: line, category_tag
300
         character(len=256) :: line, category_tag
@@ -411,10 +411,10 @@ contains
411
         call terminal_move_cursor(start_row + 2, start_col + 4 + palette%search_pos)
411
         call terminal_move_cursor(start_row + 2, start_col + 4 + palette%search_pos)
412
     end subroutine render_command_palette
412
     end subroutine render_command_palette
413
 
413
 
414
-    function show_command_palette_interactive(palette, screen_rows, screen_cols) result(selected_cmd_id)
414
+    function show_command_palette_interactive(palette, screen_cols) result(selected_cmd_id)
415
         use input_handler_module, only: get_key_input
415
         use input_handler_module, only: get_key_input
416
         type(command_palette_t), intent(inout) :: palette
416
         type(command_palette_t), intent(inout) :: palette
417
-        integer, intent(in) :: screen_rows, screen_cols
417
+        integer, intent(in) :: screen_cols
418
         character(len=:), allocatable :: selected_cmd_id
418
         character(len=:), allocatable :: selected_cmd_id
419
         character(len=32) :: key_input
419
         character(len=32) :: key_input
420
         integer :: ch, status
420
         integer :: ch, status
@@ -422,7 +422,7 @@ contains
422
         type(command_t) :: cmd
422
         type(command_t) :: cmd
423
 
423
 
424
         call show_command_palette(palette)
424
         call show_command_palette(palette)
425
-        call render_command_palette(palette, screen_rows, screen_cols)
425
+        call render_command_palette(palette, screen_cols)
426
 
426
 
427
         do
427
         do
428
             call get_key_input(key_input, status)
428
             call get_key_input(key_input, status)
@@ -460,7 +460,7 @@ contains
460
                 end if
460
                 end if
461
             end if
461
             end if
462
 
462
 
463
-            call render_command_palette(palette, screen_rows, screen_cols)
463
+            call render_command_palette(palette, screen_cols)
464
         end do
464
         end do
465
     end function show_command_palette_interactive
465
     end function show_command_palette_interactive
466
 
466
 
src/ui/diagnostics_panel_module.f90modified
@@ -250,7 +250,7 @@ contains
250
             do while (screen_line < max_content_lines)
250
             do while (screen_line < max_content_lines)
251
                 screen_line = screen_line + 1
251
                 screen_line = screen_line + 1
252
                 call terminal_move_cursor(row + screen_line - 1, start_col)
252
                 call terminal_move_cursor(row + screen_line - 1, start_col)
253
-                call render_empty_line(start_col, panel%width)
253
+                call render_empty_line(panel%width)
254
             end do
254
             end do
255
         end block
255
         end block
256
 
256
 
@@ -266,8 +266,8 @@ contains
266
 
266
 
267
     end subroutine render_diagnostics_panel
267
     end subroutine render_diagnostics_panel
268
 
268
 
269
-    subroutine render_empty_line(start_col, width)
269
+    subroutine render_empty_line(width)
270
-        integer, intent(in) :: start_col, width
270
+        integer, intent(in) :: width
271
 
271
 
272
         call terminal_write(char(27) // '[48;5;235m')  ! Dark background
272
         call terminal_write(char(27) // '[48;5;235m')  ! Dark background
273
         call terminal_write(repeat(' ', width))
273
         call terminal_write(repeat(' ', width))
src/ui/lsp_server_installer_panel_module.f90modified
@@ -167,9 +167,9 @@ contains
167
         end select
167
         end select
168
     end function lsp_server_installer_panel_handle_key
168
     end function lsp_server_installer_panel_handle_key
169
 
169
 
170
-    subroutine render_lsp_server_installer_panel(panel, screen_rows, screen_cols)
170
+    subroutine render_lsp_server_installer_panel(panel, screen_cols)
171
         type(lsp_server_installer_panel_t), intent(in) :: panel
171
         type(lsp_server_installer_panel_t), intent(in) :: panel
172
-        integer, intent(in) :: screen_rows, screen_cols
172
+        integer, intent(in) :: screen_cols
173
         integer :: start_col, start_row, row, i, visible_end
173
         integer :: start_col, start_row, row, i, visible_end
174
         integer :: content_width, visible_len, status_len, padding
174
         integer :: content_width, visible_len, status_len, padding
175
         character(len=:), allocatable :: border_top, border_mid, border_bottom
175
         character(len=:), allocatable :: border_top, border_mid, border_bottom
@@ -197,7 +197,7 @@ contains
197
 
197
 
198
         ! Render confirm dialog if in confirm mode
198
         ! Render confirm dialog if in confirm mode
199
         if (panel%confirm_mode) then
199
         if (panel%confirm_mode) then
200
-            call render_confirm_dialog(panel, screen_rows, screen_cols)
200
+            call render_confirm_dialog(panel, screen_cols)
201
             return
201
             return
202
         end if
202
         end if
203
 
203
 
@@ -309,9 +309,9 @@ contains
309
         call terminal_hide_cursor()
309
         call terminal_hide_cursor()
310
     end subroutine render_lsp_server_installer_panel
310
     end subroutine render_lsp_server_installer_panel
311
 
311
 
312
-    subroutine render_confirm_dialog(panel, screen_rows, screen_cols)
312
+    subroutine render_confirm_dialog(panel, screen_cols)
313
         type(lsp_server_installer_panel_t), intent(in) :: panel
313
         type(lsp_server_installer_panel_t), intent(in) :: panel
314
-        integer, intent(in) :: screen_rows, screen_cols
314
+        integer, intent(in) :: screen_cols
315
         integer :: start_col, start_row, row, content_width
315
         integer :: start_col, start_row, row, content_width
316
         character(len=:), allocatable :: border_top, border_bottom
316
         character(len=:), allocatable :: border_top, border_bottom
317
         character(len=256) :: server_name, install_cmd
317
         character(len=256) :: server_name, install_cmd
src/ui/references_panel_module.f90modified
@@ -194,8 +194,7 @@ contains
194
 
194
 
195
         ! Clear to end of header line
195
         ! Clear to end of header line
196
         call terminal_move_cursor(row, start_col + len_trim(header))
196
         call terminal_move_cursor(row, start_col + len_trim(header))
197
-        call render_empty_line(start_col + len_trim(header), &
197
+        call render_empty_line(panel%width - len_trim(header))
198
-            panel%width - len_trim(header))
199
 
198
 
200
         row = row + 1
199
         row = row + 1
201
 
200
 
@@ -271,7 +270,7 @@ contains
271
             do i = row, start_row + max_visible + 1
270
             do i = row, start_row + max_visible + 1
272
                 if (i > panel%screen_height - 1) exit
271
                 if (i > panel%screen_height - 1) exit
273
                 call terminal_move_cursor(i, start_col)
272
                 call terminal_move_cursor(i, start_col)
274
-                call render_empty_line(start_col, panel%width)
273
+                call render_empty_line(panel%width)
275
             end do
274
             end do
276
 
275
 
277
             ! Show scroll indicator if needed
276
             ! Show scroll indicator if needed
@@ -291,8 +290,8 @@ contains
291
         end if
290
         end if
292
     end subroutine render_references_panel
291
     end subroutine render_references_panel
293
 
292
 
294
-    subroutine render_empty_line(start_col, width)
293
+    subroutine render_empty_line(width)
295
-        integer, intent(in) :: start_col, width
294
+        integer, intent(in) :: width
296
         call terminal_write(char(27) // '[48;5;235m' // repeat(" ", width) // char(27) // '[0m')
295
         call terminal_write(char(27) // '[48;5;235m' // repeat(" ", width) // char(27) // '[0m')
297
     end subroutine render_empty_line
296
     end subroutine render_empty_line
298
 
297
 
src/workspace/file_tree_renderer_module.f90modified
@@ -53,10 +53,10 @@ contains
53
         if (associated(state%root)) then
53
         if (associated(state%root)) then
54
             item_idx = 0
54
             item_idx = 0
55
             if (hints_expanded) then
55
             if (hints_expanded) then
56
-                call render_tree_node(state%root, '', .true., .true., &
56
+                call render_tree_node(state%root, '', .true., &
57
                                     state, item_idx, current_row, end_row - 4, start_col, width)
57
                                     state, item_idx, current_row, end_row - 4, start_col, width)
58
             else
58
             else
59
-                call render_tree_node(state%root, '', .true., .true., &
59
+                call render_tree_node(state%root, '', .true., &
60
                                     state, item_idx, current_row, end_row - 1, start_col, width)
60
                                     state, item_idx, current_row, end_row - 1, start_col, width)
61
             end if
61
             end if
62
         end if
62
         end if
@@ -100,11 +100,11 @@ contains
100
         end if
100
         end if
101
     end subroutine render_file_tree
101
     end subroutine render_file_tree
102
 
102
 
103
-    recursive subroutine render_tree_node(node, prefix, is_last, is_root, &
103
+    recursive subroutine render_tree_node(node, prefix, is_root, &
104
                                          state, item_idx, current_row, end_row, start_col, width)
104
                                          state, item_idx, current_row, end_row, start_col, width)
105
         type(tree_node_t), pointer, intent(in) :: node
105
         type(tree_node_t), pointer, intent(in) :: node
106
         character(len=*), intent(in) :: prefix
106
         character(len=*), intent(in) :: prefix
107
-        logical, intent(in) :: is_last, is_root
107
+        logical, intent(in) :: is_root
108
         type(tree_state_t), intent(in) :: state
108
         type(tree_state_t), intent(in) :: state
109
         integer, intent(inout) :: item_idx, current_row
109
         integer, intent(inout) :: item_idx, current_row
110
         integer, intent(in) :: end_row, start_col, width
110
         integer, intent(in) :: end_row, start_col, width
@@ -196,7 +196,7 @@ contains
196
                 new_prefix = prefix // '  '
196
                 new_prefix = prefix // '  '
197
             end if
197
             end if
198
 
198
 
199
-            call render_tree_node(child, new_prefix, is_last_child, .false., &
199
+            call render_tree_node(child, new_prefix, .false., &
200
                                 state, item_idx, current_row, end_row, start_col, width)
200
                                 state, item_idx, current_row, end_row, start_col, width)
201
             child => child%next_sibling
201
             child => child%next_sibling
202
             end do
202
             end do